Changeset 290047 in webkit

Timestamp:

Feb 17, 2022 12:05:29 PM (5 months ago)

Author:

Patrick Angle

Message:

Web Inspector: [Flexbox] Gaps and free space do not have pattern fills when navigating to a page with Web Inspector already open
​https://bugs.webkit.org/show_bug.cgi?id=236741

Reviewed by Devin Rousso.

Because calls to getDocument actually resets the InspectorDOMAgent, we don't want to clear cached layout
information inside reset. The cached layout information is in a WeakHashMap, we aren't going to end up keeping
stale references around anyways, and the under most circumstances the map will clean itself up as it is used.
We should, however go ahead and clear the cached layout information when we are forcing a re-layout to collect
the information again for a new document.

Additionally, if a new document is set, we want to trigger a layout just like we did for a fresh
InspectorDOMAgent.

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setDocument):
(WebCore::InspectorDOMAgent::relayoutDocument):

• inspector/agents/InspectorDOMAgent.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/agents/InspectorDOMAgent.cpp (modified) (4 diffs)
• inspector/agents/InspectorDOMAgent.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-17  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: [Flexbox] Gaps and free space do not have pattern fills when navigating to a page with Web Inspector already open
+        https://bugs.webkit.org/show_bug.cgi?id=236741
+
+        Reviewed by Devin Rousso.
+
+        Because calls to `getDocument` actually resets the `InspectorDOMAgent`, we don't want to clear cached layout
+        information inside `reset`. The cached layout information is in a WeakHashMap, we aren't going to end up keeping
+        stale references around anyways, and the under most circumstances the map will clean itself up as it is used.
+        We should, however go ahead and clear the cached layout information when we are forcing a re-layout to collect
+        the information again for a new document.
+
+        Additionally, if a new document is set, we want to trigger a layout just like we did for a fresh
+        `InspectorDOMAgent`.
+
+        * inspector/agents/InspectorDOMAgent.cpp:
+        (WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
+        (WebCore::InspectorDOMAgent::reset):
+        (WebCore::InspectorDOMAgent::setDocument):
+        (WebCore::InspectorDOMAgent::relayoutDocument):
+        * inspector/agents/InspectorDOMAgent.h:
+
 2022-02-17  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp

@@ -310 +310 @@
 
     // Force a layout so that we can collect additional information from the layout process.
-    if (m_document)
-        m_document->updateLayout();
+    relayoutDocument();
 
 #if ENABLE(VIDEO)
@@ -363 +362 @@
         m_revalidateStyleAttrTask->reset();
     m_document = nullptr;
-    m_flexibleBoxRendererCachedItemsAtStartOfLine.clear();
 
     m_destroyedDetachedNodeIdentifiers.clear();
@@ -380 +378 @@
     m_document = document;
 
+    // Force a layout so that we can collect additional information from the layout process.
+    relayoutDocument();
+
     if (!m_documentRequested)
         return;
@@ -386 +387 @@
     if (!document || !document->parsing())
         m_frontendDispatcher->documentUpdated();
+}
+
+void InspectorDOMAgent::relayoutDocument()
+{
+    if (!m_document)
+        return;
+
+    m_flexibleBoxRendererCachedItemsAtStartOfLine.clear();
+    
+    m_document->updateLayout();
 }
 

trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h

@@ -255 +255 @@
     void destroyedNodesTimerFired();
 
+    void relayoutDocument();
+
     Inspector::InjectedScriptManager& m_injectedScriptManager;
     std::unique_ptr<Inspector::DOMFrontendDispatcher> m_frontendDispatcher;