Changeset 290247 in webkit


Ignore:
Timestamp:
Feb 21, 2022 9:50:40 AM (5 months ago)
Author:
Noam Rosenthal
Message:

PerformanceObserver: buffered flag not working in Paint Timing
​https://bugs.webkit.org/show_bug.cgi?id=225305
<rdar://problem/77746237>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/paint-timing/fcp-only/buffered-flag.window-expected.txt: This test now passes

Source/WebCore:

Include paint entries when collecting buffered performance entries.

A previously failing W3C test is now marked as passing.

  • page/Performance.cpp:

(WebCore::Performance::appendBufferedEntriesByType const): Add the existing FCP entry

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r290232 r290247  
     12022-02-21  Noam Rosenthal  <noam@webkit.org>
     2
     3        PerformanceObserver: buffered flag not working in Paint Timing
     4        https://bugs.webkit.org/show_bug.cgi?id=225305
     5        <rdar://problem/77746237>
     6
     7        Reviewed by Simon Fraser.
     8
     9        * web-platform-tests/paint-timing/fcp-only/buffered-flag.window-expected.txt: This test now passes
     10
    1112022-02-20  Tim Nguyen  <ntim@apple.com>
    212

  • trunk/LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/buffered-flag.window-expected.txt

    r290080 r290247  
    11
    2 Harness Error (TIMEOUT), message = null
     2PASS PerformanceObserver with buffered flag sees previous FCP entry.
    33
    4 TIMEOUT PerformanceObserver with buffered flag sees previous FCP entry. Test timed out
    5 

  • trunk/Source/WebCore/ChangeLog

    r290240 r290247  
     12022-02-21  Noam Rosenthal  <noam@webkit.org>
     2
     3        PerformanceObserver: buffered flag not working in Paint Timing
     4        https://bugs.webkit.org/show_bug.cgi?id=225305
     5        <rdar://problem/77746237>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Include paint entries when collecting buffered performance entries.
     10
     11        A previously failing W3C test is now marked as passing.
     12
     13        * page/Performance.cpp:
     14        (WebCore::Performance::appendBufferedEntriesByType const): Add the existing FCP entry
     15
    1162022-02-21  Alan Bujtas  <zalan@apple.com>
    217

  • trunk/Source/WebCore/page/Performance.cpp

    r282755 r290247  
    219219        entries.appendVector(m_resourceTimingBuffer);
    220220
     221    if (entryType == "paint" && m_firstContentfulPaint)
     222        entries.append(m_firstContentfulPaint);
     223
    221224    if (m_userTiming) {
    222225        if (entryType.isNull() || entryType == "mark")
Note: See TracChangeset for help on using the changeset viewer.