Changeset 290570 in webkit

Timestamp:

Feb 27, 2022 1:19:37 PM (5 months ago)

Author:

graouts@webkit.org

Message:

[svg] stroke-opacity should be clamped to the [0,1] range
​https://bugs.webkit.org/show_bug.cgi?id=237254

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

• web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:

Source/WebCore:

• rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setStrokeOpacity):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/SVGRenderStyle.h (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2022-02-27  Antoine Quint  <graouts@webkit.org>
+
+        [svg] stroke-opacity should be clamped to the [0,1] range
+        https://bugs.webkit.org/show_bug.cgi?id=237254
+
+        Reviewed by Dean Jackson.
+
+        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
+        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
+
 2022-02-27  Antoine Quint  <graouts@webkit.org>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

@@ -133 +133 @@
 PASS stroke-opacity (type: opacity) has testAccumulation function
 PASS stroke-opacity: [0, 1] number
-FAIL stroke-opacity: [0, 1] number (clamped) assert_equals: The value should be 1 at 0ms expected "1" but got "1.1"
+PASS stroke-opacity: [0, 1] number (clamped)
 PASS table-layout (type: discrete) has testAccumulation function
 PASS table-layout: "fixed" onto "auto"

trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

@@ -133 +133 @@
 PASS stroke-opacity (type: opacity) has testAddition function
 PASS stroke-opacity: [0, 1] number
-FAIL stroke-opacity: [0, 1] number (clamped) assert_equals: The value should be 1 at 0ms expected "1" but got "1.1"
+PASS stroke-opacity: [0, 1] number (clamped)
 PASS table-layout (type: discrete) has testAddition function
 PASS table-layout: "fixed" onto "auto"

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-27  Antoine Quint  <graouts@webkit.org>
+
+        [svg] stroke-opacity should be clamped to the [0,1] range
+        https://bugs.webkit.org/show_bug.cgi?id=237254
+
+        Reviewed by Dean Jackson.
+
+        * rendering/style/SVGRenderStyle.h:
+        (WebCore::SVGRenderStyle::setStrokeOpacity):
+
 2022-02-27  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/rendering/style/SVGRenderStyle.h

@@ -310 +310 @@
 inline void SVGRenderStyle::setStrokeOpacity(float opacity)
 {
-    if (!(m_strokeData->opacity == opacity))
-        m_strokeData.access().opacity = opacity;
+    auto clampedOpacity = clampTo<float>(opacity, 0.f, 1.f);
+    if (!(m_strokeData->opacity == clampedOpacity))
+        m_strokeData.access().opacity = clampedOpacity;
 }