Changeset 290674 in webkit

Timestamp:

Mar 1, 2022 1:57:06 PM (5 months ago)

Author:

Matt Woodrow

Message:

Use static position relative to parent for abs-pos items within nested grids.
​https://bugs.webkit.org/show_bug.cgi?id=236957

Reviewed by Dean Jackson.

Source/WebCore:

In the case where an absolutely positioned element's parent and containing block
are both grid container, but they are not the same grid container, then the static position
of the abs-pos item should be relative to the parent, not the CB.

Existing subgrid tests marked as passing.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::setLogicalOffsetForChild const):

LayoutTests:

• TestExpectations:

Existing subgrid tests marked as passing.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderGrid.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-03-01  Matt Woodrow  <mattwoodrow@apple.com>
+
+        Use static position relative to parent for abs-pos items within nested grids.
+        https://bugs.webkit.org/show_bug.cgi?id=236957
+
+        Reviewed by Dean Jackson.
+
+        * TestExpectations:
+
+       Existing subgrid tests marked as passing.
+
 2022-03-01  Andres Gonzalez  <andresg_22@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -1400 +1400 @@
 webkit.org/b/236959 imported/w3c/web-platform-tests/css/css-grid/subgrid/baseline-001.html [ ImageOnlyFailure ]
 webkit.org/b/236956 imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-gap-003.html [ ImageOnlyFailure ]
-webkit.org/b/236957 imported/w3c/web-platform-tests/css/css-grid/subgrid/line-names-007.html [ ImageOnlyFailure ]
 webkit.org/b/236958 imported/w3c/web-platform-tests/css/css-grid/subgrid/repeat-auto-fill-003.html [ ImageOnlyFailure ]
 webkit.org/b/236949 imported/w3c/web-platform-tests/css/css-grid/subgrid/subgrid-mbp-overflow-001.html [ ImageOnlyFailure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-01  Matt Woodrow  <mattwoodrow@apple.com>
+
+        Use static position relative to parent for abs-pos items within nested grids.
+        https://bugs.webkit.org/show_bug.cgi?id=236957
+
+        Reviewed by Dean Jackson.
+
+        In the case where an absolutely positioned element's parent and containing block
+        are both grid container, but they are not the same grid container, then the static position
+        of the abs-pos item should be relative to the parent, not the CB.
+
+        Existing subgrid tests marked as passing.
+
+        * rendering/RenderGrid.cpp:
+        (WebCore::RenderGrid::setLogicalOffsetForChild const):
+
 2022-03-01  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/rendering/RenderGrid.cpp

@@ -1901 +1901 @@
 void RenderGrid::setLogicalOffsetForChild(RenderBox& child, GridTrackSizingDirection direction) const
 {
-    if (!child.isGridItem() && hasStaticPositionForChild(child, direction))
+    if (child.parent() != this && hasStaticPositionForChild(child, direction))
         return;
     // 'setLogicalLeft' and 'setLogicalTop' only take into account the child's writing-mode, that's why 'flowAwareDirectionForChild' is needed.