Changeset 290734 in webkit

Timestamp:

Mar 2, 2022 9:09:34 AM (5 months ago)

Author:

Alan Bujtas

Message:

[RTL] Image alt text has incorrect bidi reordering
​https://bugs.webkit.org/show_bug.cgi?id=237366
<rdar://problem/89687229>

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/images/alt-text-with-right-to-left-inline-direction-reordering.html

• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced): Enable bidi reordering.

LayoutTests:

• fast/images/alt-text-with-right-to-left-inline-direction-reordering-expected-mismatch.html: Added.
• fast/images/alt-text-with-right-to-left-inline-direction-reordering.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/images/alt-text-with-right-to-left-inline-direction-reordering-expected-mismatch.html (added)
• LayoutTests/fast/images/alt-text-with-right-to-left-inline-direction-reordering.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderImage.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-03-02  Alan Bujtas  <zalan@apple.com>
+
+        [RTL] Image alt text has incorrect bidi reordering
+        https://bugs.webkit.org/show_bug.cgi?id=237366
+        <rdar://problem/89687229>
+
+        Reviewed by Antti Koivisto.
+
+        * fast/images/alt-text-with-right-to-left-inline-direction-reordering-expected-mismatch.html: Added.
+        * fast/images/alt-text-with-right-to-left-inline-direction-reordering.html: Added.
+
 2022-03-02  Oriol Brufau  <obrufau@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-02  Alan Bujtas  <zalan@apple.com>
+
+        [RTL] Image alt text has incorrect bidi reordering
+        https://bugs.webkit.org/show_bug.cgi?id=237366
+        <rdar://problem/89687229>
+
+        Reviewed by Antti Koivisto.
+
+        Test: fast/images/alt-text-with-right-to-left-inline-direction-reordering.html
+
+        * rendering/RenderImage.cpp:
+        (WebCore::RenderImage::paintReplaced): Enable bidi reordering.
+
 2022-03-02  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/rendering/RenderImage.cpp

@@ -532 +532 @@
                 auto& font = style().fontCascade();
                 auto& fontMetrics = font.metricsOfPrimaryFont();
-                auto textRun = RenderBlock::constructTextRun(document().displayStringModifiedByEncoding(m_altText), style());
+                auto textRun = RenderBlock::constructTextRun(document().displayStringModifiedByEncoding(m_altText), style(), DefaultExpansion, RespectDirection | RespectDirectionOverride);
                 auto textWidth = LayoutUnit { font.width(textRun) };