Changeset 290735 in webkit

Timestamp:

Mar 2, 2022 10:47:09 AM (5 months ago)

Author:

graouts@webkit.org

Message:

Outline-width with transition don't animate correctly
​https://bugs.webkit.org/show_bug.cgi?id=173708

Reviewed by Antti Koivisto.

Source/WebCore:

Account for a change in outline size when checking whether a style change affects
visual overflow.

No new test for this, I'm not sure how to write one since the issue is failing to
repaint during an animation but WKTR seems to force a repaint for reftests.

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeAffectsVisualOverflow const):

LayoutTests:

Add a repaint test that checks that the outline is accounted for during the transition.

• fast/repaint/outline-transition-expected.txt: Added.
• fast/repaint/outline-transition.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/outline-transition-expected.txt (added)
• LayoutTests/fast/repaint/outline-transition.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/RenderStyle.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-03-02  Antoine Quint  <graouts@webkit.org>
+
+        Outline-width with transition don't animate correctly
+        https://bugs.webkit.org/show_bug.cgi?id=173708
+
+        Reviewed by Antti Koivisto.
+
+        Add a repaint test that checks that the outline is accounted for during the transition.
+
+        * fast/repaint/outline-transition-expected.txt: Added.
+        * fast/repaint/outline-transition.html: Added.
+
 2022-03-02  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-02  Antoine Quint  <graouts@webkit.org>
+
+        Outline-width with transition don't animate correctly
+        https://bugs.webkit.org/show_bug.cgi?id=173708
+
+        Reviewed by Antti Koivisto.
+
+        Account for a change in outline size when checking whether a style change affects
+        visual overflow.
+
+        No new test for this, I'm not sure how to write one since the issue is failing to
+        repaint during an animation but WKTR seems to force a repaint for reftests.
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::changeAffectsVisualOverflow const):
+
 2022-03-02  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/rendering/style/RenderStyle.cpp

@@ -641 +641 @@
     }
 
-    if (hasOutlineInVisualOverflow() != other.hasOutlineInVisualOverflow())
-        return true;
+    auto hasOutlineInVisualOverflow = this->hasOutlineInVisualOverflow();
+    auto otherHasOutlineInVisualOverflow = other.hasOutlineInVisualOverflow();
+    if (hasOutlineInVisualOverflow != otherHasOutlineInVisualOverflow
+        || (hasOutlineInVisualOverflow && otherHasOutlineInVisualOverflow && outlineSize() != other.outlineSize()))
+        return true;
+
     return false;
 }