Changeset 290885 in webkit

Timestamp:

Mar 7, 2022 6:19:40 AM (5 months ago)

Author:

graouts@webkit.org

Message:

[web-animations] line-break should support discrete animations
​https://bugs.webkit.org/show_bug.cgi?id=237520

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:

Source/WebCore:

• animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/CSSPropertyAnimation.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2022-03-07  Antoine Quint  <graouts@webkit.org>
+
+        [web-animations] line-break should support discrete animations
+        https://bugs.webkit.org/show_bug.cgi?id=237520
+
+        Reviewed by Antti Koivisto.
+
+        * web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
+
 2022-03-07  Antoine Quint  <graouts@webkit.org>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt

@@ -28 +28 @@
 FAIL Animation of hyphens in ::marker assert_true: hyphens doesn't seem to be supported in the computed style expected true got false
 PASS Animation of letter-spacing in ::marker
-FAIL Animation of line-break in ::marker assert_equals: expected "anywhere" but got "auto"
+PASS Animation of line-break in ::marker
 PASS Animation of overflow-wrap in ::marker
 PASS Animation of tab-size in ::marker

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-07  Antoine Quint  <graouts@webkit.org>
+
+        [web-animations] line-break should support discrete animations
+        https://bugs.webkit.org/show_bug.cgi?id=237520
+
+        Reviewed by Antti Koivisto.
+
+        * animation/CSSPropertyAnimation.cpp:
+        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+
 2022-03-07  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

@@ -2742 +2742 @@
         new DiscretePropertyWrapper<const StyleSelfAlignmentData&>(CSSPropertyJustifyItems, &RenderStyle::justifyItems, &RenderStyle::setJustifyItems),
         new DiscretePropertyWrapper<const StyleSelfAlignmentData&>(CSSPropertyJustifySelf, &RenderStyle::justifySelf, &RenderStyle::setJustifySelf),
+        new DiscretePropertyWrapper<LineBreak>(CSSPropertyLineBreak, &RenderStyle::lineBreak, &RenderStyle::setLineBreak),
         new DiscretePropertyWrapper<ListStylePosition>(CSSPropertyListStylePosition, &RenderStyle::listStylePosition, &RenderStyle::setListStylePosition),
         new DiscretePropertyWrapper<ListStyleType>(CSSPropertyListStyleType, &RenderStyle::listStyleType, &RenderStyle::setListStyleType),