Changeset 290887 in webkit


Ignore:
Timestamp:
Mar 7, 2022 6:24:46 AM (5 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] text-emphasis-color should support non-discrete animations
​https://bugs.webkit.org/show_bug.cgi?id=237518

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

This property was mistakenly added as a discrete property when it was unprefixed.

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r290886 r290887  
     12022-03-07  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] text-emphasis-color should support non-discrete animations
     4        https://bugs.webkit.org/show_bug.cgi?id=237518
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
     9        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
     11        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
     12
    1132022-03-07  Antoine Quint  <graouts@webkit.org>
    214

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt

    r290886 r290887  
    3636PASS Animation of text-decoration-skip-ink in ::marker
    3737FAIL Animation of text-emphasis in ::marker assert_equals: expected "triangle rgb(50, 100, 100)" but got ""
    38 FAIL Animation of text-emphasis-color in ::marker assert_equals: expected "rgb(50, 100, 100)" but got "rgb(100, 0, 200)"
     38PASS Animation of text-emphasis-color in ::marker
    3939PASS Animation of text-emphasis-position in ::marker
    4040FAIL Animation of text-emphasis-style in ::marker assert_equals: expected "triangle" but got "none"
    … …  
    8383PASS Transition of text-decoration-skip-ink in ::marker
    8484FAIL Transition of text-emphasis in ::marker assert_equals: expected "triangle rgb(50, 100, 100)" but got ""
    85 FAIL Transition of text-emphasis-color in ::marker assert_equals: expected "rgb(50, 100, 100)" but got "rgb(100, 0, 200)"
     85PASS Transition of text-emphasis-color in ::marker
    8686PASS Transition of text-emphasis-position in ::marker
    8787FAIL Transition of text-emphasis-style in ::marker assert_equals: expected "triangle" but got "filled triangle"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

    r290570 r290887  
    154154PASS text-decoration-style: "solid" onto "dotted"
    155155PASS text-emphasis-color (type: color) has testAccumulation function
    156 FAIL text-emphasis-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"
    157 FAIL text-emphasis-color supports animating as color of #RGB assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"
    158 FAIL text-emphasis-color supports animating as color of hsl() assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"
    159 FAIL text-emphasis-color supports animating as color of #RGBa assert_equals: The value should be rgb(230, 128, 128) at 0ms expected "rgb(230, 128, 128)" but got "rgba(255, 0, 0, 0.4)"
    160 FAIL text-emphasis-color supports animating as color of rgba() assert_equals: The value should be rgb(230, 128, 128) at 0ms expected "rgb(230, 128, 128)" but got "rgba(255, 0, 0, 0.4)"
    161 FAIL text-emphasis-color supports animating as color of hsla() assert_equals: The value should be rgb(230, 128, 128) at 0ms expected "rgb(230, 128, 128)" but got "rgba(255, 0, 0, 0.4)"
     156FAIL text-emphasis-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 255) at 500ms expected "rgb(255, 128, 255)" but got "rgb(192, 128, 192)"
     157PASS text-emphasis-color supports animating as color of #RGB
     158PASS text-emphasis-color supports animating as color of hsl()
     159PASS text-emphasis-color supports animating as color of #RGBa
     160PASS text-emphasis-color supports animating as color of rgba()
     161PASS text-emphasis-color supports animating as color of hsla()
    162162PASS text-emphasis-position (type: discrete) has testAccumulation function
    163163PASS text-emphasis-position: "under left" onto "over"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

    r290570 r290887  
    154154PASS text-decoration-style: "solid" onto "dotted"
    155155PASS text-emphasis-color (type: color) has testAddition function
    156 FAIL text-emphasis-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"
    157 FAIL text-emphasis-color supports animating as color of #RGB assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"
    158 FAIL text-emphasis-color supports animating as color of hsl() assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"
    159 FAIL text-emphasis-color supports animating as color of #RGBa assert_equals: The value should be rgb(230, 128, 128) at 0ms expected "rgb(230, 128, 128)" but got "rgba(255, 0, 0, 0.4)"
    160 FAIL text-emphasis-color supports animating as color of rgba() assert_equals: The value should be rgb(230, 128, 128) at 0ms expected "rgb(230, 128, 128)" but got "rgba(255, 0, 0, 0.4)"
    161 FAIL text-emphasis-color supports animating as color of hsla() assert_equals: The value should be rgb(230, 128, 128) at 0ms expected "rgb(230, 128, 128)" but got "rgba(255, 0, 0, 0.4)"
     156FAIL text-emphasis-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 255) at 500ms expected "rgb(255, 128, 255)" but got "rgb(192, 128, 192)"
     157PASS text-emphasis-color supports animating as color of #RGB
     158PASS text-emphasis-color supports animating as color of hsl()
     159PASS text-emphasis-color supports animating as color of #RGBa
     160PASS text-emphasis-color supports animating as color of rgba()
     161PASS text-emphasis-color supports animating as color of hsla()
    162162PASS text-emphasis-position (type: discrete) has testAddition function
    163163PASS text-emphasis-position: "under left" onto "over"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r289903 r290887  
    180180PASS text-decoration-style uses discrete animation when animating between "solid" and "dotted" with keyframe easing
    181181PASS text-emphasis-color (type: color) has testInterpolation function
    182 FAIL text-emphasis-color supports animating as color of rgb() assert_equals: The value should be rgb(128, 0, 128) at 500ms expected "rgb(128, 0, 128)" but got "rgb(0, 0, 255)"
    183 FAIL text-emphasis-color supports animating as color of #RGB assert_equals: The value should be rgb(128, 0, 128) at 500ms expected "rgb(128, 0, 128)" but got "rgb(0, 0, 255)"
    184 FAIL text-emphasis-color supports animating as color of hsl() assert_equals: The value should be rgb(128, 0, 128) at 500ms expected "rgb(128, 0, 128)" but got "rgb(0, 0, 255)"
    185 FAIL text-emphasis-color supports animating as color of #RGBa assert_equals: The value should be rgba(85, 0, 170, 0.6) at 500ms expected "rgba(85, 0, 170, 0.6)" but got "rgba(0, 0, 255, 0.8)"
    186 FAIL text-emphasis-color supports animating as color of rgba() assert_equals: The value should be rgba(85, 0, 170, 0.6) at 500ms expected "rgba(85, 0, 170, 0.6)" but got "rgba(0, 0, 255, 0.8)"
    187 FAIL text-emphasis-color supports animating as color of hsla() assert_equals: The value should be rgba(85, 0, 170, 0.6) at 500ms expected "rgba(85, 0, 170, 0.6)" but got "rgba(0, 0, 255, 0.8)"
     182PASS text-emphasis-color supports animating as color of rgb()
     183PASS text-emphasis-color supports animating as color of #RGB
     184PASS text-emphasis-color supports animating as color of hsl()
     185PASS text-emphasis-color supports animating as color of #RGBa
     186PASS text-emphasis-color supports animating as color of rgba()
     187PASS text-emphasis-color supports animating as color of hsla()
    188188PASS text-emphasis-position (type: discrete) has testInterpolation function
    189189PASS text-emphasis-position uses discrete animation when animating between "over" and "under left" with linear easing

  • trunk/Source/WebCore/ChangeLog

    r290886 r290887  
     12022-03-07  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] text-emphasis-color should support non-discrete animations
     4        https://bugs.webkit.org/show_bug.cgi?id=237518
     5
     6        Reviewed by Antti Koivisto.
     7
     8        This property was mistakenly added as a discrete property when it was unprefixed.
     9
     10        * animation/CSSPropertyAnimation.cpp:
     11        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     12
    1132022-03-07  Antoine Quint  <graouts@webkit.org>
    214

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r290886 r290887  
    27622762        new DiscretePropertyWrapper<OptionSet<TextDecorationLine>>(CSSPropertyTextDecorationLine, &RenderStyle::textDecoration, &RenderStyle::setTextDecoration),
    27632763        new DiscretePropertyWrapper<TextDecorationStyle>(CSSPropertyTextDecorationStyle, &RenderStyle::textDecorationStyle, &RenderStyle::setTextDecorationStyle),
    2764         new DiscretePropertyWrapper<const Color&>(CSSPropertyTextEmphasisColor, &RenderStyle::textEmphasisColor, &RenderStyle::setTextEmphasisColor),
     2764        new PropertyWrapperVisitedAffectedColor(CSSPropertyTextEmphasisColor, MaybeInvalidColor, &RenderStyle::textEmphasisColor, &RenderStyle::setTextEmphasisColor, &RenderStyle::visitedLinkTextEmphasisColor, &RenderStyle::setVisitedLinkTextEmphasisColor),
    27652765        new DiscretePropertyWrapper<OptionSet<TextEmphasisPosition>>(CSSPropertyTextEmphasisPosition, &RenderStyle::textEmphasisPosition, &RenderStyle::setTextEmphasisPosition),
    27662766        new DiscretePropertyWrapper<TextOverflow>(CSSPropertyTextOverflow, &RenderStyle::textOverflow, &RenderStyle::setTextOverflow),
Note: See TracChangeset for help on using the changeset viewer.