Changeset 291042 in webkit


Ignore:
Timestamp:
Mar 9, 2022 4:58:38 AM (4 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] clip-rule should support discrete animations
​https://bugs.webkit.org/show_bug.cgi?id=237609

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::clipRule const):
(WebCore::RenderStyle::setClipRule):

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291041 r291042  
     12022-03-08  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] clip-rule should support discrete animations
     4        https://bugs.webkit.org/show_bug.cgi?id=237609
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
     9        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
     11
    1122022-03-08  Antoine Quint  <graouts@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt

    r291041 r291042  
    127127PASS clip: "rect(10px, 10px, 10px, auto)" onto "rect(10px, 10px, 10px, 10px)"
    128128PASS clip: "rect(10px, 10px, 10px, 10px)" onto "rect(10px, 10px, 10px, auto)"
     129PASS clip-rule (type: discrete) has testAccumulation function
     130PASS clip-rule: "nonzero" onto "evenodd"
     131PASS clip-rule: "evenodd" onto "nonzero"
    129132PASS color (type: color) has testAccumulation function
    130133FAIL color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 255) at 500ms expected "rgb(255, 128, 255)" but got "rgb(192, 128, 192)"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt

    r291041 r291042  
    127127PASS clip: "rect(10px, 10px, 10px, auto)" onto "rect(10px, 10px, 10px, 10px)"
    128128PASS clip: "rect(10px, 10px, 10px, 10px)" onto "rect(10px, 10px, 10px, auto)"
     129PASS clip-rule (type: discrete) has testAddition function
     130PASS clip-rule: "nonzero" onto "evenodd"
     131PASS clip-rule: "evenodd" onto "nonzero"
    129132PASS color (type: color) has testAddition function
    130133FAIL color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 255) at 500ms expected "rgb(255, 128, 255)" but got "rgb(192, 128, 192)"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt

    r291041 r291042  
    155155PASS clip uses discrete animation when animating between "rect(10px, 10px, 10px, 10px)" and "rect(10px, 10px, 10px, auto)" with effect easing
    156156PASS clip uses discrete animation when animating between "rect(10px, 10px, 10px, 10px)" and "rect(10px, 10px, 10px, auto)" with keyframe easing
     157PASS clip-rule (type: discrete) has testInterpolation function
     158PASS clip-rule uses discrete animation when animating between "evenodd" and "nonzero" with linear easing
     159PASS clip-rule uses discrete animation when animating between "evenodd" and "nonzero" with effect easing
     160PASS clip-rule uses discrete animation when animating between "evenodd" and "nonzero" with keyframe easing
    157161PASS color (type: color) has testInterpolation function
    158162PASS color supports animating as color of rgb()

  • trunk/Source/WebCore/ChangeLog

    r291041 r291042  
     12022-03-08  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] clip-rule should support discrete animations
     4        https://bugs.webkit.org/show_bug.cgi?id=237609
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * animation/CSSPropertyAnimation.cpp:
     9        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     10        * rendering/style/RenderStyle.h:
     11        (WebCore::RenderStyle::clipRule const):
     12        (WebCore::RenderStyle::setClipRule):
     13
    1142022-03-08  Antoine Quint  <graouts@webkit.org>
    215

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r291041 r291042  
    28422842        new DiscretePropertyWrapper<Kerning>(CSSPropertyFontKerning, &RenderStyle::fontKerning, &RenderStyle::setFontKerning),
    28432843        new DiscretePropertyWrapper<FontFeatureSettings>(CSSPropertyFontFeatureSettings, &RenderStyle::fontFeatureSettings, &RenderStyle::setFontFeatureSettings),
    2844         new FontFamilyWrapper
     2844        new FontFamilyWrapper,
     2845        new DiscretePropertyWrapper<WindRule>(CSSPropertyClipRule, &RenderStyle::clipRule, &RenderStyle::setClipRule)
    28452846    };
    28462847    const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);

  • trunk/Source/WebCore/rendering/style/RenderStyle.h

    r291041 r291042  
    14311431    SVGRenderStyle& accessSVGStyle() { return m_svgStyle.access(); }
    14321432
     1433    WindRule clipRule() const { return svgStyle().clipRule(); }
     1434    void setClipRule(WindRule clipRule) { accessSVGStyle().setClipRule(clipRule); }
    14331435    ColorInterpolation colorInterpolation() const { return svgStyle().colorInterpolation(); }
    14341436    void setColorInterpolation(ColorInterpolation colorInterpolation) { accessSVGStyle().setColorInterpolation(colorInterpolation); }
Note: See TracChangeset for help on using the changeset viewer.