Changeset 291043 in webkit


Ignore:
Timestamp:
Mar 9, 2022 5:01:55 AM (4 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] color-interpolation-filters should support discrete animation
​https://bugs.webkit.org/show_bug.cgi?id=237637

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::colorInterpolationFilters const):
(WebCore::RenderStyle::setColorInterpolationFilters):

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291042 r291043  
     12022-03-09  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] color-interpolation-filters should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237637
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
     9        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
     11
    1122022-03-08  Antoine Quint  <graouts@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt

    r291042 r291043  
    140140PASS color-interpolation: "auto" onto "linearrgb"
    141141PASS color-interpolation: "linearrgb" onto "auto"
     142PASS color-interpolation-filters (type: discrete) has testAccumulation function
     143PASS color-interpolation-filters: "linearrgb" onto "srgb"
     144PASS color-interpolation-filters: "srgb" onto "linearrgb"
    142145PASS column-count (type: positiveInteger) has testAccumulation function
    143146PASS column-count: positive integer

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt

    r291042 r291043  
    140140PASS color-interpolation: "auto" onto "linearrgb"
    141141PASS color-interpolation: "linearrgb" onto "auto"
     142PASS color-interpolation-filters (type: discrete) has testAddition function
     143PASS color-interpolation-filters: "linearrgb" onto "srgb"
     144PASS color-interpolation-filters: "srgb" onto "linearrgb"
    142145PASS column-count (type: positiveInteger) has testAddition function
    143146PASS column-count: positive integer

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt

    r291042 r291043  
    170170PASS color-interpolation uses discrete animation when animating between "linearrgb" and "auto" with effect easing
    171171PASS color-interpolation uses discrete animation when animating between "linearrgb" and "auto" with keyframe easing
     172PASS color-interpolation-filters (type: discrete) has testInterpolation function
     173PASS color-interpolation-filters uses discrete animation when animating between "srgb" and "linearrgb" with linear easing
     174PASS color-interpolation-filters uses discrete animation when animating between "srgb" and "linearrgb" with effect easing
     175PASS color-interpolation-filters uses discrete animation when animating between "srgb" and "linearrgb" with keyframe easing
    172176PASS column-count (type: positiveInteger) has testInterpolation function
    173177PASS column-count supports animating as a positive integer

  • trunk/Source/WebCore/ChangeLog

    r291042 r291043  
     12022-03-09  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] color-interpolation-filters should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237637
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * animation/CSSPropertyAnimation.cpp:
     9        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     10        * rendering/style/RenderStyle.h:
     11        (WebCore::RenderStyle::colorInterpolationFilters const):
     12        (WebCore::RenderStyle::setColorInterpolationFilters):
     13
    1142022-03-08  Antoine Quint  <graouts@webkit.org>
    215

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r291042 r291043  
    28432843        new DiscretePropertyWrapper<FontFeatureSettings>(CSSPropertyFontFeatureSettings, &RenderStyle::fontFeatureSettings, &RenderStyle::setFontFeatureSettings),
    28442844        new FontFamilyWrapper,
    2845         new DiscretePropertyWrapper<WindRule>(CSSPropertyClipRule, &RenderStyle::clipRule, &RenderStyle::setClipRule)
     2845        new DiscretePropertyWrapper<WindRule>(CSSPropertyClipRule, &RenderStyle::clipRule, &RenderStyle::setClipRule),
     2846        new DiscretePropertyWrapper<ColorInterpolation>(CSSPropertyColorInterpolationFilters, &RenderStyle::colorInterpolationFilters, &RenderStyle::setColorInterpolationFilters)
    28462847    };
    28472848    const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);

  • trunk/Source/WebCore/rendering/style/RenderStyle.h

    r291042 r291043  
    14351435    ColorInterpolation colorInterpolation() const { return svgStyle().colorInterpolation(); }
    14361436    void setColorInterpolation(ColorInterpolation colorInterpolation) { accessSVGStyle().setColorInterpolation(colorInterpolation); }
     1437    ColorInterpolation colorInterpolationFilters() const { return svgStyle().colorInterpolationFilters(); }
     1438    void setColorInterpolationFilters(ColorInterpolation colorInterpolationFilters) { accessSVGStyle().setColorInterpolationFilters(colorInterpolationFilters); }
    14371439
    14381440    SVGPaintType fillPaintType() const { return svgStyle().fillPaintType(); }
Note: See TracChangeset for help on using the changeset viewer.