Changeset 291068 in webkit


Ignore:
Timestamp:
Mar 9, 2022 2:10:35 PM (4 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] dominant-baseline should support discrete animation
​https://bugs.webkit.org/show_bug.cgi?id=237645

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::dominantBaseline const):
(WebCore::RenderStyle::setDominantBaseline):

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291054 r291068  
     12022-03-09  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] dominant-baseline should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237645
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
     9        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
     11
    1122022-03-09  Antoine Quint  <graouts@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt

    r291043 r291068  
    179179PASS cursor: "wait" onto "pointer"
    180180PASS cursor: "pointer" onto "wait"
     181PASS dominant-baseline (type: discrete) has testAccumulation function
     182PASS dominant-baseline: "alphabetic" onto "ideographic"
     183PASS dominant-baseline: "ideographic" onto "alphabetic"
    181184PASS empty-cells (type: discrete) has testAccumulation function
    182185PASS empty-cells: "hide" onto "show"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt

    r291043 r291068  
    179179PASS cursor: "wait" onto "pointer"
    180180PASS cursor: "pointer" onto "wait"
     181PASS dominant-baseline (type: discrete) has testAddition function
     182PASS dominant-baseline: "alphabetic" onto "ideographic"
     183PASS dominant-baseline: "ideographic" onto "alphabetic"
    181184PASS empty-cells (type: discrete) has testAddition function
    182185PASS empty-cells: "hide" onto "show"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt

    r291043 r291068  
    216216PASS cursor uses discrete animation when animating between "pointer" and "wait" with effect easing
    217217PASS cursor uses discrete animation when animating between "pointer" and "wait" with keyframe easing
     218PASS dominant-baseline (type: discrete) has testInterpolation function
     219PASS dominant-baseline uses discrete animation when animating between "ideographic" and "alphabetic" with linear easing
     220PASS dominant-baseline uses discrete animation when animating between "ideographic" and "alphabetic" with effect easing
     221PASS dominant-baseline uses discrete animation when animating between "ideographic" and "alphabetic" with keyframe easing
    218222PASS empty-cells (type: discrete) has testInterpolation function
    219223PASS empty-cells uses discrete animation when animating between "show" and "hide" with linear easing

  • trunk/Source/WebCore/ChangeLog

    r291054 r291068  
     12022-03-09  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] dominant-baseline should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237645
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * animation/CSSPropertyAnimation.cpp:
     9        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     10        * rendering/style/RenderStyle.h:
     11        (WebCore::RenderStyle::dominantBaseline const):
     12        (WebCore::RenderStyle::setDominantBaseline):
     13
    1142022-03-09  Antoine Quint  <graouts@webkit.org>
    215

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r291047 r291068  
    28442844        new FontFamilyWrapper,
    28452845        new DiscretePropertyWrapper<WindRule>(CSSPropertyClipRule, &RenderStyle::clipRule, &RenderStyle::setClipRule),
    2846         new DiscretePropertyWrapper<ColorInterpolation>(CSSPropertyColorInterpolationFilters, &RenderStyle::colorInterpolationFilters, &RenderStyle::setColorInterpolationFilters)
     2846        new DiscretePropertyWrapper<ColorInterpolation>(CSSPropertyColorInterpolationFilters, &RenderStyle::colorInterpolationFilters, &RenderStyle::setColorInterpolationFilters),
     2847        new DiscretePropertyWrapper<DominantBaseline>(CSSPropertyDominantBaseline, &RenderStyle::dominantBaseline, &RenderStyle::setDominantBaseline)
    28472848    };
    28482849    const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);

  • trunk/Source/WebCore/rendering/style/RenderStyle.h

    r291043 r291068  
    14371437    ColorInterpolation colorInterpolationFilters() const { return svgStyle().colorInterpolationFilters(); }
    14381438    void setColorInterpolationFilters(ColorInterpolation colorInterpolationFilters) { accessSVGStyle().setColorInterpolationFilters(colorInterpolationFilters); }
     1439
     1440    DominantBaseline dominantBaseline() const { return svgStyle().dominantBaseline(); }
     1441    void setDominantBaseline(DominantBaseline dominantBaseline) { return accessSVGStyle().setDominantBaseline(dominantBaseline); }
    14391442
    14401443    SVGPaintType fillPaintType() const { return svgStyle().fillPaintType(); }
Note: See TracChangeset for help on using the changeset viewer.