Changeset 291148 in webkit


Ignore:
Timestamp:
Mar 10, 2022 11:37:50 PM (4 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] mask-origin should support discrete animation
​https://bugs.webkit.org/show_bug.cgi?id=237733

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291147 r291148  
     12022-03-10  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] mask-origin should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237733
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
     9        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
     11
    1122022-03-10  Antoine Quint  <graouts@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

    r291130 r291148  
    4141PASS mask-image: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")"
    4242PASS mask-image: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")"
     43PASS mask-origin (type: discrete) has testAccumulation function
     44PASS mask-origin: "border-box" onto "content-box"
     45PASS mask-origin: "content-box" onto "border-box"
    4346PASS mix-blend-mode (type: discrete) has testAccumulation function
    4447PASS mix-blend-mode: "screen" onto "multiply"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

    r291130 r291148  
    4141PASS mask-image: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")"
    4242PASS mask-image: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")"
     43PASS mask-origin (type: discrete) has testAddition function
     44PASS mask-origin: "border-box" onto "content-box"
     45PASS mask-origin: "content-box" onto "border-box"
    4346PASS mix-blend-mode (type: discrete) has testAddition function
    4447PASS mix-blend-mode: "screen" onto "multiply"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r291130 r291148  
    5151FAIL mask-image uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with effect easing assert_equals: The value should be url("http://localhost/test-1") at 940ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-2\")"
    5252FAIL mask-image uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with keyframe easing assert_equals: The value should be url("http://localhost/test-1") at 940ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-2\")"
     53PASS mask-origin (type: discrete) has testInterpolation function
     54PASS mask-origin uses discrete animation when animating between "content-box" and "border-box" with linear easing
     55PASS mask-origin uses discrete animation when animating between "content-box" and "border-box" with effect easing
     56PASS mask-origin uses discrete animation when animating between "content-box" and "border-box" with keyframe easing
    5357PASS mix-blend-mode (type: discrete) has testInterpolation function
    5458PASS mix-blend-mode uses discrete animation when animating between "multiply" and "screen" with linear easing

  • trunk/Source/WebCore/ChangeLog

    r291147 r291148  
     12022-03-10  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] mask-origin should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237733
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * animation/CSSPropertyAnimation.cpp:
     9        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     10
    1112022-03-10  Antoine Quint  <graouts@webkit.org>
    212

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r291147 r291148  
    19701970            m_fillLayerPropertyWrapper = makeUnique<FillLayerFillBoxPropertyWrapper>(property, &FillLayer::clip, &FillLayer::setClip);
    19711971            break;
     1972        case CSSPropertyMaskOrigin:
     1973            m_fillLayerPropertyWrapper = makeUnique<FillLayerFillBoxPropertyWrapper>(property, &FillLayer::origin, &FillLayer::setOrigin);
     1974            break;
    19721975        default:
    19731976            break;
    … …  
    29382941
    29392942        new FillLayersPropertyWrapper(CSSPropertyMaskClip, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
     2943        new FillLayersPropertyWrapper(CSSPropertyMaskOrigin, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
    29402944        new FillLayersPropertyWrapper(CSSPropertyWebkitMaskPositionX, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
    29412945        new FillLayersPropertyWrapper(CSSPropertyWebkitMaskPositionY, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
Note: See TracChangeset for help on using the changeset viewer.