Changeset 291160 in webkit


Ignore:
Timestamp:
Mar 11, 2022 6:08:29 AM (4 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] mask-mode should support discrete animation
​https://bugs.webkit.org/show_bug.cgi?id=237770

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291159 r291160  
     12022-03-11  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] mask-mode should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237770
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
     9        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
     11
    1122022-03-11  Antoine Quint  <graouts@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

    r291159 r291160  
    4444PASS mask-image: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")"
    4545PASS mask-image: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")"
     46PASS mask-mode (type: discrete) has testAccumulation function
     47PASS mask-mode: "luminance" onto "alpha"
     48PASS mask-mode: "alpha" onto "luminance"
    4649PASS mask-origin (type: discrete) has testAccumulation function
    4750PASS mask-origin: "border-box" onto "content-box"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

    r291159 r291160  
    4444PASS mask-image: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")"
    4545PASS mask-image: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")"
     46PASS mask-mode (type: discrete) has testAddition function
     47PASS mask-mode: "luminance" onto "alpha"
     48PASS mask-mode: "alpha" onto "luminance"
    4649PASS mask-origin (type: discrete) has testAddition function
    4750PASS mask-origin: "border-box" onto "content-box"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r291159 r291160  
    5555FAIL mask-image uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with effect easing assert_equals: The value should be url("http://localhost/test-1") at 940ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-2\")"
    5656FAIL mask-image uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with keyframe easing assert_equals: The value should be url("http://localhost/test-1") at 940ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-2\")"
     57PASS mask-mode (type: discrete) has testInterpolation function
     58PASS mask-mode uses discrete animation when animating between "alpha" and "luminance" with linear easing
     59PASS mask-mode uses discrete animation when animating between "alpha" and "luminance" with effect easing
     60PASS mask-mode uses discrete animation when animating between "alpha" and "luminance" with keyframe easing
    5761PASS mask-origin (type: discrete) has testInterpolation function
    5862PASS mask-origin uses discrete animation when animating between "content-box" and "border-box" with linear easing

  • trunk/Source/WebCore/ChangeLog

    r291159 r291160  
     12022-03-11  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] mask-mode should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237770
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * animation/CSSPropertyAnimation.cpp:
     9        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     10
    1112022-03-11  Antoine Quint  <graouts@webkit.org>
    212

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r291159 r291160  
    19771977            m_fillLayerPropertyWrapper = makeUnique<DiscreteFillLayerPropertyWrapper<CompositeOperator>>(property, &FillLayer::composite, &FillLayer::setComposite);
    19781978            break;
     1979        case CSSPropertyMaskMode:
     1980            m_fillLayerPropertyWrapper = makeUnique<DiscreteFillLayerPropertyWrapper<MaskMode>>(property, &FillLayer::maskMode, &FillLayer::setMaskMode);
     1981            break;
    19791982        default:
    19801983            break;
    … …  
    30153018        new FillLayersPropertyWrapper(CSSPropertyMaskClip, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
    30163019        new FillLayersPropertyWrapper(CSSPropertyMaskComposite, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
     3020        new FillLayersPropertyWrapper(CSSPropertyMaskMode, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
    30173021        new FillLayersPropertyWrapper(CSSPropertyMaskOrigin, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
    30183022        new FillLayersPropertyWrapper(CSSPropertyWebkitMaskPositionX, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
Note: See TracChangeset for help on using the changeset viewer.