Changeset 291161 in webkit


Ignore:
Timestamp:
Mar 11, 2022 6:17:13 AM (4 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] mask-repeat should support discrete animation
​https://bugs.webkit.org/show_bug.cgi?id=237771

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setMaskRepeatX):
(WebCore::RenderStyle::setMaskRepeatY):

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291160 r291161  
     12022-03-11  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] mask-repeat should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237771
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
     9        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
     11
    1122022-03-11  Antoine Quint  <graouts@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

    r291160 r291161  
    5050PASS mask-origin: "border-box" onto "content-box"
    5151PASS mask-origin: "content-box" onto "border-box"
     52PASS mask-repeat (type: discrete) has testAccumulation function
     53PASS mask-repeat: "round" onto "space"
     54PASS mask-repeat: "space" onto "round"
    5255PASS mask-type (type: discrete) has testAccumulation function
    5356PASS mask-type: "luminance" onto "alpha"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

    r291160 r291161  
    5050PASS mask-origin: "border-box" onto "content-box"
    5151PASS mask-origin: "content-box" onto "border-box"
     52PASS mask-repeat (type: discrete) has testAddition function
     53PASS mask-repeat: "round" onto "space"
     54PASS mask-repeat: "space" onto "round"
    5255PASS mask-type (type: discrete) has testAddition function
    5356PASS mask-type: "luminance" onto "alpha"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r291160 r291161  
    6363PASS mask-origin uses discrete animation when animating between "content-box" and "border-box" with effect easing
    6464PASS mask-origin uses discrete animation when animating between "content-box" and "border-box" with keyframe easing
     65PASS mask-repeat (type: discrete) has testInterpolation function
     66PASS mask-repeat uses discrete animation when animating between "space" and "round" with linear easing
     67PASS mask-repeat uses discrete animation when animating between "space" and "round" with effect easing
     68PASS mask-repeat uses discrete animation when animating between "space" and "round" with keyframe easing
    6569PASS mask-type (type: discrete) has testInterpolation function
    6670PASS mask-type uses discrete animation when animating between "alpha" and "luminance" with linear easing

  • trunk/Source/WebCore/ChangeLog

    r291160 r291161  
     12022-03-11  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] mask-repeat should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237771
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * animation/CSSPropertyAnimation.cpp:
     9        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     10        * rendering/style/RenderStyle.h:
     11        (WebCore::RenderStyle::setMaskRepeatX):
     12        (WebCore::RenderStyle::setMaskRepeatY):
     13
    1142022-03-11  Antoine Quint  <graouts@webkit.org>
    215

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r291160 r291161  
    30233023        new FillLayersPropertyWrapper(CSSPropertyWebkitMaskPositionY, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
    30243024        new FillLayersPropertyWrapper(CSSPropertyMaskSize, &RenderStyle::maskLayers, &RenderStyle::ensureMaskLayers),
     3025
     3026        new DiscretePropertyWrapper<FillRepeat>(CSSPropertyMaskRepeatX, &RenderStyle::maskRepeatX, &RenderStyle::setMaskRepeatX),
     3027        new DiscretePropertyWrapper<FillRepeat>(CSSPropertyMaskRepeatY, &RenderStyle::maskRepeatY, &RenderStyle::setMaskRepeatY),
    30253028
    30263029        new LengthPointPropertyWrapper(CSSPropertyObjectPosition, &RenderStyle::objectPosition, &RenderStyle::setObjectPosition),
    … …  
    32723275        CSSPropertyMaskPosition,
    32733276        CSSPropertyWebkitMaskPosition,
     3277        CSSPropertyMaskRepeat,
    32743278        CSSPropertyBorderTop, CSSPropertyBorderRight, CSSPropertyBorderBottom, CSSPropertyBorderLeft,
    32753279        CSSPropertyBorderColor,

  • trunk/Source/WebCore/rendering/style/RenderStyle.h

    r291156 r291161  
    10571057    void setMaskXPosition(Length&& length) { SET_NESTED_VAR(m_rareNonInheritedData, mask, m_xPosition, WTFMove(length)); }
    10581058    void setMaskYPosition(Length&& length) { SET_NESTED_VAR(m_rareNonInheritedData, mask, m_yPosition, WTFMove(length)); }
     1059    void setMaskRepeatX(FillRepeat fillRepeat) { SET_NESTED_VAR(m_rareNonInheritedData, mask, m_repeatX, static_cast<unsigned>(fillRepeat)); SET_NESTED_VAR(m_rareNonInheritedData, mask, m_repeatXSet, true); }
     1060    void setMaskRepeatY(FillRepeat fillRepeat) { SET_NESTED_VAR(m_rareNonInheritedData, mask, m_repeatY, static_cast<unsigned>(fillRepeat)); SET_NESTED_VAR(m_rareNonInheritedData, mask, m_repeatYSet, true); }
     1061
    10591062    void setMaskSize(LengthSize size) { SET_NESTED_VAR(m_rareNonInheritedData, mask, m_sizeLength, WTFMove(size)); }
    10601063
Note: See TracChangeset for help on using the changeset viewer.