Changeset 291163 in webkit

Timestamp:

Mar 11, 2022 6:23:34 AM (4 months ago)

Author:

graouts@webkit.org

Message:

[web-animations] stroke-linecap should support discrete animation
​https://bugs.webkit.org/show_bug.cgi?id=237763

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

• web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
• web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

• animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/CSSPropertyAnimation.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2022-03-11  Antoine Quint  <graouts@webkit.org>
+
+        [web-animations] stroke-linecap should support discrete animation
+        https://bugs.webkit.org/show_bug.cgi?id=237763
+
+        Reviewed by Antti Koivisto.
+
+        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
+        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
+        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
+
 2022-03-11  Antoine Quint  <graouts@webkit.org>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

@@ -153 +153 @@
 PASS stroke-dasharray: "10px, 20px" onto "none"
 PASS stroke-dasharray: "none" onto "10px, 20px"
+PASS stroke-linecap (type: discrete) has testAccumulation function
+PASS stroke-linecap: "square" onto "round"
+PASS stroke-linecap: "round" onto "square"
 PASS stroke-miterlimit (type: positiveNumber) has testAccumulation function
 PASS stroke-miterlimit: positive number

trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

@@ -153 +153 @@
 PASS stroke-dasharray: "10px, 20px" onto "none"
 PASS stroke-dasharray: "none" onto "10px, 20px"
+PASS stroke-linecap (type: discrete) has testAddition function
+PASS stroke-linecap: "square" onto "round"
+PASS stroke-linecap: "round" onto "square"
 PASS stroke-miterlimit (type: positiveNumber) has testAddition function
 PASS stroke-miterlimit: positive number

trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

@@ -184 +184 @@
 PASS stroke-dasharray uses discrete animation when animating between "none" and "10px, 20px" with effect easing
 PASS stroke-dasharray uses discrete animation when animating between "none" and "10px, 20px" with keyframe easing
+PASS stroke-linecap (type: discrete) has testInterpolation function
+PASS stroke-linecap uses discrete animation when animating between "round" and "square" with linear easing
+PASS stroke-linecap uses discrete animation when animating between "round" and "square" with effect easing
+PASS stroke-linecap uses discrete animation when animating between "round" and "square" with keyframe easing
 PASS stroke-miterlimit (type: positiveNumber) has testInterpolation function
 PASS stroke-miterlimit supports animating as a positive number

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-03-11  Antoine Quint  <graouts@webkit.org>
+
+        [web-animations] stroke-linecap should support discrete animation
+        https://bugs.webkit.org/show_bug.cgi?id=237763
+
+        Reviewed by Antti Koivisto.
+
+        * animation/CSSPropertyAnimation.cpp:
+        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+
 2022-03-11  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

@@ -3262 +3262 @@
         new DiscretePropertyWrapper<bool>(CSSPropertyScrollBehavior, &RenderStyle::useSmoothScrolling, &RenderStyle::setUseSmoothScrolling),
         new DiscreteFontDescriptionTypedWrapper<TextRenderingMode>(CSSPropertyTextRendering, &FontCascadeDescription::textRenderingMode, &FontCascadeDescription::setTextRenderingMode),
-        new DiscreteSVGPropertyWrapper<MaskType>(CSSPropertyMaskType, &SVGRenderStyle::maskType, &SVGRenderStyle::setMaskType)
+        new DiscreteSVGPropertyWrapper<MaskType>(CSSPropertyMaskType, &SVGRenderStyle::maskType, &SVGRenderStyle::setMaskType),
+        new DiscretePropertyWrapper<LineCap>(CSSPropertyStrokeLinecap, &RenderStyle::capStyle, &RenderStyle::setCapStyle)
     };
     const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);