Changeset 291164 in webkit


Ignore:
Timestamp:
Mar 11, 2022 6:27:14 AM (4 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] stroke-linejoin should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237764

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291163 r291164  
     12022-03-11  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] stroke-linejoin should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237764
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
     9        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
     11
    1122022-03-11  Antoine Quint  <graouts@webkit.org>
    213
  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

    r291163 r291164  
    156156PASS stroke-linecap: "square" onto "round"
    157157PASS stroke-linecap: "round" onto "square"
     158PASS stroke-linejoin (type: discrete) has testAccumulation function
     159PASS stroke-linejoin: "miter" onto "round"
     160PASS stroke-linejoin: "round" onto "miter"
    158161PASS stroke-miterlimit (type: positiveNumber) has testAccumulation function
    159162PASS stroke-miterlimit: positive number
  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

    r291163 r291164  
    156156PASS stroke-linecap: "square" onto "round"
    157157PASS stroke-linecap: "round" onto "square"
     158PASS stroke-linejoin (type: discrete) has testAddition function
     159PASS stroke-linejoin: "miter" onto "round"
     160PASS stroke-linejoin: "round" onto "miter"
    158161PASS stroke-miterlimit (type: positiveNumber) has testAddition function
    159162PASS stroke-miterlimit: positive number
  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r291163 r291164  
    188188PASS stroke-linecap uses discrete animation when animating between "round" and "square" with effect easing
    189189PASS stroke-linecap uses discrete animation when animating between "round" and "square" with keyframe easing
     190PASS stroke-linejoin (type: discrete) has testInterpolation function
     191PASS stroke-linejoin uses discrete animation when animating between "round" and "miter" with linear easing
     192PASS stroke-linejoin uses discrete animation when animating between "round" and "miter" with effect easing
     193PASS stroke-linejoin uses discrete animation when animating between "round" and "miter" with keyframe easing
    190194PASS stroke-miterlimit (type: positiveNumber) has testInterpolation function
    191195PASS stroke-miterlimit supports animating as a positive number
  • trunk/Source/WebCore/ChangeLog

    r291163 r291164  
     12022-03-11  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] stroke-linejoin should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237764
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * animation/CSSPropertyAnimation.cpp:
     9        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     10
    1112022-03-11  Antoine Quint  <graouts@webkit.org>
    212
  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r291163 r291164  
    32633263        new DiscreteFontDescriptionTypedWrapper<TextRenderingMode>(CSSPropertyTextRendering, &FontCascadeDescription::textRenderingMode, &FontCascadeDescription::setTextRenderingMode),
    32643264        new DiscreteSVGPropertyWrapper<MaskType>(CSSPropertyMaskType, &SVGRenderStyle::maskType, &SVGRenderStyle::setMaskType),
    3265         new DiscretePropertyWrapper<LineCap>(CSSPropertyStrokeLinecap, &RenderStyle::capStyle, &RenderStyle::setCapStyle)
     3265        new DiscretePropertyWrapper<LineCap>(CSSPropertyStrokeLinecap, &RenderStyle::capStyle, &RenderStyle::setCapStyle),
     3266        new DiscretePropertyWrapper<LineJoin>(CSSPropertyStrokeLinejoin, &RenderStyle::joinStyle, &RenderStyle::setJoinStyle)
    32663267    };
    32673268    const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
Note: See TracChangeset for help on using the changeset viewer.