Changeset 291166 in webkit


Ignore:
Timestamp:
Mar 11, 2022 6:30:09 AM (4 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] text-anchor should support discrete animation
​https://bugs.webkit.org/show_bug.cgi?id=237765

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291164 r291166  
     12022-03-11  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] text-anchor should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237765
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
     9        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
     11
    1122022-03-11  Antoine Quint  <graouts@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

    r291164 r291166  
    170170PASS text-align: "end" onto "start"
    171171PASS text-align: "start" onto "end"
     172PASS text-anchor (type: discrete) has testAccumulation function
     173PASS text-anchor: "end" onto "middle"
     174PASS text-anchor: "middle" onto "end"
    172175PASS text-decoration-color (type: color) has testAccumulation function
    173176FAIL text-decoration-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 255) at 500ms expected "rgb(255, 128, 255)" but got "rgb(192, 128, 192)"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

    r291164 r291166  
    170170PASS text-align: "end" onto "start"
    171171PASS text-align: "start" onto "end"
     172PASS text-anchor (type: discrete) has testAddition function
     173PASS text-anchor: "end" onto "middle"
     174PASS text-anchor: "middle" onto "end"
    172175PASS text-decoration-color (type: color) has testAddition function
    173176FAIL text-decoration-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 255) at 500ms expected "rgb(255, 128, 255)" but got "rgb(192, 128, 192)"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r291164 r291166  
    204204PASS text-align uses discrete animation when animating between "start" and "end" with effect easing
    205205PASS text-align uses discrete animation when animating between "start" and "end" with keyframe easing
     206PASS text-anchor (type: discrete) has testInterpolation function
     207PASS text-anchor uses discrete animation when animating between "middle" and "end" with linear easing
     208PASS text-anchor uses discrete animation when animating between "middle" and "end" with effect easing
     209PASS text-anchor uses discrete animation when animating between "middle" and "end" with keyframe easing
    206210PASS text-decoration-color (type: color) has testInterpolation function
    207211PASS text-decoration-color supports animating as color of rgb()

  • trunk/Source/WebCore/ChangeLog

    r291164 r291166  
     12022-03-11  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] text-anchor should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237765
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * animation/CSSPropertyAnimation.cpp:
     9        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     10
    1112022-03-11  Antoine Quint  <graouts@webkit.org>
    212

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r291164 r291166  
    32643264        new DiscreteSVGPropertyWrapper<MaskType>(CSSPropertyMaskType, &SVGRenderStyle::maskType, &SVGRenderStyle::setMaskType),
    32653265        new DiscretePropertyWrapper<LineCap>(CSSPropertyStrokeLinecap, &RenderStyle::capStyle, &RenderStyle::setCapStyle),
    3266         new DiscretePropertyWrapper<LineJoin>(CSSPropertyStrokeLinejoin, &RenderStyle::joinStyle, &RenderStyle::setJoinStyle)
     3266        new DiscretePropertyWrapper<LineJoin>(CSSPropertyStrokeLinejoin, &RenderStyle::joinStyle, &RenderStyle::setJoinStyle),
     3267        new DiscreteSVGPropertyWrapper<TextAnchor>(CSSPropertyTextAnchor, &SVGRenderStyle::textAnchor, &SVGRenderStyle::setTextAnchor)
    32673268    };
    32683269    const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
Note: See TracChangeset for help on using the changeset viewer.