Changeset 291171 in webkit


Ignore:
Timestamp:
Mar 11, 2022 9:11:24 AM (4 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] shape-rendering should support discrete animation
​https://bugs.webkit.org/show_bug.cgi?id=237767

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291170 r291171  
     12022-03-11  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] shape-rendering should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237767
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
     9        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
     10        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
     11
    1122022-03-11  Antoine Quint  <graouts@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

    r291170 r291171  
    138138PASS shape-outside: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")"
    139139PASS shape-outside: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")"
     140PASS shape-rendering (type: discrete) has testAccumulation function
     141PASS shape-rendering: "crispEdges" onto "optimizeSpeed"
     142PASS shape-rendering: "optimizeSpeed" onto "crispEdges"
    140143PASS stop-color (type: color) has testAccumulation function
    141144FAIL stop-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 255) at 500ms expected "rgb(255, 128, 255)" but got "rgb(192, 128, 192)"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

    r291170 r291171  
    138138PASS shape-outside: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")"
    139139PASS shape-outside: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")"
     140PASS shape-rendering (type: discrete) has testAddition function
     141PASS shape-rendering: "crispEdges" onto "optimizeSpeed"
     142PASS shape-rendering: "optimizeSpeed" onto "crispEdges"
    140143PASS stop-color (type: color) has testAddition function
    141144FAIL stop-color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 255) at 500ms expected "rgb(255, 128, 255)" but got "rgb(192, 128, 192)"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r291170 r291171  
    166166PASS shape-outside uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with effect easing
    167167PASS shape-outside uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with keyframe easing
     168PASS shape-rendering (type: discrete) has testInterpolation function
     169PASS shape-rendering uses discrete animation when animating between "optimizeSpeed" and "crispEdges" with linear easing
     170PASS shape-rendering uses discrete animation when animating between "optimizeSpeed" and "crispEdges" with effect easing
     171PASS shape-rendering uses discrete animation when animating between "optimizeSpeed" and "crispEdges" with keyframe easing
    168172PASS stop-color (type: color) has testInterpolation function
    169173PASS stop-color supports animating as color of rgb()

  • trunk/Source/WebCore/ChangeLog

    r291170 r291171  
     12022-03-11  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] shape-rendering should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237767
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * animation/CSSPropertyAnimation.cpp:
     9        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     10
    1112022-03-11  Antoine Quint  <graouts@webkit.org>
    212

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r291170 r291171  
    32663266        new DiscretePropertyWrapper<LineJoin>(CSSPropertyStrokeLinejoin, &RenderStyle::joinStyle, &RenderStyle::setJoinStyle),
    32673267        new DiscreteSVGPropertyWrapper<TextAnchor>(CSSPropertyTextAnchor, &SVGRenderStyle::textAnchor, &SVGRenderStyle::setTextAnchor),
    3268         new DiscreteSVGPropertyWrapper<VectorEffect>(CSSPropertyVectorEffect, &SVGRenderStyle::vectorEffect, &SVGRenderStyle::setVectorEffect)
     3268        new DiscreteSVGPropertyWrapper<VectorEffect>(CSSPropertyVectorEffect, &SVGRenderStyle::vectorEffect, &SVGRenderStyle::setVectorEffect),
     3269        new DiscreteSVGPropertyWrapper<ShapeRendering>(CSSPropertyShapeRendering, &SVGRenderStyle::shapeRendering, &SVGRenderStyle::setShapeRendering)
    32693270    };
    32703271    const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
Note: See TracChangeset for help on using the changeset viewer.