Changeset 291226 in webkit


Ignore:
Timestamp:
Mar 14, 2022 6:49:51 AM (4 months ago)
Author:
graouts@webkit.org
Message:

[web-animations] marker-end should support discrete animation
​https://bugs.webkit.org/show_bug.cgi?id=237824

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Test failures are due to SVGURIReference::fragmentIdentifierFromIRIString() rejecting the values used in the
test which do not contain a "#". While this is not the greatest test values for this property, this is indeed
a bug that we reject the value during parsing instead of storing it.

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291171 r291226  
     12022-03-14  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] marker-end should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237824
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Test failures are due to SVGURIReference::fragmentIdentifierFromIRIString() rejecting the values used in the
     9        test which do not contain a "#". While this is not the greatest test values for this property, this is indeed
     10        a bug that we reject the value during parsing instead of storing it.
     11
     12        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
     13        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
     14        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
     15
    1162022-03-11  Antoine Quint  <graouts@webkit.org>
    217

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt

    r291171 r291226  
    3232PASS list-style-type: "square" onto "circle"
    3333PASS list-style-type: "circle" onto "square"
     34PASS marker-end (type: discrete) has testAccumulation function
     35FAIL marker-end: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")" assert_equals: The value should be url("http://localhost/test-2") at 0ms expected "url(\"http://localhost/test-2\")" but got "none"
     36FAIL marker-end: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")" assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "none"
    3437PASS mask (type: discrete) has testAccumulation function
    3538FAIL mask: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")" assert_equals: The value should be url("http://localhost/test-2") at 0ms expected "url(\"http://localhost/test-2\")" but got "url(\"http://localhost/test-2\") 0% 0% / auto repeat border-box border-box add match-source"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt

    r291171 r291226  
    3232PASS list-style-type: "square" onto "circle"
    3333PASS list-style-type: "circle" onto "square"
     34PASS marker-end (type: discrete) has testAddition function
     35FAIL marker-end: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")" assert_equals: The value should be url("http://localhost/test-2") at 0ms expected "url(\"http://localhost/test-2\")" but got "none"
     36FAIL marker-end: "url("http://localhost/test-1")" onto "url("http://localhost/test-2")" assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "none"
    3437PASS mask (type: discrete) has testAddition function
    3538FAIL mask: "url("http://localhost/test-2")" onto "url("http://localhost/test-1")" assert_equals: The value should be url("http://localhost/test-2") at 0ms expected "url(\"http://localhost/test-2\")" but got "url(\"http://localhost/test-2\") 0% 0% / auto repeat border-box border-box add match-source"

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

    r291171 r291226  
    3939PASS list-style-type uses discrete animation when animating between "circle" and "square" with effect easing
    4040PASS list-style-type uses discrete animation when animating between "circle" and "square" with keyframe easing
     41PASS marker-end (type: discrete) has testInterpolation function
     42FAIL marker-end uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with linear easing assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "none"
     43FAIL marker-end uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with effect easing assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "none"
     44FAIL marker-end uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with keyframe easing assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "none"
    4145PASS mask (type: discrete) has testInterpolation function
    4246FAIL mask uses discrete animation when animating between "url("http://localhost/test-1")" and "url("http://localhost/test-2")" with linear easing assert_equals: The value should be url("http://localhost/test-1") at 0ms expected "url(\"http://localhost/test-1\")" but got "url(\"http://localhost/test-1\") 0% 0% / auto repeat border-box border-box add match-source"

  • trunk/Source/WebCore/ChangeLog

    r291225 r291226  
     12022-03-14  Antoine Quint  <graouts@webkit.org>
     2
     3        [web-animations] marker-end should support discrete animation
     4        https://bugs.webkit.org/show_bug.cgi?id=237824
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * animation/CSSPropertyAnimation.cpp:
     9        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     10
    1112022-03-14  Enrique Ocaña González  <eocanha@igalia.com>
    212

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r291171 r291226  
    32673267        new DiscreteSVGPropertyWrapper<TextAnchor>(CSSPropertyTextAnchor, &SVGRenderStyle::textAnchor, &SVGRenderStyle::setTextAnchor),
    32683268        new DiscreteSVGPropertyWrapper<VectorEffect>(CSSPropertyVectorEffect, &SVGRenderStyle::vectorEffect, &SVGRenderStyle::setVectorEffect),
    3269         new DiscreteSVGPropertyWrapper<ShapeRendering>(CSSPropertyShapeRendering, &SVGRenderStyle::shapeRendering, &SVGRenderStyle::setShapeRendering)
     3269        new DiscreteSVGPropertyWrapper<ShapeRendering>(CSSPropertyShapeRendering, &SVGRenderStyle::shapeRendering, &SVGRenderStyle::setShapeRendering),
     3270        new DiscreteSVGPropertyWrapper<const String&>(CSSPropertyMarkerEnd, &SVGRenderStyle::markerEndResource, &SVGRenderStyle::setMarkerEndResource)
    32703271    };
    32713272    const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
Note: See TracChangeset for help on using the changeset viewer.