Changeset 291303 in webkit


Ignore:
Timestamp:
Mar 15, 2022 10:36:18 AM (4 months ago)
Author:
Antti Koivisto
Message:

background-clip:text doesn't work with display:flex
​https://bugs.webkit.org/show_bug.cgi?id=169125
<rdar://problem/72432683>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-expected.html: Added.
  • web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-ref.html: Added.
  • web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html: Added.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::paintAsInlineBlock):

Flexbox children paint as inline blocks. This path didn't support text clip paint phase.

Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291295 r291303  
     12022-03-15  Antti Koivisto  <antti@apple.com>
     2
     3        background-clip:text doesn't work with display:flex
     4        https://bugs.webkit.org/show_bug.cgi?id=169125
     5        <rdar://problem/72432683>
     6
     7        Reviewed by Simon Fraser.
     8
     9        * web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-expected.html: Added.
     10        * web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex-ref.html: Added.
     11        * web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html: Added.
     12
    1132022-03-15  Joseph Griego  <jgriego@igalia.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r291302 r291303  
     12022-03-15  Antti Koivisto  <antti@apple.com>
     2
     3        background-clip:text doesn't work with display:flex
     4        https://bugs.webkit.org/show_bug.cgi?id=169125
     5        <rdar://problem/72432683>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Tests: imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-flex.html
     10
     11        * rendering/RenderElement.cpp:
     12        (WebCore::RenderElement::paintAsInlineBlock):
     13
     14        Flexbox children paint as inline blocks. This path didn't support text clip paint phase.
     15
    1162022-03-15  Alex Christensen  <achristensen@webkit.org>
    217

  • trunk/Source/WebCore/rendering/RenderElement.cpp

    r290867 r291303  
    10841084    // This is also used by other elements (e.g. flex items and grid items).
    10851085    PaintPhase paintPhaseToUse = isExcludedAndPlacedInBorder() ? paintInfo.phase : PaintPhase::Foreground;
    1086     if (paintInfo.phase == PaintPhase::Selection || paintInfo.phase == PaintPhase::EventRegion)
     1086    if (paintInfo.phase == PaintPhase::Selection || paintInfo.phase == PaintPhase::EventRegion || paintInfo.phase == PaintPhase::TextClip)
    10871087        paint(paintInfo, childPoint);
    10881088    else if (paintInfo.phase == paintPhaseToUse) {
Note: See TracChangeset for help on using the changeset viewer.