Changeset 291321 in webkit

Timestamp:

Mar 15, 2022 4:23:54 PM (4 months ago)

Author:

J Pascoe

Message:

[WebAuthn] Mock UI interactions whenever virtual authenticators are in use.
​https://bugs.webkit.org/show_bug.cgi?id=237856
rdar://problem/90274854

Reviewed by Brent Fulgham.

Tested by wpt's webauthn tests.

• UIProcess/WebAuthentication/AuthenticatorManager.h:
• UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp:

(WebKit::VirtualAuthenticatorManager::runPanel):
(WebKit::VirtualAuthenticatorManager::selectAssertionResponse):
(WebKit::VirtualAuthenticatorManager::decidePolicyForLocalAuthenticator):

• UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebAuthentication/AuthenticatorManager.h (modified) (3 diffs)
• UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp (modified) (1 diff)
• UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-03-15  J Pascoe  <j_pascoe@apple.com>
+
+        [WebAuthn] Mock UI interactions whenever virtual authenticators are in use.
+        https://bugs.webkit.org/show_bug.cgi?id=237856
+        rdar://problem/90274854
+
+        Reviewed by Brent Fulgham.
+
+        Tested by wpt's webauthn tests.
+
+        * UIProcess/WebAuthentication/AuthenticatorManager.h:
+        * UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp:
+        (WebKit::VirtualAuthenticatorManager::runPanel):
+        (WebKit::VirtualAuthenticatorManager::selectAssertionResponse):
+        (WebKit::VirtualAuthenticatorManager::decidePolicyForLocalAuthenticator):
+        * UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h:
+
 2022-03-15  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h

@@ -81 +81 @@
     void invokePendingCompletionHandler(Respond&&);
 
+    void decidePolicyForLocalAuthenticator(CompletionHandler<void(LocalAuthenticatorPolicy)>&&);
+    TransportSet getTransports() const;
+    virtual void runPanel();
+    void selectAssertionResponse(Vector<Ref<WebCore::AuthenticatorAssertionResponse>>&&, WebAuthenticationSource, CompletionHandler<void(WebCore::AuthenticatorAssertionResponse*)>&&);
+    void startDiscovery(const TransportSet&);
+
 private:
     enum class Mode {
@@ -97 +103 @@
     void authenticatorStatusUpdated(WebAuthenticationStatus) final;
     void requestPin(uint64_t retries, CompletionHandler<void(const WTF::String&)>&&) final;
-    void selectAssertionResponse(Vector<Ref<WebCore::AuthenticatorAssertionResponse>>&&, WebAuthenticationSource, CompletionHandler<void(WebCore::AuthenticatorAssertionResponse*)>&&) final;
-    void decidePolicyForLocalAuthenticator(CompletionHandler<void(LocalAuthenticatorPolicy)>&&) final;
     void requestLAContextForUserVerification(CompletionHandler<void(LAContext *)>&&) final;
     void cancelRequest() final;
@@ -109 +113 @@
     virtual void runPresenterInternal(const TransportSet&);
 
-    void startDiscovery(const TransportSet&);
     void initTimeOutTimer();
     void timeOutTimerFired();
-    void runPanel();
     void runPresenter();
     void restartDiscovery();
-    TransportSet getTransports() const;
     void dispatchPanelClientCall(Function<void(const API::WebAuthenticationPanel&)>&&) const;
 

trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp

@@ -64 +64 @@
 }
 
+void VirtualAuthenticatorManager::runPanel()
+{
+    auto transports = getTransports();
+    if (transports.isEmpty()) {
+        cancel();
+        return;
+    }
+
+    startDiscovery(transports);
+}
+
+void VirtualAuthenticatorManager::selectAssertionResponse(Vector<Ref<WebCore::AuthenticatorAssertionResponse>>&& responses, WebAuthenticationSource source, CompletionHandler<void(WebCore::AuthenticatorAssertionResponse*)>&& completionHandler)
+{
+    completionHandler(responses[0].ptr());
+}
+
+void VirtualAuthenticatorManager::decidePolicyForLocalAuthenticator(CompletionHandler<void(LocalAuthenticatorPolicy)>&& completionHandler)
+{
+    completionHandler(LocalAuthenticatorPolicy::Allow);
+}
+
 } // namespace WebKit
 

trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h

@@ -41 +41 @@
 
     bool isVirtual() const final { return true; }
+    void runPanel();
+    void selectAssertionResponse(Vector<Ref<WebCore::AuthenticatorAssertionResponse>>&&, WebAuthenticationSource, CompletionHandler<void(WebCore::AuthenticatorAssertionResponse*)>&&);
+    void decidePolicyForLocalAuthenticator(CompletionHandler<void(LocalAuthenticatorPolicy)>&&);
 
 private: