Changeset 291524 in webkit


Ignore:
Timestamp:
Mar 19, 2022 2:12:33 AM (4 months ago)
Author:
Antti Koivisto
Message:

[CSS Container Queries] Add Typed OM support for container units
​https://bugs.webkit.org/show_bug.cgi?id=238078

Reviewed by Alan Bujtas.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-contain/container-queries/container-units-typed-om-expected.txt:

Source/WebCore:

For completeness, Typed OM is not enabled or fully implemented yet.

  • css/DOMCSSNamespace+CSSNumericFactory.idl:
  • css/typedom/CSSNumericFactory.h:
  • css/typedom/CSSStyleValueFactory.cpp:

(WebCore::CSSStyleValueFactory::reifyValue):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r291513 r291524  
     12022-03-19  Antti Koivisto  <antti@apple.com>
     2
     3        [CSS Container Queries] Add Typed OM support for container units
     4        https://bugs.webkit.org/show_bug.cgi?id=238078
     5
     6        Reviewed by Alan Bujtas.
     7
     8        * web-platform-tests/css/css-contain/container-queries/container-units-typed-om-expected.txt:
     9
    1102022-03-18  Commit Queue  <commit-queue@webkit.org>
    211

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-typed-om-expected.txt

    r291474 r291524  
    11
    2 FAIL CSS.cqw function func is not a function. (In 'func(10)', 'func' is undefined)
    3 FAIL Reify value with cqw unit assert_equals: expected (number) 10 but got (undefined) undefined
     2PASS CSS.cqw function
     3PASS Reify value with cqw unit
    44FAIL Set value with cqw unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
    5 FAIL Set value with cqw unit (CSS.cqw) func is not a function. (In 'func(10)', 'func' is undefined)
    6 FAIL CSS.cqh function func is not a function. (In 'func(10)', 'func' is undefined)
    7 FAIL Reify value with cqh unit assert_equals: expected (number) 10 but got (undefined) undefined
     5FAIL Set value with cqw unit (CSS.cqw) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
     6PASS CSS.cqh function
     7PASS Reify value with cqh unit
    88FAIL Set value with cqh unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
    9 FAIL Set value with cqh unit (CSS.cqh) func is not a function. (In 'func(10)', 'func' is undefined)
    10 FAIL CSS.cqi function func is not a function. (In 'func(10)', 'func' is undefined)
    11 FAIL Reify value with cqi unit assert_equals: expected (number) 10 but got (undefined) undefined
     9FAIL Set value with cqh unit (CSS.cqh) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
     10PASS CSS.cqi function
     11PASS Reify value with cqi unit
    1212FAIL Set value with cqi unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
    13 FAIL Set value with cqi unit (CSS.cqi) func is not a function. (In 'func(10)', 'func' is undefined)
    14 FAIL CSS.cqb function func is not a function. (In 'func(10)', 'func' is undefined)
    15 FAIL Reify value with cqb unit assert_equals: expected (number) 10 but got (undefined) undefined
     13FAIL Set value with cqi unit (CSS.cqi) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
     14PASS CSS.cqb function
     15PASS Reify value with cqb unit
    1616FAIL Set value with cqb unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
    17 FAIL Set value with cqb unit (CSS.cqb) func is not a function. (In 'func(10)', 'func' is undefined)
    18 FAIL CSS.cqmin function func is not a function. (In 'func(10)', 'func' is undefined)
    19 FAIL Reify value with cqmin unit assert_equals: expected (number) 10 but got (undefined) undefined
     17FAIL Set value with cqb unit (CSS.cqb) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
     18PASS CSS.cqmin function
     19PASS Reify value with cqmin unit
    2020FAIL Set value with cqmin unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
    21 FAIL Set value with cqmin unit (CSS.cqmin) func is not a function. (In 'func(10)', 'func' is undefined)
    22 FAIL CSS.cqmax function func is not a function. (In 'func(10)', 'func' is undefined)
    23 FAIL Reify value with cqmax unit assert_equals: expected (number) 10 but got (undefined) undefined
     21FAIL Set value with cqmin unit (CSS.cqmin) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
     22PASS CSS.cqmax function
     23PASS Reify value with cqmax unit
    2424FAIL Set value with cqmax unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
    25 FAIL Set value with cqmax unit (CSS.cqmax) func is not a function. (In 'func(10)', 'func' is undefined)
     25FAIL Set value with cqmax unit (CSS.cqmax) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
    2626

  • trunk/Source/WebCore/ChangeLog

    r291523 r291524  
     12022-03-19  Antti Koivisto  <antti@apple.com>
     2
     3        [CSS Container Queries] Add Typed OM support for container units
     4        https://bugs.webkit.org/show_bug.cgi?id=238078
     5
     6        Reviewed by Alan Bujtas.
     7
     8        For completeness, Typed OM is not enabled or fully implemented yet.
     9
     10        * css/DOMCSSNamespace+CSSNumericFactory.idl:
     11        * css/typedom/CSSNumericFactory.h:
     12        * css/typedom/CSSStyleValueFactory.cpp:
     13        (WebCore::CSSStyleValueFactory::reifyValue):
     14
    1152022-03-19  Alan Bujtas  <zalan@apple.com>
    216

  • trunk/Source/WebCore/css/DOMCSSNamespace+CSSNumericFactory.idl

    r283463 r291524  
    5555    CSSUnitValue pc(double value);
    5656    CSSUnitValue px(double value);
     57    CSSUnitValue cqw(double value);
     58    CSSUnitValue cqh(double value);
     59    CSSUnitValue cqi(double value);
     60    CSSUnitValue cqb(double value);
     61    CSSUnitValue cqmin(double value);
     62    CSSUnitValue cqmax(double value);
    5763
    5864    // <angle>

  • trunk/Source/WebCore/css/typedom/CSSNumericFactory.h

    r282039 r291524  
    6969    static Ref<CSSUnitValue> pc(double value) { return CSSUnitValue::create(value, "pc"); }
    7070    static Ref<CSSUnitValue> px(double value) { return CSSUnitValue::create(value, "px"); }
     71    static Ref<CSSUnitValue> cqw(double value) { return CSSUnitValue::create(value, "cqw"); }
     72    static Ref<CSSUnitValue> cqh(double value) { return CSSUnitValue::create(value, "cqh"); }
     73    static Ref<CSSUnitValue> cqi(double value) { return CSSUnitValue::create(value, "cqi"); }
     74    static Ref<CSSUnitValue> cqb(double value) { return CSSUnitValue::create(value, "cqb"); }
     75    static Ref<CSSUnitValue> cqmin(double value) { return CSSUnitValue::create(value, "cqmin"); }
     76    static Ref<CSSUnitValue> cqmax(double value) { return CSSUnitValue::create(value, "cqmax"); }
    7177
    7278

  • trunk/Source/WebCore/css/typedom/CSSStyleValueFactory.cpp

    r283069 r291524  
    220220        case CSSUnitType::CSS_FR:
    221221            return Ref<CSSStyleValue> { CSSNumericFactory::fr(primitiveValue->doubleValue()) };
     222        case CSSUnitType::CSS_CQW:
     223            return Ref<CSSStyleValue> { CSSNumericFactory::cqw(primitiveValue->doubleValue()) };
     224        case CSSUnitType::CSS_CQH:
     225            return Ref<CSSStyleValue> { CSSNumericFactory::cqh(primitiveValue->doubleValue()) };
     226        case CSSUnitType::CSS_CQI:
     227            return Ref<CSSStyleValue> { CSSNumericFactory::cqi(primitiveValue->doubleValue()) };
     228        case CSSUnitType::CSS_CQB:
     229            return Ref<CSSStyleValue> { CSSNumericFactory::cqb(primitiveValue->doubleValue()) };
     230        case CSSUnitType::CSS_CQMIN:
     231            return Ref<CSSStyleValue> { CSSNumericFactory::cqmin(primitiveValue->doubleValue()) };
     232        case CSSUnitType::CSS_CQMAX:
     233            return Ref<CSSStyleValue> { CSSNumericFactory::cqmax(primitiveValue->doubleValue()) };
    222234       
    223235        case CSSUnitType::CSS_STRING: {
Note: See TracChangeset for help on using the changeset viewer.