Changeset 291603 in webkit

Timestamp:

Mar 21, 2022 9:26:31 PM (4 months ago)

Author:

ysuzuki@apple.com

Message:

[JSC] Change Date.parse to stop returning numbers with fractional part
​https://bugs.webkit.org/show_bug.cgi?id=238050

Reviewed by Saam Barati.

JSTests:

• stress/date-parse-timeclip.js: Added.

(shouldBe):

Source/JavaScriptCore:

Date.parse should return NaN or integer numbers[1,2]. This patch applies timeClip
to the result of Date.parse to ensure that the returned value is time value.

[1]: ​https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-date.parse
[2]: ​https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-time-values-and-time-range

• runtime/DateConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/date-parse-timeclip.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/DateConstructor.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2022-03-21  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Change Date.parse to stop returning numbers with fractional part
+        https://bugs.webkit.org/show_bug.cgi?id=238050
+
+        Reviewed by Saam Barati.
+
+        * stress/date-parse-timeclip.js: Added.
+        (shouldBe):
+
 2022-03-21  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2022-03-21  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Change Date.parse to stop returning numbers with fractional part
+        https://bugs.webkit.org/show_bug.cgi?id=238050
+
+        Reviewed by Saam Barati.
+
+        Date.parse should return NaN or integer numbers[1,2]. This patch applies timeClip
+        to the result of Date.parse to ensure that the returned value is time value.
+
+        [1]: https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-date.parse
+        [2]: https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-time-values-and-time-range
+
+        * runtime/DateConstructor.cpp:
+        (JSC::JSC_DEFINE_HOST_FUNCTION):
+
 2022-03-21  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/runtime/DateConstructor.cpp

@@ -160 +160 @@
     String dateStr = callFrame->argument(0).toWTFString(globalObject);
     RETURN_IF_EXCEPTION(scope, encodedJSValue());
-    RELEASE_AND_RETURN(scope, JSValue::encode(jsNumber(vm.dateCache.parseDate(globalObject, vm, dateStr))));
+    RELEASE_AND_RETURN(scope, JSValue::encode(jsNumber(timeClip(vm.dateCache.parseDate(globalObject, vm, dateStr)))));
 }