Changeset 291761 in webkit

Timestamp:

Mar 23, 2022 12:24:00 PM (4 months ago)

Author:

J Pascoe

Message:

[WebAuthn] Specify correct ASCPublicKeyCredentialKind in configureAssertionOptions
​https://bugs.webkit.org/show_bug.cgi?id=238272
rdar://problem/90710080

Reviewed by Brent Fulgham.

There was a typo when refactoring code into this method. The kind passed to the function
should be used, instead of always ASCPublicKeyCredentialKindPlatform.

• UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

(WebKit::configureAssertionOptions):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-03-23  J Pascoe  <j_pascoe@apple.com>
+
+        [WebAuthn] Specify correct ASCPublicKeyCredentialKind in configureAssertionOptions
+        https://bugs.webkit.org/show_bug.cgi?id=238272
+        rdar://problem/90710080
+
+        Reviewed by Brent Fulgham.
+
+        There was a typo when refactoring code into this method. The kind passed to the function
+        should be used, instead of always ASCPublicKeyCredentialKindPlatform.
+
+        * UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
+        (WebKit::configureAssertionOptions):
+
 2022-03-23  Kimmo Kinnunen  <kkinnunen@apple.com>
 

trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

@@ -256 +256 @@
     if ([assertionOptions respondsToSelector:@selector(initWithKind:relyingPartyIdentifier:clientDataHash:userVerificationPreference:allowedCredentials:)]) {
         auto nsHash = toNSData(hash);
-        [assertionOptions initWithKind:ASCPublicKeyCredentialKindPlatform relyingPartyIdentifier:options.rpId clientDataHash:nsHash.get() userVerificationPreference:userVerification.get() allowedCredentials:allowedCredentials.get()];
+        [assertionOptions initWithKind:kind relyingPartyIdentifier:options.rpId clientDataHash:nsHash.get() userVerificationPreference:userVerification.get() allowedCredentials:allowedCredentials.get()];
     } else {
         auto challenge = WebCore::toNSData(options.challenge);
-        [assertionOptions initWithKind:ASCPublicKeyCredentialKindPlatform relyingPartyIdentifier:options.rpId challenge:challenge.get() userVerificationPreference:userVerification.get() allowedCredentials:allowedCredentials.get()];
+        [assertionOptions initWithKind:kind relyingPartyIdentifier:options.rpId challenge:challenge.get() userVerificationPreference:userVerification.get() allowedCredentials:allowedCredentials.get()];
     }
     if (options.extensions)