Changeset 292029 in webkit


Ignore:
Timestamp:
Mar 29, 2022 5:24:28 AM (4 months ago)
Author:
ntim@apple.com
Message:

Use Canvas/CanvasText system colors for <dialog> default styling
​https://bugs.webkit.org/show_bug.cgi?id=238425

Reviewed by Antti Koivisto.

Per HTML spec change: ​https://github.com/whatwg/html/commit/22154a4c1d426dddf187fb12c05fbcb8816c94a5
Main change is that the colors now adapt to dark mode by default.

LayoutTests/imported/w3c:

Updated test result to pass.

  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt:

Source/WebCore:

Test: LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color.html

  • css/dialog.css:

(dialog):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r292028 r292029  
     12022-03-29  Tim Nguyen  <ntim@apple.com>
     2
     3        Use Canvas/CanvasText system colors for <dialog> default styling
     4        https://bugs.webkit.org/show_bug.cgi?id=238425
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Per HTML spec change: https://github.com/whatwg/html/commit/22154a4c1d426dddf187fb12c05fbcb8816c94a5
     9        Main change is that the colors now adapt to dark mode by default.
     10
     11        Updated test result to pass.
     12
     13        * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt:
     14
    1152022-03-29  Tim Nguyen  <ntim@apple.com>
    216

  • trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt

    r292028 r292029  
    22
    33PASS <dialog> color and background match default
    4 FAIL <dialog> colors react to dark mode assert_not_equals: Dialog color should react to color-scheme got disallowed value "rgb(0, 0, 0)"
     4PASS <dialog> colors react to dark mode
    55

  • trunk/Source/WebCore/ChangeLog

    r292027 r292029  
     12022-03-29  Tim Nguyen  <ntim@apple.com>
     2
     3        Use Canvas/CanvasText system colors for <dialog> default styling
     4        https://bugs.webkit.org/show_bug.cgi?id=238425
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Per HTML spec change: https://github.com/whatwg/html/commit/22154a4c1d426dddf187fb12c05fbcb8816c94a5
     9        Main change is that the colors now adapt to dark mode by default.
     10
     11        Test: LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color.html
     12
     13        * css/dialog.css:
     14        (dialog):
     15
    1162022-03-29  Youenn Fablet  <youenn@apple.com>
    217

  • trunk/Source/WebCore/css/dialog.css

    r288233 r292029  
    88    border: solid;
    99    padding: 1em;
    10     background: white;
    11     color: black;
     10    background-color: Canvas;
     11    color: CanvasText;
    1212    display: none;
    1313}
Note: See TracChangeset for help on using the changeset viewer.