Changeset 292155 in webkit


Ignore:
Timestamp:
Mar 31, 2022 4:53:40 AM (4 months ago)
Author:
commit-queue@webkit.org
Message:

Interop issue with position: sticky within contain: paint
​https://bugs.webkit.org/show_bug.cgi?id=238016

Patch by Rob Buis <​rbuis@igalia.com> on 2022-03-31
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-position/sticky/position-sticky-overflow-clip-container-expected.html: Added.
  • web-platform-tests/css/css-position/sticky/position-sticky-overflow-clip-container-ref.html: Added.
  • web-platform-tests/css/css-position/sticky/position-sticky-overflow-clip-container.html: Added.

Source/WebCore:

Elements with overflow: clip (contain: paint enables it) are
not scroll containers, so they can't act as scrolling
ancestor for sticky elements.

Tests: imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-overflow-clip-container-ref.html

imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-overflow-clip-container.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::enclosingOverflowClipLayer const):

Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r292150 r292155  
     12022-03-31  Rob Buis  <rbuis@igalia.com>
     2
     3        Interop issue with position: sticky within contain: paint
     4        https://bugs.webkit.org/show_bug.cgi?id=238016
     5
     6        Reviewed by Simon Fraser.
     7
     8        * web-platform-tests/css/css-position/sticky/position-sticky-overflow-clip-container-expected.html: Added.
     9        * web-platform-tests/css/css-position/sticky/position-sticky-overflow-clip-container-ref.html: Added.
     10        * web-platform-tests/css/css-position/sticky/position-sticky-overflow-clip-container.html: Added.
     11
    1122022-03-31  Alex Christensen  <achristensen@webkit.org>
    213

  • trunk/Source/WebCore/ChangeLog

    r292154 r292155  
     12022-03-31  Rob Buis  <rbuis@igalia.com>
     2
     3        Interop issue with position: sticky within contain: paint
     4        https://bugs.webkit.org/show_bug.cgi?id=238016
     5
     6        Reviewed by Simon Fraser.
     7
     8        Elements with overflow: clip (contain: paint enables it) are
     9        not scroll containers, so they can't act as scrolling
     10        ancestor for sticky elements.
     11
     12        Tests: imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-overflow-clip-container-ref.html
     13               imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-overflow-clip-container.html
     14
     15        * rendering/RenderLayer.cpp:
     16        (WebCore::RenderLayer::enclosingOverflowClipLayer const):
     17
    1182022-03-31  Kimmo Kinnunen  <kkinnunen@apple.com>
    219

  • trunk/Source/WebCore/rendering/RenderLayer.cpp

    r291493 r292155  
    13971397    const RenderLayer* layer = (includeSelf == IncludeSelf) ? this : parent();
    13981398    while (layer) {
    1399         if (layer->renderer().hasNonVisibleOverflow())
     1399        if (layer->renderer().hasPotentiallyScrollableOverflow())
    14001400            return const_cast<RenderLayer*>(layer);
    14011401
Note: See TracChangeset for help on using the changeset viewer.