Changeset 293348 in webkit


Ignore:
Timestamp:
Apr 25, 2022 1:55:17 PM (3 months ago)
Author:
ysuzuki@apple.com
Message:

[JSC] Enable change-array-by-copy
​https://bugs.webkit.org/show_bug.cgi?id=239678

Reviewed by Saam Barati.

  • Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: ​https://commits.webkit.org/249964@main

Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r293345 r293348  
     12022-04-22  Yusuke Suzuki  <ysuzuki@apple.com>
     2
     3        [JSC] Enable change-array-by-copy
     4        https://bugs.webkit.org/show_bug.cgi?id=239678
     5
     6        Reviewed by Saam Barati.
     7
     8        * inspector/model/remote-object-get-properties-expected.txt:
     9        * js/Object-getOwnPropertyNames-expected.txt:
     10        * js/array-unscopables-properties-expected.txt:
     11        * js/script-tests/Object-getOwnPropertyNames.js:
     12        * js/script-tests/array-unscopables-properties.js:
     13
    1142022-04-25  Chris Fleizach  <cfleizach@apple.com>
    215

  • trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt

    r288901 r293348  
    8989    copyWithin
    9090    at
     91    toReversed
     92    toSorted
     93    toSpliced
     94    with
    9195    constructor
    9296    Symbol(Symbol.iterator)
    … …  
    145149    copyWithin
    146150    at
     151    toReversed
     152    toSorted
     153    toSpliced
     154    with
    147155    constructor
    148156    Symbol(Symbol.iterator)
    … …  
    186194    copyWithin
    187195    at
     196    toReversed
     197    toSorted
     198    toSpliced
     199    with
    188200    constructor
    189201    Symbol(Symbol.iterator)
    … …  
    227239    copyWithin
    228240    at
     241    toReversed
     242    toSorted
     243    toSpliced
     244    with
    229245    constructor
    230246    Symbol(Symbol.iterator)

  • trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt

    r288901 r293348  
    4848PASS getSortedOwnPropertyNames(Function.prototype) is ['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']
    4949PASS getSortedOwnPropertyNames(Array) is ['from', 'isArray', 'length', 'name', 'of', 'prototype']
    50 PASS getSortedOwnPropertyNames(Array.prototype) is ['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']
     50PASS getSortedOwnPropertyNames(Array.prototype) is ['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toReversed', 'toSorted', 'toSpliced', 'toString', 'unshift', 'values', 'with']
    5151PASS getSortedOwnPropertyNames(String) is ['fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']
    5252PASS getSortedOwnPropertyNames(String.prototype) is ['anchor', 'at', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'fontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'matchAll', 'normalize', 'padEnd', 'padStart', 'repeat', 'replace', 'replaceAll', 'search', 'slice', 'small', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimEnd', 'trimLeft', 'trimRight', 'trimStart', 'valueOf']

  • trunk/LayoutTests/js/array-unscopables-properties-expected.txt

    r288901 r293348  
    5959PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "keys").enumerable is true
    6060PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "keys").configurable is true
     61PASS Array.prototype[Symbol.unscopables]["toReversed"] is true
     62PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toReversed").writable is true
     63PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toReversed").enumerable is true
     64PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toReversed").configurable is true
     65PASS Array.prototype[Symbol.unscopables]["toSorted"] is true
     66PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSorted").writable is true
     67PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSorted").enumerable is true
     68PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSorted").configurable is true
     69PASS Array.prototype[Symbol.unscopables]["toSpliced"] is true
     70PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSpliced").writable is true
     71PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSpliced").enumerable is true
     72PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSpliced").configurable is true
    6173PASS Array.prototype[Symbol.unscopables]["values"] is true
    6274PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "values").writable is true

  • trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js

    r288901 r293348  
    5757    "Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']",
    5858    "Array": "['from', 'isArray', 'length', 'name', 'of', 'prototype']",
    59     "Array.prototype": "['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']",
     59    "Array.prototype": "['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toReversed', 'toSorted', 'toSpliced', 'toString', 'unshift', 'values', 'with']",
    6060    "String": "['fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']",
    6161    "String.prototype": "['anchor', 'at', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'fontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'matchAll', 'normalize', 'padEnd', 'padStart', 'repeat', 'replace', 'replaceAll', 'search', 'slice', 'small', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimEnd', 'trimLeft', 'trimRight', 'trimStart', 'valueOf']",

  • trunk/LayoutTests/js/script-tests/array-unscopables-properties.js

    r288901 r293348  
    2020    "includes",
    2121    "keys",
    22     "values"
     22    "toReversed",
     23    "toSorted",
     24    "toSpliced",
     25    "values",
    2326];
    2427shouldBe("Object.getOwnPropertyNames(Array.prototype[Symbol.unscopables])", "expectedEntries");

  • trunk/Source/JavaScriptCore/ChangeLog

    r293324 r293348  
     12022-04-22  Yusuke Suzuki  <ysuzuki@apple.com>
     2
     3        [JSC] Enable change-array-by-copy
     4        https://bugs.webkit.org/show_bug.cgi?id=239678
     5
     6        Reviewed by Saam Barati.
     7
     8        * runtime/OptionsList.h:
     9
    1102022-04-25  Claudio Saavedra  <csaavedra@igalia.com>
    211

  • trunk/Source/JavaScriptCore/runtime/OptionsList.h

    r292778 r293348  
    541541    v(Bool, useArrayGroupByMethod, false, Normal, "Expose the groupBy() and groupByToMap() methods on Array.") \
    542542    v(Bool, useAtMethod, true, Normal, "Expose the at() method on Array, %TypedArray%, and String.") \
    543     v(Bool, useChangeArrayByCopyMethods, false, Normal, "Expose the withAt(), withReversed(), withSorted() and withSpliced() methods on Array and %TypedArray%.") \
     543    v(Bool, useChangeArrayByCopyMethods, true, Normal, "Expose the withAt(), withReversed(), withSorted() and withSpliced() methods on Array and %TypedArray%.") \
    544544    v(Bool, useHasOwn, true, Normal, "Expose the Object.hasOwn method") \
    545545    v(Bool, useImportAssertion, false, Normal, "Enable import assertion.") \
Note: See TracChangeset for help on using the changeset viewer.