Changeset 293511 in webkit


Ignore:
Timestamp:
Apr 27, 2022 9:30:31 AM (3 months ago)
Author:
Ziran Sun
Message:

[css-ui] Remove some unimplemented -webkit-appearance keywords
​https://bugs.webkit.org/show_bug.cgi?id=238930

Reviewed by Aditya Keerthi.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

Source/WebCore:

Remove the following unimplmented --webkit-appearance keyworkds:
button-bevel
media-controls-background
media-controls-fullscreen-background
media-current-time-display
media-enter-fullscreen-button
media-exit-fullscreen-button
media-mute-button
media-overlay-play-button
media-return-to-realtime-button
media-rewind-button
media-seek-back-button
media-seek-forward-button
media-time-remaining-display
media-toggle-closed-captions-button
media-volume-slider-container
menulist-textfield
menulist-text

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • platform/ThemeTypes.cpp:

(WebCore::operator<<):

  • platform/ThemeTypes.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMediaPlayButton):
(WebCore::RenderTheme::paintMediaMuteButton):
(WebCore::RenderTheme::paintMediaSliderThumb):
(WebCore::RenderTheme::paintMediaVolumeSliderThumb):
(WebCore::RenderTheme::paintMediaFullscreenButton): Deleted.
(WebCore::RenderTheme::paintMediaOverlayPlayButton): Deleted.
(WebCore::RenderTheme::paintMediaSeekBackButton): Deleted.
(WebCore::RenderTheme::paintMediaSeekForwardButton): Deleted.
(WebCore::RenderTheme::paintMediaVolumeSliderContainer): Deleted.
(WebCore::RenderTheme::paintMediaRewindButton): Deleted.
(WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Deleted.
(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton): Deleted.
(WebCore::RenderTheme::paintMediaControlsBackground): Deleted.
(WebCore::RenderTheme::paintMediaCurrentTime): Deleted.
(WebCore::RenderTheme::paintMediaTimeRemaining): Deleted.

Source/WebInspectorUI:

We might need to update the changes on UserInterface/External/CodeMirror/css.js since
PR ​https://github.com/codemirror/CodeMirror/pull/6912 has been merged in CodeMirror.

  • UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
  • UserInterface/External/CSSDocumentation/CSSDocumentation.js:

LayoutTests:

  • imported/blink/editing/execCommand/outdent-collapse-table-crash.html:
  • platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
Location:
trunk
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r293502 r293511  
     12022-04-27  Ziran Sun  <zsun@igalia.com>
     2
     3        [css-ui] Remove some unimplemented -webkit-appearance keywords
     4        https://bugs.webkit.org/show_bug.cgi?id=238930
     5
     6        Reviewed by Aditya Keerthi.
     7
     8        * imported/blink/editing/execCommand/outdent-collapse-table-crash.html:
     9        * platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
     10        * platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
     11
    1122022-04-27  Youenn Fablet  <youenn@apple.com>
    213

  • trunk/LayoutTests/imported/blink/editing/execCommand/outdent-collapse-table-crash.html

    r190629 r293511  
    44<style>
    55* {
    6     -webkit-appearance: media-controls-background;
    76    display: table-footer-group;
    87    visibility: visible;

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r293506 r293511  
     12022-04-27  Ziran Sun  <zsun@igalia.com>
     2
     3        [css-ui] Remove some unimplemented -webkit-appearance keywords
     4        https://bugs.webkit.org/show_bug.cgi?id=238930
     5
     6        Reviewed by Aditya Keerthi.
     7
     8        * web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
     9
    1102022-04-27  Youenn Fablet  <youenn@apple.com>
    211

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt

    r284098 r293511  
    1919PASS -webkit-appearance: bogus-button (invalid)
    2020FAIL -webkit-appearance: attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "attachment"
    21 FAIL -webkit-appearance: button-bevel (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "button-bevel"
     21PASS -webkit-appearance: button-bevel (invalid)
    2222FAIL -webkit-appearance: borderless-attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "borderless-attachment"
    2323PASS -webkit-appearance: button-arrow-down (invalid)
    … …  
    4141FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
    4242FAIL -webkit-appearance: listitem (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "listitem"
    43 FAIL -webkit-appearance: media-controls-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-background"
     43PASS -webkit-appearance: media-controls-background (invalid)
    4444FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
    45 FAIL -webkit-appearance: media-controls-fullscreen-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-fullscreen-background"
     45PASS -webkit-appearance: media-controls-fullscreen-background (invalid)
    4646FAIL -webkit-appearance: media-controls-light-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-light-bar-background"
    47 FAIL -webkit-appearance: media-current-time-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-current-time-display"
    48 FAIL -webkit-appearance: media-enter-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-enter-fullscreen-button"
    49 FAIL -webkit-appearance: media-exit-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-exit-fullscreen-button"
     47PASS -webkit-appearance: media-current-time-display (invalid)
     48PASS -webkit-appearance: media-enter-fullscreen-button (invalid)
     49PASS -webkit-appearance: media-exit-fullscreen-button (invalid)
    5050FAIL -webkit-appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider"
    5151FAIL -webkit-appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider-thumb"
    52 FAIL -webkit-appearance: media-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-mute-button"
    53 FAIL -webkit-appearance: media-overlay-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-overlay-play-button"
     52PASS -webkit-appearance: media-mute-button (invalid)
     53PASS -webkit-appearance: media-overlay-play-button (invalid)
    5454FAIL -webkit-appearance: media-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-play-button"
    55 FAIL -webkit-appearance: media-return-to-realtime-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-return-to-realtime-button"
    56 FAIL -webkit-appearance: media-rewind-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-rewind-button"
    57 FAIL -webkit-appearance: media-seek-back-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-back-button"
    58 FAIL -webkit-appearance: media-seek-forward-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-forward-button"
     55PASS -webkit-appearance: media-return-to-realtime-button (invalid)
     56PASS -webkit-appearance: media-rewind-button (invalid)
     57PASS -webkit-appearance: media-seek-back-button (invalid)
     58PASS -webkit-appearance: media-seek-forward-button (invalid)
    5959FAIL -webkit-appearance: media-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-slider"
    6060FAIL -webkit-appearance: media-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-sliderthumb"
    61 FAIL -webkit-appearance: media-time-remaining-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-time-remaining-display"
    62 FAIL -webkit-appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-toggle-closed-captions-button"
     61PASS -webkit-appearance: media-time-remaining-display (invalid)
     62PASS -webkit-appearance: media-toggle-closed-captions-button (invalid)
    6363FAIL -webkit-appearance: media-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider"
    64 FAIL -webkit-appearance: media-volume-slider-container (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-container"
     64PASS -webkit-appearance: media-volume-slider-container (invalid)
    6565FAIL -webkit-appearance: media-volume-slider-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-mute-button"
    6666FAIL -webkit-appearance: media-volume-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-sliderthumb"
    … …  
    7171PASS -webkit-appearance: menuitem (invalid)
    7272PASS -webkit-appearance: menuitemtext (invalid)
    73 FAIL -webkit-appearance: menulist-text (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-text"
    74 FAIL -webkit-appearance: menulist-textfield (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-textfield"
     73PASS -webkit-appearance: menulist-text (invalid)
     74PASS -webkit-appearance: menulist-textfield (invalid)
    7575PASS -webkit-appearance: menupopup (invalid)
    7676PASS -webkit-appearance: menuradio (invalid)
    … …  
    182182PASS appearance: bogus-button (invalid)
    183183FAIL appearance: attachment (invalid) assert_equals: style.appearance expected "" but got "attachment"
    184 FAIL appearance: button-bevel (invalid) assert_equals: style.appearance expected "" but got "button-bevel"
     184PASS appearance: button-bevel (invalid)
    185185FAIL appearance: borderless-attachment (invalid) assert_equals: style.appearance expected "" but got "borderless-attachment"
    186186PASS appearance: button-arrow-down (invalid)
    … …  
    204204FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
    205205FAIL appearance: listitem (invalid) assert_equals: style.appearance expected "" but got "listitem"
    206 FAIL appearance: media-controls-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-background"
     206PASS appearance: media-controls-background (invalid)
    207207FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
    208 FAIL appearance: media-controls-fullscreen-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-fullscreen-background"
     208PASS appearance: media-controls-fullscreen-background (invalid)
    209209FAIL appearance: media-controls-light-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-light-bar-background"
    210 FAIL appearance: media-current-time-display (invalid) assert_equals: style.appearance expected "" but got "media-current-time-display"
    211 FAIL appearance: media-enter-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-enter-fullscreen-button"
    212 FAIL appearance: media-exit-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-exit-fullscreen-button"
     210PASS appearance: media-current-time-display (invalid)
     211PASS appearance: media-enter-fullscreen-button (invalid)
     212PASS appearance: media-exit-fullscreen-button (invalid)
    213213FAIL appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider"
    214214FAIL appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider-thumb"
    215 FAIL appearance: media-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-mute-button"
    216 FAIL appearance: media-overlay-play-button (invalid) assert_equals: style.appearance expected "" but got "media-overlay-play-button"
     215PASS appearance: media-mute-button (invalid)
     216PASS appearance: media-overlay-play-button (invalid)
    217217FAIL appearance: media-play-button (invalid) assert_equals: style.appearance expected "" but got "media-play-button"
    218 FAIL appearance: media-return-to-realtime-button (invalid) assert_equals: style.appearance expected "" but got "media-return-to-realtime-button"
    219 FAIL appearance: media-rewind-button (invalid) assert_equals: style.appearance expected "" but got "media-rewind-button"
    220 FAIL appearance: media-seek-back-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-back-button"
    221 FAIL appearance: media-seek-forward-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-forward-button"
     218PASS appearance: media-return-to-realtime-button (invalid)
     219PASS appearance: media-rewind-button (invalid)
     220PASS appearance: media-seek-back-button (invalid)
     221PASS appearance: media-seek-forward-button (invalid)
    222222FAIL appearance: media-slider (invalid) assert_equals: style.appearance expected "" but got "media-slider"
    223223FAIL appearance: media-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-sliderthumb"
    224 FAIL appearance: media-time-remaining-display (invalid) assert_equals: style.appearance expected "" but got "media-time-remaining-display"
    225 FAIL appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.appearance expected "" but got "media-toggle-closed-captions-button"
     224PASS appearance: media-time-remaining-display (invalid)
     225PASS appearance: media-toggle-closed-captions-button (invalid)
    226226FAIL appearance: media-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider"
    227 FAIL appearance: media-volume-slider-container (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-container"
     227PASS appearance: media-volume-slider-container (invalid)
    228228FAIL appearance: media-volume-slider-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-mute-button"
    229229FAIL appearance: media-volume-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-volume-sliderthumb"
    … …  
    234234PASS appearance: menuitem (invalid)
    235235PASS appearance: menuitemtext (invalid)
    236 FAIL appearance: menulist-text (invalid) assert_equals: style.appearance expected "" but got "menulist-text"
    237 FAIL appearance: menulist-textfield (invalid) assert_equals: style.appearance expected "" but got "menulist-textfield"
     236PASS appearance: menulist-text (invalid)
     237PASS appearance: menulist-textfield (invalid)
    238238PASS appearance: menupopup (invalid)
    239239PASS appearance: menuradio (invalid)

  • trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt

    r284839 r293511  
    1919PASS -webkit-appearance: bogus-button (invalid)
    2020PASS -webkit-appearance: attachment (invalid)
    21 FAIL -webkit-appearance: button-bevel (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "button-bevel"
     21PASS -webkit-appearance: button-bevel (invalid)
    2222PASS -webkit-appearance: borderless-attachment (invalid)
    2323PASS -webkit-appearance: button-arrow-down (invalid)
    … …  
    4141FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
    4242FAIL -webkit-appearance: listitem (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "listitem"
    43 FAIL -webkit-appearance: media-controls-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-background"
     43PASS -webkit-appearance: media-controls-background (invalid)
    4444FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
    45 FAIL -webkit-appearance: media-controls-fullscreen-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-fullscreen-background"
     45PASS -webkit-appearance: media-controls-fullscreen-background (invalid)
    4646FAIL -webkit-appearance: media-controls-light-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-light-bar-background"
    47 FAIL -webkit-appearance: media-current-time-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-current-time-display"
    48 FAIL -webkit-appearance: media-enter-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-enter-fullscreen-button"
    49 FAIL -webkit-appearance: media-exit-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-exit-fullscreen-button"
     47PASS -webkit-appearance: media-current-time-display (invalid)
     48PASS -webkit-appearance: media-enter-fullscreen-button (invalid)
     49PASS -webkit-appearance: media-exit-fullscreen-button (invalid)
    5050FAIL -webkit-appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider"
    5151FAIL -webkit-appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider-thumb"
    52 FAIL -webkit-appearance: media-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-mute-button"
    53 FAIL -webkit-appearance: media-overlay-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-overlay-play-button"
     52PASS -webkit-appearance: media-mute-button (invalid)
     53PASS -webkit-appearance: media-overlay-play-button (invalid)
    5454FAIL -webkit-appearance: media-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-play-button"
    55 FAIL -webkit-appearance: media-return-to-realtime-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-return-to-realtime-button"
    56 FAIL -webkit-appearance: media-rewind-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-rewind-button"
    57 FAIL -webkit-appearance: media-seek-back-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-back-button"
    58 FAIL -webkit-appearance: media-seek-forward-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-forward-button"
     55PASS -webkit-appearance: media-return-to-realtime-button (invalid)
     56PASS -webkit-appearance: media-rewind-button (invalid)
     57PASS -webkit-appearance: media-seek-back-button (invalid)
     58PASS -webkit-appearance: media-seek-forward-button (invalid)
    5959FAIL -webkit-appearance: media-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-slider"
    6060FAIL -webkit-appearance: media-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-sliderthumb"
    61 FAIL -webkit-appearance: media-time-remaining-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-time-remaining-display"
    62 FAIL -webkit-appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-toggle-closed-captions-button"
     61PASS -webkit-appearance: media-time-remaining-display (invalid)
     62PASS -webkit-appearance: media-toggle-closed-captions-button (invalid)
    6363FAIL -webkit-appearance: media-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider"
    64 FAIL -webkit-appearance: media-volume-slider-container (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-container"
     64PASS -webkit-appearance: media-volume-slider-container (invalid)
    6565FAIL -webkit-appearance: media-volume-slider-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-mute-button"
    6666FAIL -webkit-appearance: media-volume-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-sliderthumb"
    … …  
    7171PASS -webkit-appearance: menuitem (invalid)
    7272PASS -webkit-appearance: menuitemtext (invalid)
    73 FAIL -webkit-appearance: menulist-text (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-text"
    74 FAIL -webkit-appearance: menulist-textfield (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-textfield"
     73PASS -webkit-appearance: menulist-text (invalid)
     74PASS -webkit-appearance: menulist-textfield (invalid)
    7575PASS -webkit-appearance: menupopup (invalid)
    7676PASS -webkit-appearance: menuradio (invalid)
    … …  
    182182PASS appearance: bogus-button (invalid)
    183183PASS appearance: attachment (invalid)
    184 FAIL appearance: button-bevel (invalid) assert_equals: style.appearance expected "" but got "button-bevel"
     184PASS appearance: button-bevel (invalid)
    185185PASS appearance: borderless-attachment (invalid)
    186186PASS appearance: button-arrow-down (invalid)
    … …  
    204204FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
    205205FAIL appearance: listitem (invalid) assert_equals: style.appearance expected "" but got "listitem"
    206 FAIL appearance: media-controls-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-background"
     206PASS appearance: media-controls-background (invalid)
    207207FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
    208 FAIL appearance: media-controls-fullscreen-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-fullscreen-background"
     208PASS appearance: media-controls-fullscreen-background (invalid)
    209209FAIL appearance: media-controls-light-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-light-bar-background"
    210 FAIL appearance: media-current-time-display (invalid) assert_equals: style.appearance expected "" but got "media-current-time-display"
    211 FAIL appearance: media-enter-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-enter-fullscreen-button"
    212 FAIL appearance: media-exit-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-exit-fullscreen-button"
     210PASS appearance: media-current-time-display (invalid)
     211PASS appearance: media-enter-fullscreen-button (invalid)
     212PASS appearance: media-exit-fullscreen-button (invalid)
    213213FAIL appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider"
    214214FAIL appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider-thumb"
    215 FAIL appearance: media-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-mute-button"
    216 FAIL appearance: media-overlay-play-button (invalid) assert_equals: style.appearance expected "" but got "media-overlay-play-button"
     215PASS appearance: media-mute-button (invalid)
     216PASS appearance: media-overlay-play-button (invalid)
    217217FAIL appearance: media-play-button (invalid) assert_equals: style.appearance expected "" but got "media-play-button"
    218 FAIL appearance: media-return-to-realtime-button (invalid) assert_equals: style.appearance expected "" but got "media-return-to-realtime-button"
    219 FAIL appearance: media-rewind-button (invalid) assert_equals: style.appearance expected "" but got "media-rewind-button"
    220 FAIL appearance: media-seek-back-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-back-button"
    221 FAIL appearance: media-seek-forward-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-forward-button"
     218PASS appearance: media-return-to-realtime-button (invalid)
     219PASS appearance: media-rewind-button (invalid)
     220PASS appearance: media-seek-back-button (invalid)
     221PASS appearance: media-seek-forward-button (invalid)
    222222FAIL appearance: media-slider (invalid) assert_equals: style.appearance expected "" but got "media-slider"
    223223FAIL appearance: media-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-sliderthumb"
    224 FAIL appearance: media-time-remaining-display (invalid) assert_equals: style.appearance expected "" but got "media-time-remaining-display"
    225 FAIL appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.appearance expected "" but got "media-toggle-closed-captions-button"
     224PASS appearance: media-time-remaining-display (invalid)
     225PASS appearance: media-toggle-closed-captions-button (invalid)
    226226FAIL appearance: media-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider"
    227 FAIL appearance: media-volume-slider-container (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-container"
     227PASS appearance: media-volume-slider-container (invalid)
    228228FAIL appearance: media-volume-slider-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-mute-button"
    229229FAIL appearance: media-volume-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-volume-sliderthumb"
    … …  
    234234PASS appearance: menuitem (invalid)
    235235PASS appearance: menuitemtext (invalid)
    236 FAIL appearance: menulist-text (invalid) assert_equals: style.appearance expected "" but got "menulist-text"
    237 FAIL appearance: menulist-textfield (invalid) assert_equals: style.appearance expected "" but got "menulist-textfield"
     236PASS appearance: menulist-text (invalid)
     237PASS appearance: menulist-textfield (invalid)
    238238PASS appearance: menupopup (invalid)
    239239PASS appearance: menuradio (invalid)

  • trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt

    r284098 r293511  
    1919PASS -webkit-appearance: bogus-button (invalid)
    2020FAIL -webkit-appearance: attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "attachment"
    21 FAIL -webkit-appearance: button-bevel (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "button-bevel"
     21PASS -webkit-appearance: button-bevel (invalid)
    2222FAIL -webkit-appearance: borderless-attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "borderless-attachment"
    2323PASS -webkit-appearance: button-arrow-down (invalid)
    … …  
    4141FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
    4242FAIL -webkit-appearance: listitem (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "listitem"
    43 FAIL -webkit-appearance: media-controls-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-background"
     43PASS -webkit-appearance: media-controls-background (invalid)
    4444FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
    45 FAIL -webkit-appearance: media-controls-fullscreen-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-fullscreen-background"
     45PASS -webkit-appearance: media-controls-fullscreen-background (invalid)
    4646FAIL -webkit-appearance: media-controls-light-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-light-bar-background"
    47 FAIL -webkit-appearance: media-current-time-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-current-time-display"
    48 FAIL -webkit-appearance: media-enter-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-enter-fullscreen-button"
    49 FAIL -webkit-appearance: media-exit-fullscreen-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-exit-fullscreen-button"
     47PASS -webkit-appearance: media-current-time-display (invalid)
     48PASS -webkit-appearance: media-enter-fullscreen-button (invalid)
     49PASS -webkit-appearance: media-exit-fullscreen-button (invalid)
    5050FAIL -webkit-appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider"
    5151FAIL -webkit-appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider-thumb"
    52 FAIL -webkit-appearance: media-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-mute-button"
    53 FAIL -webkit-appearance: media-overlay-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-overlay-play-button"
     52PASS -webkit-appearance: media-mute-button (invalid)
     53PASS -webkit-appearance: media-overlay-play-button (invalid)
    5454FAIL -webkit-appearance: media-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-play-button"
    55 FAIL -webkit-appearance: media-return-to-realtime-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-return-to-realtime-button"
    56 FAIL -webkit-appearance: media-rewind-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-rewind-button"
    57 FAIL -webkit-appearance: media-seek-back-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-back-button"
    58 FAIL -webkit-appearance: media-seek-forward-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-seek-forward-button"
     55PASS -webkit-appearance: media-return-to-realtime-button (invalid)
     56PASS -webkit-appearance: media-rewind-button (invalid)
     57PASS -webkit-appearance: media-seek-back-button (invalid)
     58PASS -webkit-appearance: media-seek-forward-button (invalid)
    5959FAIL -webkit-appearance: media-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-slider"
    6060FAIL -webkit-appearance: media-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-sliderthumb"
    61 FAIL -webkit-appearance: media-time-remaining-display (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-time-remaining-display"
    62 FAIL -webkit-appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-toggle-closed-captions-button"
     61PASS -webkit-appearance: media-time-remaining-display (invalid)
     62PASS -webkit-appearance: media-toggle-closed-captions-button (invalid)
    6363FAIL -webkit-appearance: media-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider"
    64 FAIL -webkit-appearance: media-volume-slider-container (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-container"
     64PASS -webkit-appearance: media-volume-slider-container (invalid)
    6565FAIL -webkit-appearance: media-volume-slider-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-mute-button"
    6666FAIL -webkit-appearance: media-volume-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-sliderthumb"
    … …  
    7171PASS -webkit-appearance: menuitem (invalid)
    7272PASS -webkit-appearance: menuitemtext (invalid)
    73 FAIL -webkit-appearance: menulist-text (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-text"
    74 FAIL -webkit-appearance: menulist-textfield (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "menulist-textfield"
     73PASS -webkit-appearance: menulist-text (invalid)
     74PASS -webkit-appearance: menulist-textfield (invalid)
    7575PASS -webkit-appearance: menupopup (invalid)
    7676PASS -webkit-appearance: menuradio (invalid)
    … …  
    182182PASS appearance: bogus-button (invalid)
    183183FAIL appearance: attachment (invalid) assert_equals: style.appearance expected "" but got "attachment"
    184 FAIL appearance: button-bevel (invalid) assert_equals: style.appearance expected "" but got "button-bevel"
     184PASS appearance: button-bevel (invalid)
    185185FAIL appearance: borderless-attachment (invalid) assert_equals: style.appearance expected "" but got "borderless-attachment"
    186186PASS appearance: button-arrow-down (invalid)
    … …  
    204204FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
    205205FAIL appearance: listitem (invalid) assert_equals: style.appearance expected "" but got "listitem"
    206 FAIL appearance: media-controls-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-background"
     206PASS appearance: media-controls-background (invalid)
    207207FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
    208 FAIL appearance: media-controls-fullscreen-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-fullscreen-background"
     208PASS appearance: media-controls-fullscreen-background (invalid)
    209209FAIL appearance: media-controls-light-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-light-bar-background"
    210 FAIL appearance: media-current-time-display (invalid) assert_equals: style.appearance expected "" but got "media-current-time-display"
    211 FAIL appearance: media-enter-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-enter-fullscreen-button"
    212 FAIL appearance: media-exit-fullscreen-button (invalid) assert_equals: style.appearance expected "" but got "media-exit-fullscreen-button"
     210PASS appearance: media-current-time-display (invalid)
     211PASS appearance: media-enter-fullscreen-button (invalid)
     212PASS appearance: media-exit-fullscreen-button (invalid)
    213213FAIL appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider"
    214214FAIL appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider-thumb"
    215 FAIL appearance: media-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-mute-button"
    216 FAIL appearance: media-overlay-play-button (invalid) assert_equals: style.appearance expected "" but got "media-overlay-play-button"
     215PASS appearance: media-mute-button (invalid)
     216PASS appearance: media-overlay-play-button (invalid)
    217217FAIL appearance: media-play-button (invalid) assert_equals: style.appearance expected "" but got "media-play-button"
    218 FAIL appearance: media-return-to-realtime-button (invalid) assert_equals: style.appearance expected "" but got "media-return-to-realtime-button"
    219 FAIL appearance: media-rewind-button (invalid) assert_equals: style.appearance expected "" but got "media-rewind-button"
    220 FAIL appearance: media-seek-back-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-back-button"
    221 FAIL appearance: media-seek-forward-button (invalid) assert_equals: style.appearance expected "" but got "media-seek-forward-button"
     218PASS appearance: media-return-to-realtime-button (invalid)
     219PASS appearance: media-rewind-button (invalid)
     220PASS appearance: media-seek-back-button (invalid)
     221PASS appearance: media-seek-forward-button (invalid)
    222222FAIL appearance: media-slider (invalid) assert_equals: style.appearance expected "" but got "media-slider"
    223223FAIL appearance: media-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-sliderthumb"
    224 FAIL appearance: media-time-remaining-display (invalid) assert_equals: style.appearance expected "" but got "media-time-remaining-display"
    225 FAIL appearance: media-toggle-closed-captions-button (invalid) assert_equals: style.appearance expected "" but got "media-toggle-closed-captions-button"
     224PASS appearance: media-time-remaining-display (invalid)
     225PASS appearance: media-toggle-closed-captions-button (invalid)
    226226FAIL appearance: media-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider"
    227 FAIL appearance: media-volume-slider-container (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-container"
     227PASS appearance: media-volume-slider-container (invalid)
    228228FAIL appearance: media-volume-slider-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-mute-button"
    229229FAIL appearance: media-volume-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-volume-sliderthumb"
    … …  
    234234PASS appearance: menuitem (invalid)
    235235PASS appearance: menuitemtext (invalid)
    236 FAIL appearance: menulist-text (invalid) assert_equals: style.appearance expected "" but got "menulist-text"
    237 FAIL appearance: menulist-textfield (invalid) assert_equals: style.appearance expected "" but got "menulist-textfield"
     236PASS appearance: menulist-text (invalid)
     237PASS appearance: menulist-textfield (invalid)
    238238PASS appearance: menupopup (invalid)
    239239PASS appearance: menuradio (invalid)

  • trunk/Source/WebCore/ChangeLog

    r293506 r293511  
     12022-04-27  Ziran Sun  <zsun@igalia.com>
     2
     3        [css-ui] Remove some unimplemented -webkit-appearance keywords
     4        https://bugs.webkit.org/show_bug.cgi?id=238930
     5
     6        Reviewed by Aditya Keerthi.
     7
     8        Remove the following unimplmented --webkit-appearance keyworkds:
     9        button-bevel
     10        media-controls-background
     11        media-controls-fullscreen-background
     12        media-current-time-display
     13        media-enter-fullscreen-button
     14        media-exit-fullscreen-button
     15        media-mute-button
     16        media-overlay-play-button
     17        media-return-to-realtime-button
     18        media-rewind-button
     19        media-seek-back-button
     20        media-seek-forward-button
     21        media-time-remaining-display
     22        media-toggle-closed-captions-button
     23        media-volume-slider-container
     24        menulist-textfield
     25        menulist-text
     26
     27        * css/CSSPrimitiveValueMappings.h:
     28        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     29        * css/CSSProperties.json:
     30        * css/CSSValueKeywords.in:
     31        * platform/ThemeTypes.cpp:
     32        (WebCore::operator<<):
     33        * platform/ThemeTypes.h:
     34        * rendering/RenderTheme.cpp:
     35        (WebCore::RenderTheme::adjustStyle):
     36        (WebCore::RenderTheme::paint):
     37        * rendering/RenderTheme.h:
     38        (WebCore::RenderTheme::paintMediaPlayButton):
     39        (WebCore::RenderTheme::paintMediaMuteButton):
     40        (WebCore::RenderTheme::paintMediaSliderThumb):
     41        (WebCore::RenderTheme::paintMediaVolumeSliderThumb):
     42        (WebCore::RenderTheme::paintMediaFullscreenButton): Deleted.
     43        (WebCore::RenderTheme::paintMediaOverlayPlayButton): Deleted.
     44        (WebCore::RenderTheme::paintMediaSeekBackButton): Deleted.
     45        (WebCore::RenderTheme::paintMediaSeekForwardButton): Deleted.
     46        (WebCore::RenderTheme::paintMediaVolumeSliderContainer): Deleted.
     47        (WebCore::RenderTheme::paintMediaRewindButton): Deleted.
     48        (WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Deleted.
     49        (WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton): Deleted.
     50        (WebCore::RenderTheme::paintMediaControlsBackground): Deleted.
     51        (WebCore::RenderTheme::paintMediaCurrentTime): Deleted.
     52        (WebCore::RenderTheme::paintMediaTimeRemaining): Deleted.
     53
    1542022-04-27  Youenn Fablet  <youenn@apple.com>
    255

  • trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h

    r292463 r293511  
    467467        m_value.valueID = CSSValueButton;
    468468        break;
    469     case ButtonBevelPart:
    470         m_value.valueID = CSSValueButtonBevel;
    471         break;
    472469    case DefaultButtonPart:
    473470        m_value.valueID = CSSValueDefaultButton;
    … …  
    482479        m_value.valueID = CSSValueListitem;
    483480        break;
    484     case MediaEnterFullscreenButtonPart:
    485         m_value.valueID = CSSValueMediaEnterFullscreenButton;
    486         break;
    487     case MediaExitFullscreenButtonPart:
    488         m_value.valueID = CSSValueMediaExitFullscreenButton;
    489         break;
    490481    case MediaPlayButtonPart:
    491482        m_value.valueID = CSSValueMediaPlayButton;
    492483        break;
    493     case MediaOverlayPlayButtonPart:
    494         m_value.valueID = CSSValueMediaOverlayPlayButton;
    495         break;
    496     case MediaMuteButtonPart:
    497         m_value.valueID = CSSValueMediaMuteButton;
    498         break;
    499     case MediaSeekBackButtonPart:
    500         m_value.valueID = CSSValueMediaSeekBackButton;
    501         break;
    502     case MediaSeekForwardButtonPart:
    503         m_value.valueID = CSSValueMediaSeekForwardButton;
    504         break;
    505     case MediaRewindButtonPart:
    506         m_value.valueID = CSSValueMediaRewindButton;
    507         break;
    508     case MediaReturnToRealtimeButtonPart:
    509         m_value.valueID = CSSValueMediaReturnToRealtimeButton;
    510         break;
    511     case MediaToggleClosedCaptionsButtonPart:
    512         m_value.valueID = CSSValueMediaToggleClosedCaptionsButton;
    513         break;
    514484    case MediaSliderPart:
    515485        m_value.valueID = CSSValueMediaSlider;
    … …  
    518488        m_value.valueID = CSSValueMediaSliderthumb;
    519489        break;
    520     case MediaVolumeSliderContainerPart:
    521         m_value.valueID = CSSValueMediaVolumeSliderContainer;
    522         break;
    523490    case MediaVolumeSliderPart:
    524491        m_value.valueID = CSSValueMediaVolumeSlider;
    … …  
    529496    case MediaVolumeSliderThumbPart:
    530497        m_value.valueID = CSSValueMediaVolumeSliderthumb;
    531         break;
    532     case MediaControlsBackgroundPart:
    533         m_value.valueID = CSSValueMediaControlsBackground;
    534         break;
    535     case MediaControlsFullscreenBackgroundPart:
    536         m_value.valueID = CSSValueMediaControlsFullscreenBackground;
    537         break;
     498        break;   
    538499    case MediaFullScreenVolumeSliderPart:
    539500        m_value.valueID = CSSValueMediaFullscreenVolumeSlider;
    … …  
    542503        m_value.valueID = CSSValueMediaFullscreenVolumeSliderThumb;
    543504        break;
    544     case MediaCurrentTimePart:
    545         m_value.valueID = CSSValueMediaCurrentTimeDisplay;
    546         break;
    547     case MediaTimeRemainingPart:
    548         m_value.valueID = CSSValueMediaTimeRemainingDisplay;
    549         break;
    550505    case MediaControlsLightBarBackgroundPart:
    551506        m_value.valueID = CSSValueMediaControlsLightBarBackground;
    … …  
    559514    case MenulistButtonPart:
    560515        m_value.valueID = CSSValueMenulistButton;
    561         break;
    562     case MenulistTextPart:
    563         m_value.valueID = CSSValueMenulistText;
    564         break;
    565     case MenulistTextFieldPart:
    566         m_value.valueID = CSSValueMenulistTextfield;
    567516        break;
    568517    case MeterPart:

  • trunk/Source/WebCore/css/CSSProperties.json

    r293493 r293511  
    51575157                "square-button",
    51585158                "button",
    5159                 "button-bevel",
    51605159                "default-button",
    51615160                "inner-spin-button",
    51625161                "listbox",
    51635162                "listitem",
    5164                 "media-controls-background",
    51655163                "media-controls-dark-bar-background",
    5166                 "media-controls-fullscreen-background",
    51675164                "media-controls-light-bar-background",
    5168                 "media-current-time-display",
    5169                 "media-enter-fullscreen-button",
    5170                 "media-exit-fullscreen-button",
    51715165                "media-fullscreen-volume-slider",
    51725166                "media-fullscreen-volume-slider-thumb",
    5173                 "media-mute-button",
    5174                 "media-overlay-play-button",
    51755167                "media-play-button",
    5176                 "media-return-to-realtime-button",
    5177                 "media-rewind-button",
    5178                 "media-seek-back-button",
    5179                 "media-seek-forward-button",
    51805168                "media-slider",
    51815169                "media-sliderthumb",
    5182                 "media-time-remaining-display",
    5183                 "media-toggle-closed-captions-button",
    51845170                "media-volume-slider",
    5185                 "media-volume-slider-container",
    51865171                "media-volume-slider-mute-button",
    51875172                "media-volume-sliderthumb",
    51885173                "menulist",
    51895174                "menulist-button",
    5190                 "menulist-text",
    5191                 "menulist-textfield",
    51925175                "meter",
    51935176                "progress-bar",

  • trunk/Source/WebCore/css/CSSValueKeywords.in

    r289742 r293511  
    840840square-button
    841841button
    842 button-bevel
    843842default-button
    844843inner-spin-button
    845844listbox
    846845listitem
    847 media-controls-background
    848846media-controls-dark-bar-background
    849 media-controls-fullscreen-background
    850847media-controls-light-bar-background
    851 media-current-time-display
    852 media-enter-fullscreen-button
    853 media-exit-fullscreen-button
    854848media-fullscreen-volume-slider
    855849media-fullscreen-volume-slider-thumb
    856 media-mute-button
    857 media-overlay-play-button
    858850media-play-button
    859 media-return-to-realtime-button
    860 media-rewind-button
    861 media-seek-back-button
    862 media-seek-forward-button
    863851media-slider
    864852media-sliderthumb
    865 media-time-remaining-display
    866 media-toggle-closed-captions-button
    867853media-volume-slider
    868 media-volume-slider-container
    869854media-volume-slider-mute-button
    870855media-volume-sliderthumb
    871856menulist
    872857menulist-button
    873 menulist-text
    874 menulist-textfield
    875858meter
    876859progress-bar

  • trunk/Source/WebCore/platform/ThemeTypes.cpp

    r286461 r293511  
    4141    case SquareButtonPart: ts << "square-button-part"; break;
    4242    case ButtonPart: ts << "button-part"; break;
    43     case ButtonBevelPart: ts << "button-bevel-part"; break;
    4443    case DefaultButtonPart: ts << "default-button-part"; break;
    4544    case InnerSpinButtonPart: ts << "inner-spin-button-part"; break;
    4645    case ListboxPart: ts << "listbox-part"; break;
    4746    case ListItemPart: ts << "list-item-part"; break;
    48     case MediaControlsBackgroundPart: ts << "media-controls-background-part"; break;
    4947    case MediaControlsDarkBarBackgroundPart: ts << "media-controls-dark-bar-background-part"; break;
    50     case MediaControlsFullscreenBackgroundPart: ts << "media-controls-fullscreen-background-part"; break;
    5148    case MediaControlsLightBarBackgroundPart: ts << "media-controls-light-bar-background-part"; break;
    52     case MediaCurrentTimePart: ts << "media-current-time-part"; break;
    53     case MediaEnterFullscreenButtonPart: ts << "media-enter-fullscreen-button-part"; break;
    54     case MediaExitFullscreenButtonPart: ts << "media-exit-fullscreen-button-part"; break;
    5549    case MediaFullScreenVolumeSliderPart: ts << "media-full-screen-volume-slider-part"; break;
    5650    case MediaFullScreenVolumeSliderThumbPart: ts << "media-full-screen-volume-slider-thumb-part"; break;
    57     case MediaMuteButtonPart: ts << "media-mute-button-part"; break;
    58     case MediaOverlayPlayButtonPart: ts << "media-overlay-play-button-part"; break;
    5951    case MediaPlayButtonPart: ts << "media-play-button-part"; break;
    60     case MediaReturnToRealtimeButtonPart: ts << "media-return-to-realtime-button-part"; break;
    61     case MediaRewindButtonPart: ts << "media-rewind-button-part"; break;
    62     case MediaSeekBackButtonPart: ts << "media-seek-back-button-part"; break;
    63     case MediaSeekForwardButtonPart: ts << "media-seek-forward-button-part"; break;
    6452    case MediaSliderPart: ts << "media-slider-part"; break;
    6553    case MediaSliderThumbPart: ts << "media-slider-thumb-part"; break;
    66     case MediaTimeRemainingPart: ts << "media-time-remaining-part"; break;
    67     case MediaToggleClosedCaptionsButtonPart: ts << "media-toggle-closed-captions-button-part"; break;
    6854    case MediaVolumeSliderPart: ts << "media-volume-slider-part"; break;
    69     case MediaVolumeSliderContainerPart: ts << "media-volume-slider-container-part"; break;
    7055    case MediaVolumeSliderMuteButtonPart: ts << "media-volume-slider-mute-button-part"; break;
    7156    case MediaVolumeSliderThumbPart: ts << "media-volume-slider-thumb-part"; break;
    7257    case MenulistPart: ts << "menulist-part"; break;
    7358    case MenulistButtonPart: ts << "menulist-button-part"; break;
    74     case MenulistTextPart: ts << "menulist-text-part"; break;
    75     case MenulistTextFieldPart: ts << "menulist-text-field-part"; break;
    7659    case MeterPart: ts << "meter-part"; break;
    7760    case ProgressBarPart: ts << "progress-bar-part"; break;

  • trunk/Source/WebCore/platform/ThemeTypes.h

    r287666 r293511  
    4141    SquareButtonPart,
    4242    ButtonPart,
    43     ButtonBevelPart,
    4443    DefaultButtonPart,
    4544    InnerSpinButtonPart,
    4645    ListboxPart,
    4746    ListItemPart,
    48     MediaControlsBackgroundPart,
    4947    MediaControlsDarkBarBackgroundPart,
    50     MediaControlsFullscreenBackgroundPart,
    5148    MediaControlsLightBarBackgroundPart,
    52     MediaCurrentTimePart,
    53     MediaEnterFullscreenButtonPart,
    54     MediaExitFullscreenButtonPart,
    5549    MediaFullScreenVolumeSliderPart,
    5650    MediaFullScreenVolumeSliderThumbPart,
    57     MediaMuteButtonPart,
    58     MediaOverlayPlayButtonPart,
    5951    MediaPlayButtonPart,
    60     MediaReturnToRealtimeButtonPart,
    61     MediaRewindButtonPart,
    62     MediaSeekBackButtonPart,
    63     MediaSeekForwardButtonPart,
    6452    MediaSliderPart,
    6553    MediaSliderThumbPart,
    66     MediaTimeRemainingPart,
    67     MediaToggleClosedCaptionsButtonPart,
    6854    MediaVolumeSliderPart,
    69     MediaVolumeSliderContainerPart,
    7055    MediaVolumeSliderMuteButtonPart,
    7156    MediaVolumeSliderThumbPart,
    7257    MenulistPart,
    7358    MenulistButtonPart,
    74     MenulistTextPart,
    75     MenulistTextFieldPart,
    7659    MeterPart,
    7760    ProgressBarPart,

  • trunk/Source/WebCore/rendering/RenderTheme.cpp

    r292376 r293511  
    275275        return adjustMenuListButtonStyle(style, element);
    276276    case MediaPlayButtonPart:
    277     case MediaCurrentTimePart:
    278     case MediaTimeRemainingPart:
    279     case MediaEnterFullscreenButtonPart:
    280     case MediaExitFullscreenButtonPart:
    281     case MediaMuteButtonPart:
    282     case MediaVolumeSliderContainerPart:
    283277        return adjustMediaControlStyle(style, element);
    284278    case MediaSliderPart:
    … …  
    534528    case SliderThumbVerticalPart:
    535529        return paintSliderThumb(box, paintInfo, integralSnappedRect);
    536     case MediaEnterFullscreenButtonPart:
    537     case MediaExitFullscreenButtonPart:
    538         return paintMediaFullscreenButton(box, paintInfo, integralSnappedRect);
    539530    case MediaPlayButtonPart:
    540531        return paintMediaPlayButton(box, paintInfo, integralSnappedRect);
    541     case MediaOverlayPlayButtonPart:
    542         return paintMediaOverlayPlayButton(box, paintInfo, integralSnappedRect);
    543     case MediaMuteButtonPart:
    544         return paintMediaMuteButton(box, paintInfo, integralSnappedRect);
    545     case MediaSeekBackButtonPart:
    546         return paintMediaSeekBackButton(box, paintInfo, integralSnappedRect);
    547     case MediaSeekForwardButtonPart:
    548         return paintMediaSeekForwardButton(box, paintInfo, integralSnappedRect);
    549     case MediaRewindButtonPart:
    550         return paintMediaRewindButton(box, paintInfo, integralSnappedRect);
    551     case MediaReturnToRealtimeButtonPart:
    552         return paintMediaReturnToRealtimeButton(box, paintInfo, integralSnappedRect);
    553     case MediaToggleClosedCaptionsButtonPart:
    554         return paintMediaToggleClosedCaptionsButton(box, paintInfo, integralSnappedRect);
    555532    case MediaSliderPart:
    556533        return paintMediaSliderTrack(box, paintInfo, integralSnappedRect);
    … …  
    558535        return paintMediaSliderThumb(box, paintInfo, integralSnappedRect);
    559536    case MediaVolumeSliderMuteButtonPart:
    560         return paintMediaMuteButton(box, paintInfo, integralSnappedRect);
    561     case MediaVolumeSliderContainerPart:
    562         return paintMediaVolumeSliderContainer(box, paintInfo, integralSnappedRect);
     537        return paintMediaMuteButton(box, paintInfo, integralSnappedRect);   
    563538    case MediaVolumeSliderPart:
    564539        return paintMediaVolumeSliderTrack(box, paintInfo, integralSnappedRect);
    … …  
    569544    case MediaFullScreenVolumeSliderThumbPart:
    570545        return paintMediaFullScreenVolumeSliderThumb(box, paintInfo, integralSnappedRect);
    571     case MediaTimeRemainingPart:
    572         return paintMediaTimeRemaining(box, paintInfo, integralSnappedRect);
    573     case MediaCurrentTimePart:
    574         return paintMediaCurrentTime(box, paintInfo, integralSnappedRect);
    575     case MediaControlsBackgroundPart:
    576         return paintMediaControlsBackground(box, paintInfo, integralSnappedRect);
    577546    case MenulistButtonPart:
    578547    case TextFieldPart:

  • trunk/Source/WebCore/rendering/RenderTheme.h

    r292306 r293511  
    396396
    397397    virtual void adjustMediaControlStyle(RenderStyle&, const Element*) const;
    398     virtual bool paintMediaFullscreenButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    399398    virtual bool paintMediaPlayButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    400     virtual bool paintMediaOverlayPlayButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    401399    virtual bool paintMediaMuteButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    402     virtual bool paintMediaSeekBackButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    403     virtual bool paintMediaSeekForwardButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    404400    virtual bool paintMediaSliderTrack(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    405401    virtual bool paintMediaSliderThumb(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    406     virtual bool paintMediaVolumeSliderContainer(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    407402    virtual bool paintMediaVolumeSliderTrack(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    408403    virtual bool paintMediaVolumeSliderThumb(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    409     virtual bool paintMediaRewindButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    410     virtual bool paintMediaReturnToRealtimeButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    411     virtual bool paintMediaToggleClosedCaptionsButton(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    412     virtual bool paintMediaControlsBackground(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    413     virtual bool paintMediaCurrentTime(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    414     virtual bool paintMediaTimeRemaining(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    415404    virtual bool paintMediaFullScreenVolumeSliderTrack(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }
    416405    virtual bool paintMediaFullScreenVolumeSliderThumb(const RenderObject&, const PaintInfo&, const IntRect&) { return true; }

  • trunk/Source/WebInspectorUI/ChangeLog

    r293409 r293511  
     12022-04-27  Ziran Sun  <zsun@igalia.com>
     2
     3        [css-ui] Remove some unimplemented -webkit-appearance keywords
     4        https://bugs.webkit.org/show_bug.cgi?id=238930
     5
     6        Reviewed by Aditya Keerthi.
     7
     8        We might need to update the changes on UserInterface/External/CodeMirror/css.js since
     9        PR https://github.com/codemirror/CodeMirror/pull/6912 has been merged in CodeMirror.
     10
     11        * UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
     12        * UserInterface/External/CSSDocumentation/CSSDocumentation.js:
     13
    1142022-04-25  Devin Rousso  <drousso@apple.com>
    215

  • trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json

    r287682 r293511  
    22    "shape-outside": {
    33        "description": "Defines a shape around which adjacent inline content should wrap."
     4    },
     5    "-webkit-appearance": {
     6        "description": "Changes the appearance of buttons and other controls to resemble native controls.",
     7        "syntax": "none | button | caret | checkbox | default-button | inner-spin-button | listbox | listitem | media-play-button | media-slider | media-sliderthumb | media-volume-slider | media-volume-sliderthumb | menulist | menulist-button | meter | progress-bar | progress-bar-value | push-button | radio | searchfield | searchfield-cancel-button | searchfield-decoration | searchfield-results-button | searchfield-results-decoration | slider-horizontal | slider-vertical | sliderthumb-horizontal | sliderthumb-vertical | square-button | textarea | textfield | -apple-pay-button"
    48    }
    59}

  • trunk/Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js

    r287682 r293511  
    3030    "-webkit-appearance": {
    3131        "description": "Changes the appearance of buttons and other controls to resemble native controls.",
    32         "syntax": "none | button | button-bevel | caret | checkbox | default-button | inner-spin-button | listbox | listitem | media-controls-background | media-controls-fullscreen-background | media-current-time-display | media-enter-fullscreen-button | media-exit-fullscreen-button | media-fullscreen-button | media-mute-button | media-overlay-play-button | media-play-button | media-seek-back-button | media-seek-forward-button | media-slider | media-sliderthumb | media-time-remaining-display | media-toggle-closed-captions-button | media-volume-slider | media-volume-slider-container | media-volume-sliderthumb | menulist | menulist-button | menulist-text | menulist-textfield | meter | progress-bar | progress-bar-value | push-button | radio | searchfield | searchfield-cancel-button | searchfield-decoration | searchfield-results-button | searchfield-results-decoration | slider-horizontal | slider-vertical | sliderthumb-horizontal | sliderthumb-vertical | square-button | textarea | textfield | -apple-pay-button"
     32        "syntax": "none | button | caret | checkbox | default-button | inner-spin-button | listbox | listitem | media-play-button | media-slider | media-sliderthumb | media-volume-slider | media-volume-sliderthumb | menulist | menulist-button | meter | progress-bar | progress-bar-value | push-button | radio | searchfield | searchfield-cancel-button | searchfield-decoration | searchfield-results-button | searchfield-results-decoration | slider-horizontal | slider-vertical | sliderthumb-horizontal | sliderthumb-vertical | square-button | textarea | textfield | -apple-pay-button"
    3333    },
    3434    "-webkit-backdrop-filter": {
Note: See TracChangeset for help on using the changeset viewer.