Changeset 293524 in webkit


Ignore:
Timestamp:
Apr 27, 2022 12:04:59 PM (3 months ago)
Author:
ntim@apple.com
Message:

Make -webkit-transform-style an alias of transform-style
​https://bugs.webkit.org/show_bug.cgi?id=239808

Reviewed by Antti Koivisto.

Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes
unnecessary code as well given the FIXME was never addressed.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
  • web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

  • css/CSSProperties.json:
  • css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

  • rendering/style/WillChangeData.cpp:

(WebCore::WillChangeData::propertyCreatesStackingContext):

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
Location:
trunk
Files:
21 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r293523 r293524  
     12022-04-27  Tim Nguyen  <ntim@apple.com>
     2
     3        Make -webkit-transform-style an alias of transform-style
     4        https://bugs.webkit.org/show_bug.cgi?id=239808
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes
     9        unnecessary code as well given the FIXME was never addressed.
     10
     11        * fast/css/getComputedStyle/computed-style-expected.txt:
     12        * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
     13        * platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
     14        * platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
     15        * platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
     16        * platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
     17        * platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
     18        * platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
     19        * platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
     20        * svg/css/getComputedStyle-basic-expected.txt:
     21
    1222022-04-27  Arcady Goldmints-Orlov  <agoldmints@igalia.com>
    223

  • trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt

    r293521 r293524  
    254254-webkit-text-stroke-color: rgb(0, 0, 0);
    255255-webkit-text-stroke-width: 0px;
    256 -webkit-transform-style: flat;
    257256-webkit-user-drag: auto;
    258257-webkit-user-modify: read-only;

  • trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt

    r293521 r293524  
    253253-webkit-text-stroke-color: rgb(0, 0, 0)
    254254-webkit-text-stroke-width: 0px
    255 -webkit-transform-style: flat
    256255-webkit-user-drag: auto
    257256-webkit-user-modify: read-only

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r293521 r293524  
     12022-04-27  Tim Nguyen  <ntim@apple.com>
     2
     3        Make -webkit-transform-style an alias of transform-style
     4        https://bugs.webkit.org/show_bug.cgi?id=239808
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes
     9        unnecessary code as well given the FIXME was never addressed.
     10
     11        * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
     12        * web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
     13        * web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
     14
    1152022-04-27  Tim Nguyen  <ntim@apple.com>
    216

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt

    r293521 r293524  
    399399PASS -webkit-text-stroke-width
    400400PASS -webkit-text-zoom
    401 PASS -webkit-transform-style
    402401PASS -webkit-user-drag
    403402PASS -webkit-user-modify

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt

    r293521 r293524  
    311311FAIL transform-origin-y assert_not_equals: Should have the initial value. got disallowed value ""
    312312FAIL transform-origin-z assert_not_equals: Should have the initial value. got disallowed value ""
    313 FAIL transform-style assert_not_equals: Should get a different computed value. got disallowed value "flat"
     313PASS transform-style
    314314PASS transition-delay
    315315PASS transition-duration

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt

    r293521 r293524  
    11
    22PASS getComputedStyle returns no style for detached element
    3 FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 399
    4 FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 399
    5 FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 399
    6 FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 399
     3FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 398
     4FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 398
     5FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 398
     6FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 398
    77PASS getComputedStyle returns no style for shadow tree outside of flattened tree
    88

  • trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt

    r293521 r293524  
    397397PASS -webkit-text-stroke-width
    398398PASS -webkit-text-zoom
    399 PASS -webkit-transform-style
    400399PASS -webkit-user-drag
    401400PASS -webkit-user-modify

  • trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt

    r293521 r293524  
    11
    22PASS getComputedStyle returns no style for detached element
    3 FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 397
    4 FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 397
    5 FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 397
    6 FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 397
     3FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 396
     4FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 396
     5FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 396
     6FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 396
    77PASS getComputedStyle returns no style for shadow tree outside of flattened tree
    88

  • trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt

    r293521 r293524  
    374374PASS -webkit-text-zoom
    375375PASS -webkit-touch-callout
    376 PASS -webkit-transform-style
    377376PASS -webkit-user-drag
    378377PASS -webkit-user-modify

  • trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt

    r293521 r293524  
    11
    22PASS getComputedStyle returns no style for detached element
    3 FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 401
    4 FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 401
    5 FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 401
    6 FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 401
     3FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 400
     4FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 400
     5FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 400
     6FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 400
    77PASS getComputedStyle returns no style for shadow tree outside of flattened tree
    88

  • trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt

    r293521 r293524  
    310310FAIL transform-origin-y assert_not_equals: Should have the initial value. got disallowed value ""
    311311FAIL transform-origin-z assert_not_equals: Should have the initial value. got disallowed value ""
    312 FAIL transform-style assert_not_equals: Should get a different computed value. got disallowed value "flat"
     312PASS transform-style
    313313PASS transition-delay
    314314PASS transition-duration

  • trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt

    r293521 r293524  
    396396PASS -webkit-text-stroke-width
    397397PASS -webkit-text-zoom
    398 PASS -webkit-transform-style
    399398PASS -webkit-user-drag
    400399PASS -webkit-user-modify

  • trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt

    r293521 r293524  
    11
    22PASS getComputedStyle returns no style for detached element
    3 FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 396
    4 FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 396
    5 FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 396
    6 FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 396
     3FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 395
     4FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 395
     5FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 395
     6FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 395
    77PASS getComputedStyle returns no style for shadow tree outside of flattened tree
    88

  • trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt

    r293521 r293524  
    505505rect: style.getPropertyValue(-webkit-text-stroke-width) : 0px
    506506rect: style.getPropertyCSSValue(-webkit-text-stroke-width) : [object CSSPrimitiveValue]
    507 rect: style.getPropertyValue(-webkit-transform-style) : flat
    508 rect: style.getPropertyCSSValue(-webkit-transform-style) : [object CSSPrimitiveValue]
    509507rect: style.getPropertyValue(-webkit-user-drag) : auto
    510508rect: style.getPropertyCSSValue(-webkit-user-drag) : [object CSSPrimitiveValue]
    … …  
    10171015g: style.getPropertyValue(-webkit-text-stroke-width) : 0px
    10181016g: style.getPropertyCSSValue(-webkit-text-stroke-width) : [object CSSPrimitiveValue]
    1019 g: style.getPropertyValue(-webkit-transform-style) : flat
    1020 g: style.getPropertyCSSValue(-webkit-transform-style) : [object CSSPrimitiveValue]
    10211017g: style.getPropertyValue(-webkit-user-drag) : auto
    10221018g: style.getPropertyCSSValue(-webkit-user-drag) : [object CSSPrimitiveValue]

  • trunk/Source/WebCore/ChangeLog

    r293522 r293524  
     12022-04-27  Tim Nguyen  <ntim@apple.com>
     2
     3        Make -webkit-transform-style an alias of transform-style
     4        https://bugs.webkit.org/show_bug.cgi?id=239808
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes
     9        unnecessary code as well given the FIXME was never addressed.
     10
     11        * animation/CSSPropertyAnimation.cpp:
     12        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     13        * css/CSSComputedStyleDeclaration.cpp:
     14        (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
     15        * css/CSSProperties.json:
     16        * css/parser/CSSParserFastPaths.cpp:
     17        (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     18        (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     19        * rendering/style/WillChangeData.cpp:
     20        (WebCore::WillChangeData::propertyCreatesStackingContext):
     21
    1222022-04-27  Simon Fraser  <simon.fraser@apple.com>
    223

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r293521 r293524  
    36533653        case CSSPropertyWebkitTouchCallout:
    36543654#endif
    3655         case CSSPropertyWebkitTransformStyle:
    36563655        case CSSPropertyWebkitUserDrag:
    36573656        case CSSPropertyWebkitUserModify:

  • trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

    r293521 r293524  
    39243924        }
    39253925        case CSSPropertyTransformStyle:
    3926         case CSSPropertyWebkitTransformStyle:
    39273926            switch (style.transformStyle3D()) {
    39283927            case TransformStyle3D::Flat:

  • trunk/Source/WebCore/css/CSSProperties.json

    r293521 r293524  
    72207220            ],
    72217221            "codegen-properties": {
     7222                "aliases": [
     7223                    "-webkit-transform-style"
     7224                ],
    72227225                "name-for-methods": "TransformStyle3D"
    72237226            },
    … …  
    72257228                "category": "css-transforms",
    72267229                "url": "https://www.w3.org/TR/css-transforms-1/#transform-style-property"
    7227             }
    7228         },
    7229         "-webkit-transform-style": {
    7230             "values": [
    7231                 "flat",
    7232                 "preserve-3d",
    7233                 {
    7234                     "value": "optimized-3d",
    7235                     "status": "internal"
    7236                 }
    7237             ],
    7238             "codegen-properties": {
    7239                 "name-for-methods": "TransformStyle3D",
    7240                 "comment": "Keeping -webkit-transform-style around is how we'll detect legacy content. At that point, we'll have to add a custom builder and a new TransformStyle3D type. FIXME: this never happened."
    72417230            }
    72427231        },

  • trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp

    r293521 r293524  
    815815        return valueID == CSSValueDisc || valueID == CSSValueCircle || valueID == CSSValueSquare || valueID == CSSValueNone;
    816816    case CSSPropertyTransformStyle:
    817     case CSSPropertyWebkitTransformStyle:
    818817        return valueID == CSSValueFlat
    819818            || valueID == CSSValuePreserve3d
    … …  
    987986    case CSSPropertyWebkitTextSecurity:
    988987    case CSSPropertyWebkitTextZoom:
    989     case CSSPropertyWebkitTransformStyle:
    990988    case CSSPropertyWebkitUserDrag:
    991989    case CSSPropertyWebkitUserModify:

  • trunk/Source/WebCore/rendering/style/WillChangeData.cpp

    r286795 r293524  
    9696    case CSSPropertyTransform:
    9797    case CSSPropertyTransformStyle:
    98     case CSSPropertyWebkitTransformStyle:
    9998    case CSSPropertyClipPath:
    10099    case CSSPropertyMask:
Note: See TracChangeset for help on using the changeset viewer.