Changeset 293541 in webkit

Timestamp:

Apr 27, 2022 3:38:00 PM (3 months ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Improve rendering of GLenums in WebGL canvas recordings.
​https://bugs.webkit.org/show_bug.cgi?id=239586

Patch by Dan Glastonbury <​djg@apple.com> on 2022-04-27
Reviewed by Devin Rousso.

• Source/WebInspectorUI/UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.constantNameForParameter):
Arrays are also objects, so checking for typeof x == "object" is
not enough to distinguish arrays from dictionaries. Since the if
above the failing check was handling arrays, turn "object" check
into an else if handles arrays and dictionaries correctly.

Canonical link: ​https://commits.webkit.org/250062@main

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/RecordingAction.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2022-04-20  Dan Glastonbury  <djg@apple.com>
+
+        Web Inspector: Improve rendering of GLenums in WebGL canvas recordings.
+        https://bugs.webkit.org/show_bug.cgi?id=239586
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Models/RecordingAction.js:
+        (WI.RecordingAction.constantNameForParameter):
+        Arrays are also objects, so checking for typeof x == "object" is
+        not enough to distinguish arrays from dictionaries. Since the if
+        above the failing check was handling arrays, turn "object" check
+        into an `else if` handles arrays and dictionaries correctly.
+
 2022-04-27  Ziran Sun  <zsun@igalia.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js

@@ -126 +126 @@
             return null;
 
-        if (Array.isArray(indexesForAction) && !indexesForAction.includes(index))
-            return null;
-
-        if (typeof indexesForAction === "object") {
+        if (Array.isArray(indexesForAction)) {
+            if (!indexesForAction.includes(index))
+                return null;
+        } else if (typeof indexesForAction === "object") {
             let indexesForActionVariant = indexesForAction[count];
             if (!indexesForActionVariant)