Changeset 293602 in webkit


Ignore:
Timestamp:
Apr 28, 2022 6:46:53 PM (3 months ago)
Author:
Oriol Brufau
Message:

[css-cascade] Mark properties sharing a computed value as related
​https://bugs.webkit.org/show_bug.cgi?id=239579

Reviewed by Tim Nguyen.

LayoutTests/imported/w3c:

Some failures are now passing.

  • web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:

Source/WebCore:

Some longhand properties share a computed value with another property,
like a legacy -webkit- prefixed one.

In that case, when both properties are specified, the last one should
win. That is typically done by marking the properties as related, using
the "related-property" field. This defers the properties and makes
them cascade properly.

However, some properties weren't marked as related despite sharing a
computed value. So this patch marks these pairs:

  • mask-clip and -webkit-mask-clip
  • mask-composite and -webkit-mask-composite
  • mask-mode and -webkit-mask-source-type
  • text-combine-upright and -webkit-text-combine

Test: imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html

  • css/CSSProperties.json:

LayoutTests:

Some failures are now passing.

  • platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r293594 r293602  
     12022-04-28  Oriol Brufau  <obrufau@igalia.com>
     2
     3        [css-cascade] Mark properties sharing a computed value as related
     4        https://bugs.webkit.org/show_bug.cgi?id=239579
     5
     6        Reviewed by Tim Nguyen.
     7
     8        Some failures are now passing.
     9
     10        * platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
     11
    1122022-04-28  Karl Rackler  <rackler@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r293587 r293602  
     12022-04-28  Oriol Brufau  <obrufau@igalia.com>
     2
     3        [css-cascade] Mark properties sharing a computed value as related
     4        https://bugs.webkit.org/show_bug.cgi?id=239579
     5
     6        Reviewed by Tim Nguyen.
     7
     8        Some failures are now passing.
     9
     10        * web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
     11
    1122022-04-28  Arcady Goldmints-Orlov  <agoldmints@igalia.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt

    r293524 r293602  
    185185PASS marker-mid
    186186PASS marker-start
    187 FAIL mask-clip assert_not_equals: Should get a different computed value. got disallowed value "border-box"
    188 FAIL mask-composite assert_not_equals: Should get a different computed value. got disallowed value "add"
     187PASS mask-clip
     188PASS mask-composite
    189189PASS mask-image
    190 FAIL mask-mode assert_not_equals: Should get a different computed value. got disallowed value "match-source"
     190PASS mask-mode
    191191PASS mask-origin
    192192PASS mask-repeat
    … …  
    285285PASS text-align
    286286PASS text-anchor
    287 FAIL text-combine-upright assert_not_equals: Should get a different computed value. got disallowed value "none"
     287PASS text-combine-upright
    288288PASS text-decoration
    289289PASS text-decoration-color

  • trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt

    r293524 r293602  
    185185PASS marker-mid
    186186PASS marker-start
    187 FAIL mask-clip assert_not_equals: Should get a different computed value. got disallowed value "border-box"
    188 FAIL mask-composite assert_not_equals: Should get a different computed value. got disallowed value "add"
     187PASS mask-clip
     188PASS mask-composite
    189189PASS mask-image
    190 FAIL mask-mode assert_not_equals: Should get a different computed value. got disallowed value "match-source"
     190PASS mask-mode
    191191PASS mask-origin
    192192PASS mask-repeat
    … …  
    284284PASS text-align
    285285PASS text-anchor
    286 FAIL text-combine-upright assert_not_equals: Should get a different computed value. got disallowed value "none"
     286PASS text-combine-upright
    287287PASS text-decoration
    288288PASS text-decoration-color

  • trunk/Source/WebCore/ChangeLog

    r293601 r293602  
     12022-04-28  Oriol Brufau  <obrufau@igalia.com>
     2
     3        [css-cascade] Mark properties sharing a computed value as related
     4        https://bugs.webkit.org/show_bug.cgi?id=239579
     5
     6        Reviewed by Tim Nguyen.
     7
     8        Some longhand properties share a computed value with another property,
     9        like a legacy -webkit- prefixed one.
     10
     11        In that case, when both properties are specified, the last one should
     12        win. That is typically done by marking the properties as related, using
     13        the "related-property" field. This defers the properties and makes
     14        them cascade properly.
     15
     16        However, some properties weren't marked as related despite sharing a
     17        computed value. So this patch marks these pairs:
     18         - mask-clip and -webkit-mask-clip
     19         - mask-composite and -webkit-mask-composite
     20         - mask-mode and -webkit-mask-source-type
     21         - text-combine-upright and -webkit-text-combine
     22
     23        Test: imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html
     24
     25        * css/CSSProperties.json:
     26
    1272022-04-28  Yusuke Suzuki  <ysuzuki@apple.com>
    228

  • trunk/Source/WebCore/css/CSSProperties.json

    r293524 r293602  
    33323332        "mask-clip": {
    33333333            "codegen-properties": {
     3334                "related-property": "-webkit-mask-clip",
    33343335                "name-for-methods": "Clip",
    33353336                "fill-layer-property": true
    … …  
    33423343        "mask-composite": {
    33433344            "codegen-properties": {
     3345                "related-property": "-webkit-mask-composite",
    33443346                "name-for-methods": "Composite",
    33453347                "fill-layer-property": true
    … …  
    33653367        "mask-mode": {
    33663368            "codegen-properties": {
     3369                "related-property": "-webkit-mask-source-type",
    33673370                "name-for-methods": "MaskMode",
    33683371                "fill-layer-property": true
    … …  
    65826585        "-webkit-mask-clip": {
    65836586            "codegen-properties": {
     6587                "related-property": "mask-clip",
    65846588                "name-for-methods": "Clip",
    65856589                "fill-layer-property": true
    … …  
    65956599        "-webkit-mask-composite": {
    65966600            "codegen-properties": {
     6601                "related-property": "mask-composite",
    65976602                "name-for-methods": "Composite",
    65986603                "fill-layer-property": true
    … …  
    66086613        "-webkit-mask-source-type": {
    66096614            "codegen-properties": {
     6615                "related-property": "mask-mode",
    66106616                "synonym": "mask-mode",
    66116617                "comment": "Deprecated alias for mask-mode, supports an 'auto' value, does not support 'match-source'"
    … …  
    67976803            ],
    67986804            "codegen-properties": {
     6805                "related-property": "text-combine-upright",
    67996806                "aliases": [
    68006807                    "-epub-text-combine"
    … …  
    68096816            "inherited": true,
    68106817            "codegen-properties": {
     6818                "related-property": "-webkit-text-combine",
    68116819                "name-for-methods": "TextCombine"
    68126820            },
Note: See TracChangeset for help on using the changeset viewer.