Changeset 50173 in webkit


Ignore:
Timestamp:
Oct 27, 2009, 2:51:23 PM (15 years ago)
Author:
darin@chromium.org
Message:

2009-10-27 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Ensures that JavaScriptCore/wtf/CurrentTime.cpp is not built in PLATFORM(CHROMIUM) builds.

Chromium uses a different method to calculate the current time than is used in
JavaScriptCore/wtf/CurrentTime.cpp. This can lead to time skew when calls to currentTime() and Chromium's time
function are mixed. In particular, timers can get scheduled in the past which leads to 100% CPU use.
See http://code.google.com/p/chromium/issues/detail?id=25892 for an example.

https://bugs.webkit.org/show_bug.cgi?id=30833

Location:
trunk/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/ChangeLog

    r50143 r50173  
     12009-10-27  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        Ensures that JavaScriptCore/wtf/CurrentTime.cpp is not built in PLATFORM(CHROMIUM) builds.
     6
     7        Chromium uses a different method to calculate the current time than is used in
     8        JavaScriptCore/wtf/CurrentTime.cpp. This can lead to time skew when calls to currentTime() and Chromium's time
     9        function are mixed.  In particular, timers can get scheduled in the past which leads to 100% CPU use.
     10        See http://code.google.com/p/chromium/issues/detail?id=25892 for an example.
     11
     12        https://bugs.webkit.org/show_bug.cgi?id=30833
     13
     14        * JavaScriptCore.gyp/JavaScriptCore.gyp:
     15        * wtf/CurrentTime.cpp:
     16
    1172009-10-27  Peter Varga  <pvarga@inf.u-szeged.hu>
    218
  • trunk/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp

    r48827 r50173  
    122122        ['exclude', '/(GOwnPtr|glib/.*)\\.(cpp|h)$'],
    123123        ['exclude', '(Default|Gtk|Mac|None|Qt|Win|Wx)\\.(cpp|mm)$'],
     124        ['exclude', 'wtf/CurrentTime\\.cpp$'],
    124125      ],
    125126      'direct_dependent_settings': {
  • trunk/JavaScriptCore/wtf/CurrentTime.cpp

    r46660 r50173  
    6464#endif
    6565
     66#if PLATFORM(CHROMIUM)
     67#error Chromium uses a different timer implementation
     68#endif
     69
    6670namespace WTF {
    6771
Note: See TracChangeset for help on using the changeset viewer.