Changeset 80155 in webkit
- Timestamp:
- Mar 2, 2011 11:56:10 AM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
-
ChangeLog (modified) (1 diff)
-
css/CSSSelector.h (modified) (4 diffs)
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r80151 r80155 1 2011-03-02 Mihai Parparita <mihaip@chromium.org> 2 3 Reviewed by Dimitri Glazkov. 4 5 Add CRASH() for CSSSelector double frees 6 https://bugs.webkit.org/show_bug.cgi?id=55596 7 8 To help track down bug 53045, add a CRASH call when the CSSSelector 9 destructor is invoked more than once. 10 11 Just a check, no new tests necessary. 12 13 * css/CSSSelector.h: 14 (WebCore::CSSSelector::CSSSelector): 15 (WebCore::CSSSelector::~CSSSelector): 16 1 17 2011-03-02 Carol Szabo <carol.szabo@nokia.com> 2 18 -
trunk/Source/WebCore/css/CSSSelector.h
r77954 r80155 44 44 , m_hasRareData(false) 45 45 , m_isForPage(false) 46 , m_deleted(false) 46 47 , m_tag(anyQName()) 47 48 { … … 57 58 , m_hasRareData(false) 58 59 , m_isForPage(false) 60 , m_deleted(false) 59 61 , m_tag(qName) 60 62 { … … 63 65 ~CSSSelector() 64 66 { 67 if (m_deleted) 68 CRASH(); 69 m_deleted = true; 65 70 if (m_hasRareData) 66 71 delete m_data.m_rareData; … … 280 285 bool m_hasRareData : 1; 281 286 bool m_isForPage : 1; 287 // FIXME: Remove once http://webkit.org/b/53045 is fixed. 288 bool m_deleted : 1; 282 289 283 290 unsigned specificityForOneSelector() const;
Note: See TracChangeset
for help on using the changeset viewer.