Changeset 85693 in webkit


Ignore:
Timestamp:
May 3, 2011, 5:31:55 PM (14 years ago)
Author:
dino@apple.com
Message:

2011-05-03 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Interrupted transitions are not correctly removed
https://bugs.webkit.org/show_bug.cgi?id=60062

CompositeAnimation was replacing any existing
transition as a new one was created. However, it wasn't
clearing the lists in AnimationControllerPrivate that
signal when a hardware animation starts. Rather than
simple removing the existing transition, we now tell
AnimationControllerPrivate that is has gone.

Test: transitions/3d/interrupted-transition.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):

2011-05-03 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Interrupted transitions are not correctly removed
https://bugs.webkit.org/show_bug.cgi?id=60062

  • transitions/3d/interrupted-transition-expected.txt: Added.
  • transitions/3d/interrupted-transition.html: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r85690 r85693  
     12011-05-03  Dean Jackson  <dino@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Interrupted transitions are not correctly removed
     6        https://bugs.webkit.org/show_bug.cgi?id=60062
     7
     8        * transitions/3d/interrupted-transition-expected.txt: Added.
     9        * transitions/3d/interrupted-transition.html: Added.
     10
    1112011-05-03  Alpha Lam  <hclam@chromium.org>
    212
  • trunk/Source/WebCore/ChangeLog

    r85687 r85693  
     12011-05-03  Dean Jackson  <dino@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Interrupted transitions are not correctly removed
     6        https://bugs.webkit.org/show_bug.cgi?id=60062
     7
     8        CompositeAnimation was replacing any existing
     9        transition as a new one was created. However, it wasn't
     10        clearing the lists in AnimationControllerPrivate that
     11        signal when a hardware animation starts. Rather than
     12        simple removing the existing transition, we now tell
     13        AnimationControllerPrivate that is has gone.
     14
     15        Test: transitions/3d/interrupted-transition.html
     16
     17        * page/animation/CompositeAnimation.cpp:
     18        (WebCore::CompositeAnimation::updateTransitions):
     19
    1202011-05-03  Enrica Casucci  <enrica@apple.com>
    221
  • trunk/Source/WebCore/page/animation/CompositeAnimation.cpp

    r83542 r85693  
    152152                        }
    153153    #endif
     154                        animationController()->animationWillBeRemoved(implAnim);
    154155                        m_transitions.remove(prop);
    155156                        equal = false;
Note: See TracChangeset for help on using the changeset viewer.