Changeset 100163 in webkit


Ignore:
Timestamp:
Nov 14, 2011 11:11:57 AM (12 years ago)
Author:
arv@chromium.org
Message:

Remove RequiresAllArguments
​https://bugs.webkit.org/show_bug.cgi?id=71503

Reviewed by Adam Barth.

Source/WebCore:

This removes RequiresAllArguments from the idl files as well as from the code generators.
For window.move/resize/scroll we now match IE and treat missing arguments as 0.
For Clipboard we now match Gecko and IE and throw an exception when setData is called with too few arguments.

Test: fast/events/drag-and-drop-set-drag-data-arguments.html

  • bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::convertToSpecifiedUnits):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateArgumentsCountCheck): Remove RequiresAllArguments.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateArgumentsCountCheck): Ditto.

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • dom/Clipboard.idl: Remove [RequireAllArguments] from setData which actually means we now require all arguments and throw instead of silently fail.
  • page/DOMWindow.idl: Treat missing arguments as 0 which makes us match IE.
  • websockets/WebSocket.idl: Comment changes only.

LayoutTests:

  • fast/dom/Window/window-resize-and-move-arguments-expected.txt:
  • fast/dom/Window/window-resize-and-move-arguments.html: Treat missing arguments as 0.
  • fast/dom/Window/window-scroll-arguments-expected.txt:
  • fast/dom/Window/window-scroll-arguments.html: Ditto.
  • fast/events/drag-and-drop-set-drag-data-arguments-expected.txt: Added.
  • fast/events/drag-and-drop-set-drag-data-arguments.html: Added. This tests that we get an exception when called with too few arguments.
Location:
trunk
Files:
2 added
22 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r100159 r100163  
     12011-11-14  Erik Arvidsson  <arv@chromium.org>
     2
     3        Remove RequiresAllArguments
     4        https://bugs.webkit.org/show_bug.cgi?id=71503
     5
     6        Reviewed by Adam Barth.
     7
     8        * fast/dom/Window/window-resize-and-move-arguments-expected.txt:
     9        * fast/dom/Window/window-resize-and-move-arguments.html: Treat missing arguments as 0.
     10        * fast/dom/Window/window-scroll-arguments-expected.txt:
     11        * fast/dom/Window/window-scroll-arguments.html: Ditto.
     12        * fast/events/drag-and-drop-set-drag-data-arguments-expected.txt: Added.
     13        * fast/events/drag-and-drop-set-drag-data-arguments.html: Added. This tests that we get an exception when called with too few arguments.
     14
    1152011-11-11  Jer Noble  <jer.noble@apple.com>
    216

  • trunk/LayoutTests/fast/dom/Window/window-resize-and-move-arguments-expected.txt

    r28570 r100163  
    1 This test makes sure that we don't allow calling the window moving and resizing methods with less than 2 arguments and that we do allow calling them with more.
     1This test makes sure that calling the window moving and resizing methods with less than 2 arguments treats the missing arguments as 0.
    22
    33On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    … …  
    1111PASS window.outerHeight is resetHeight
    1212Testing - resizeTo with 1 argument
    13 PASS window.outerWidth is resetWidth
     13PASS window.outerWidth is width
    1414PASS window.outerHeight is resetHeight
    1515Testing - resizeTo with more than 2 arguments
    … …  
    2323PASS window.outerHeight is resetHeight
    2424Testing - resizeBy with 1 argument
    25 PASS window.outerWidth is resetWidth
     25PASS window.outerWidth is resetWidth + x
    2626PASS window.outerHeight is resetHeight
    2727Testing - resizeBy with more than 2 arguments
    … …  
    3535PASS window.screenY is resetY
    3636Testing - moveTo with 1 argument
    37 PASS window.screenX is resetX
     37PASS window.screenX is resetX + x
    3838PASS window.screenY is resetY
    3939Testing - moveTo with more than 2 arguments
    … …  
    4747PASS window.screenY is resetY
    4848Testing - moveBy with 1 argument
    49 PASS window.screenX is resetX
     49PASS window.screenX is resetX + x
    5050PASS window.screenY is resetY
    5151Testing - moveBy with more than 2 arguments

  • trunk/LayoutTests/fast/dom/Window/window-resize-and-move-arguments.html

    r98407 r100163  
    3131    reset();
    3232
    33     description("This test makes sure that we don't allow calling the window moving and resizing\
    34     methods with less than 2 arguments and that we do allow calling them with more.");
     33    description("This test makes sure that calling the window moving and resizing\
     34    methods with less than 2 arguments treats the missing arguments as 0.");
    3535
    3636    // resizeTo /////////////////////////
    … …  
    4747    debug("Testing - resizeTo with 1 argument");
    4848    window.resizeTo(x);
    49     shouldBe('window.outerWidth', 'resetWidth');
     49    shouldBe('window.outerWidth', 'width');
    5050    shouldBe('window.outerHeight', 'resetHeight');
    5151    reset();
    … …  
    7070    debug("Testing - resizeBy with 1 argument");
    7171    window.resizeBy(x);
    72     shouldBe('window.outerWidth', 'resetWidth');
     72    shouldBe('window.outerWidth', 'resetWidth + x');
    7373    shouldBe('window.outerHeight', 'resetHeight');
    7474    reset();
    … …  
    9494    debug("Testing - moveTo with 1 argument");
    9595    window.moveTo(x);
    96     shouldBe('window.screenX', 'resetX');
     96    shouldBe('window.screenX', 'resetX + x');
    9797    shouldBe('window.screenY', 'resetY');
    9898    reset();
    … …  
    119119    debug("Testing - moveBy with 1 argument");
    120120    window.moveBy(x);
    121     shouldBe('window.screenX', 'resetX');
     121    shouldBe('window.screenX', 'resetX + x');
    122122    shouldBe('window.screenY', 'resetY');
    123123    reset();

  • trunk/LayoutTests/fast/dom/Window/window-scroll-arguments-expected.txt

    r28570 r100163  
    1 This test makes sure that we don't allow calling the window scrolling methods with less than 2 arguments and that we do allow calling them with more.
     1This test makes sure that calling the window scrolling methods with less than 2 arguments treats the missing arguments as 0.
    22
    33On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    … …  
    1111PASS window.scrollY is resetY
    1212Testing - scrollTo with 1 argument
    13 PASS window.scrollX is resetX
     13PASS window.scrollX is resetX + x
    1414PASS window.scrollY is resetY
    1515Testing - scrollTo with more than 2 arguments
    … …  
    2323PASS window.scrollY is resetY
    2424Testing - scroll with 1 argument
    25 PASS window.scrollX is resetX
     25PASS window.scrollX is resetX + x
    2626PASS window.scrollY is resetY
    2727Testing - scroll with more than 2 arguments
    … …  
    3535PASS window.scrollY is resetY
    3636Testing - scrollBy with 1 argument
    37 PASS window.scrollX is resetX
     37PASS window.scrollX is resetX + x
    3838PASS window.scrollY is resetY
    3939Testing - scrollBy with more than 2 arguments

  • trunk/LayoutTests/fast/dom/Window/window-scroll-arguments.html

    r98407 r100163  
    2525    reset();
    2626
    27     description("This test makes sure that we don't allow calling the window scrolling\
    28     methods with less than 2 arguments and that we do allow calling them with more.");
     27    description("This test makes sure that calling the window scrolling\
     28    methods with less than 2 arguments treats the missing arguments as 0.");
    2929
    3030    // scrollTo /////////////////////////
    … …  
    4141    debug("Testing - scrollTo with 1 argument");
    4242    window.scrollTo(x);
    43     shouldBe('window.scrollX', 'resetX');
     43    shouldBe('window.scrollX', 'resetX + x');
    4444    shouldBe('window.scrollY', 'resetY');
    4545    reset();
    … …  
    6464    debug("Testing - scroll with 1 argument");
    6565    window.scroll(x);
    66     shouldBe('window.scrollX', 'resetX');
     66    shouldBe('window.scrollX', 'resetX + x');
    6767    shouldBe('window.scrollY', 'resetY');
    6868    reset();
    … …  
    8787    debug("Testing - scrollBy with 1 argument");
    8888    window.scrollBy(x);
    89     shouldBe('window.scrollX', 'resetX');
     89    shouldBe('window.scrollX', 'resetX + x');
    9090    shouldBe('window.scrollY', 'resetY');
    9191    reset();

  • trunk/Source/WebCore/ChangeLog

    r100159 r100163  
     12011-11-14  Erik Arvidsson  <arv@chromium.org>
     2
     3        Remove RequiresAllArguments
     4        https://bugs.webkit.org/show_bug.cgi?id=71503
     5
     6        Reviewed by Adam Barth.
     7
     8        This removes RequiresAllArguments from the idl files as well as from the code generators.
     9        For window.move/resize/scroll we now match IE and treat missing arguments as 0.
     10        For Clipboard we now match Gecko and IE and throw an exception when setData is called with too few arguments.
     11
     12        Test: fast/events/drag-and-drop-set-drag-data-arguments.html
     13
     14        * bindings/js/JSSVGLengthCustom.cpp:
     15        (WebCore::JSSVGLength::convertToSpecifiedUnits):
     16        * bindings/scripts/CodeGeneratorJS.pm:
     17        (GenerateArgumentsCountCheck): Remove RequiresAllArguments.
     18        * bindings/scripts/CodeGeneratorV8.pm:
     19        (GenerateArgumentsCountCheck): Ditto.
     20        * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
     21        * bindings/scripts/test/CPP/WebDOMTestObj.h:
     22        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
     23        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
     24        * bindings/scripts/test/JS/JSTestObj.cpp:
     25        * bindings/scripts/test/JS/JSTestObj.h:
     26        * bindings/scripts/test/ObjC/DOMTestObj.h:
     27        * bindings/scripts/test/ObjC/DOMTestObj.mm:
     28        * bindings/scripts/test/TestObj.idl:
     29        * bindings/scripts/test/V8/V8TestObj.cpp:
     30        (WebCore::ConfigureV8TestObjTemplate):
     31        * dom/Clipboard.idl: Remove [RequireAllArguments] from setData which actually means we now require all arguments and throw instead of silently fail.
     32        * page/DOMWindow.idl: Treat missing arguments as 0 which makes us match IE.
     33        * websockets/WebSocket.idl: Comment changes only.
     34
    1352011-11-08  Jer Noble  <jer.noble@apple.com>
    236

  • trunk/Source/WebCore/bindings/js/JSSVGLengthCustom.cpp

    r100075 r100163  
    8181    SVGLength& podImp = impl()->propertyReference();
    8282
    83     // Mimic the behaviour of RequiresAllArguments=Raise.
    8483    if (exec->argumentCount() < 1)
    8584        return throwError(exec, createSyntaxError(exec, "Not enough arguments"));

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r100086 r100163  
    22532253    {
    22542254        push(@$outputArray, "    if (exec->argumentCount() < $numMandatoryParams)\n");
    2255         if ($function->signature->extendedAttributes->{"RequiresAllArguments"}) {
    2256             push(@$outputArray, "        return JSValue::encode(jsUndefined());\n");
    2257         } else {
    2258             push(@$outputArray, "        return throwVMError(exec, createTypeError(exec, \"Not enough arguments\"));\n");
    2259         }
     2255        push(@$outputArray, "        return throwVMError(exec, createTypeError(exec, \"Not enough arguments\"));\n");
    22602256    }
    22612257}

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r99962 r100163  
    14321432    if ($numMandatoryParams >= 1) {
    14331433        $argumentsCountCheckString .= "    if (args.Length() < $numMandatoryParams)\n";
    1434         if ($function->signature->extendedAttributes->{"RequiresAllArguments"}) {
    1435             $argumentsCountCheckString .= "        return v8::Handle<v8::Value>();\n";
    1436         } else {
    1437             $argumentsCountCheckString .= "        return throwError(\"Not enough arguments\", V8Proxy::TypeError);\n";
    1438         }
     1434        $argumentsCountCheckString .= "        return throwError(\"Not enough arguments\", V8Proxy::TypeError);\n";
    14391435    }
    14401436    return $argumentsCountCheckString;

  • trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp

    r95901 r100163  
    700700}
    701701
    702 WebDOMTestObj WebDOMTestObj::methodThatRequiresAllArgs(const WebDOMString& strArg, const WebDOMTestObj& objArg)
    703 {
    704     if (!impl())
    705         return WebDOMTestObj();
    706 
    707     return toWebKit(WTF::getPtr(impl()->methodThatRequiresAllArgs(strArg, toWebCore(objArg))));
    708 }
    709 
    710702WebDOMTestObj WebDOMTestObj::methodThatRequiresAllArgsAndThrows(const WebDOMString& strArg, const WebDOMTestObj& objArg)
    711703{

  • trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.h

    r99027 r100163  
    152152    WebDOMTestObj objMethod();
    153153    WebDOMTestObj objMethodWithArgs(int intArg, const WebDOMString& strArg, const WebDOMTestObj& objArg);
    154     WebDOMTestObj methodThatRequiresAllArgs(const WebDOMString& strArg, const WebDOMTestObj& objArg);
    155154    WebDOMTestObj methodThatRequiresAllArgsAndThrows(const WebDOMString& strArg, const WebDOMTestObj& objArg);
    156155    void serializedValue(const WebDOMString& serializedArg);

  • trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp

    r98715 r100163  
    137137    }
    138138    PassRefPtr<WebCore::TestObj> g_res = WTF::getPtr(item->objMethodWithArgs(int_arg, converted_str_arg, converted_obj_arg));
    139     WebKitDOMTestObj* res = WebKit::kit(g_res.get());
    140     return res;
    141 }
    142 
    143 WebKitDOMTestObj*
    144 webkit_dom_test_obj_method_that_requires_all_args(WebKitDOMTestObj* self, const gchar* str_arg, WebKitDOMTestObj* obj_arg)
    145 {
    146     g_return_val_if_fail(self, 0);
    147     WebCore::JSMainThreadNullState state;
    148     WebCore::TestObj * item = WebKit::core(self);
    149     g_return_val_if_fail(str_arg, 0);
    150     g_return_val_if_fail(obj_arg, 0);
    151     WTF::String converted_str_arg = WTF::String::fromUTF8(str_arg);
    152     WebCore::TestObj * converted_obj_arg = NULL;
    153     if (obj_arg != NULL) {
    154         converted_obj_arg = WebKit::core(obj_arg);
    155         g_return_val_if_fail(converted_obj_arg, 0);
    156     }
    157     PassRefPtr<WebCore::TestObj> g_res = WTF::getPtr(item->methodThatRequiresAllArgs(converted_str_arg, converted_obj_arg));
    158139    WebKitDOMTestObj* res = WebKit::kit(g_res.get());
    159140    return res;

  • trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h

    r95901 r100163  
    117117
    118118/**
    119  * webkit_dom_test_obj_method_that_requires_all_args:
    120  * @self: A #WebKitDOMTestObj
    121  * @str_arg: A #gchar
    122  * @obj_arg: A #WebKitDOMTestObj
    123  *
    124  * Returns: (transfer none):
    125  *
    126 **/
    127 WEBKIT_API WebKitDOMTestObj*
    128 webkit_dom_test_obj_method_that_requires_all_args(WebKitDOMTestObj* self, const gchar* str_arg, WebKitDOMTestObj* obj_arg);
    129 
    130 /**
    131119 * webkit_dom_test_obj_method_that_requires_all_args_and_throws:
    132120 * @self: A #WebKitDOMTestObj

  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp

    r100086 r100163  
    248248    { "objMethod", DontDelete | Function, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionObjMethod), (intptr_t)0 THUNK_GENERATOR(0) INTRINSIC(DFG::NoIntrinsic) },
    249249    { "objMethodWithArgs", DontDelete | Function, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionObjMethodWithArgs), (intptr_t)3 THUNK_GENERATOR(0) INTRINSIC(DFG::NoIntrinsic) },
    250     { "methodThatRequiresAllArgs", DontDelete | Function, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodThatRequiresAllArgs), (intptr_t)2 THUNK_GENERATOR(0) INTRINSIC(DFG::NoIntrinsic) },
    251250    { "methodThatRequiresAllArgsAndThrows", DontDelete | Function, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows), (intptr_t)2 THUNK_GENERATOR(0) INTRINSIC(DFG::NoIntrinsic) },
    252251    { "serializedValue", DontDelete | Function, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionSerializedValue), (intptr_t)1 THUNK_GENERATOR(0) INTRINSIC(DFG::NoIntrinsic) },
    … …  
    11501149}
    11511150
    1152 EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionMethodThatRequiresAllArgs(ExecState* exec)
    1153 {
    1154     JSValue thisValue = exec->hostThisValue();
    1155     if (!thisValue.inherits(&JSTestObj::s_info))
    1156         return throwVMTypeError(exec);
    1157     JSTestObj* castedThis = static_cast<JSTestObj*>(asObject(thisValue));
    1158     ASSERT_GC_OBJECT_INHERITS(castedThis, &JSTestObj::s_info);
    1159     TestObj* imp = static_cast<TestObj*>(castedThis->impl());
    1160     if (exec->argumentCount() < 2)
    1161         return JSValue::encode(jsUndefined());
    1162     const String& strArg(ustringToString(MAYBE_MISSING_PARAMETER(exec, 0, MissingIsUndefined).isEmpty() ? UString() : MAYBE_MISSING_PARAMETER(exec, 0, MissingIsUndefined).toString(exec)));
    1163     if (exec->hadException())
    1164         return JSValue::encode(jsUndefined());
    1165     TestObj* objArg(toTestObj(MAYBE_MISSING_PARAMETER(exec, 1, MissingIsUndefined)));
    1166     if (exec->hadException())
    1167         return JSValue::encode(jsUndefined());
    1168 
    1169     JSC::JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(imp->methodThatRequiresAllArgs(strArg, objArg)));
    1170     return JSValue::encode(result);
    1171 }
    1172 
    11731151EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows(ExecState* exec)
    11741152{

  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h

    r99754 r100163  
    137137JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionObjMethod(JSC::ExecState*);
    138138JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionObjMethodWithArgs(JSC::ExecState*);
    139 JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionMethodThatRequiresAllArgs(JSC::ExecState*);
    140139JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows(JSC::ExecState*);
    141140JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionSerializedValue(JSC::ExecState*);

  • trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h

    r99027 r100163  
    143143- (DOMTestObj *)objMethod;
    144144- (DOMTestObj *)objMethodWithArgs:(int)intArg strArg:(NSString *)strArg objArg:(DOMTestObj *)objArg;
    145 - (DOMTestObj *)methodThatRequiresAllArgs:(NSString *)strArg objArg:(DOMTestObj *)objArg;
    146145- (DOMTestObj *)methodThatRequiresAllArgsAndThrows:(NSString *)strArg objArg:(DOMTestObj *)objArg;
    147146- (void)serializedValue:(NSString *)serializedArg;

  • trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm

    r95901 r100163  
    575575}
    576576
    577 - (DOMTestObj *)methodThatRequiresAllArgs:(NSString *)strArg objArg:(DOMTestObj *)objArg
    578 {
    579     WebCore::JSMainThreadNullState state;
    580     return kit(WTF::getPtr(IMPL->methodThatRequiresAllArgs(strArg, core(objArg))));
    581 }
    582 
    583577- (DOMTestObj *)methodThatRequiresAllArgsAndThrows:(NSString *)strArg objArg:(DOMTestObj *)objArg
    584578{

  • trunk/Source/WebCore/bindings/scripts/test/TestObj.idl

    r99632 r100163  
    7272        TestObj objMethodWithArgs(in long intArg, in DOMString strArg, in TestObj objArg);
    7373
    74         [RequiresAllArguments] TestObj methodThatRequiresAllArgs(in DOMString strArg, in TestObj objArg);
    7574        TestObj methodThatRequiresAllArgsAndThrows(in DOMString strArg, in TestObj objArg)
    7675            raises(DOMException);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp

    r99732 r100163  
    771771    EXCEPTION_BLOCK(TestObj*, objArg, V8TestObj::HasInstance(MAYBE_MISSING_PARAMETER(args, 2, MissingIsUndefined)) ? V8TestObj::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 2, MissingIsUndefined))) : 0);
    772772    return toV8(imp->objMethodWithArgs(intArg, strArg, objArg));
    773 }
    774 
    775 static v8::Handle<v8::Value> methodThatRequiresAllArgsCallback(const v8::Arguments& args)
    776 {
    777     INC_STATS("DOM.TestObj.methodThatRequiresAllArgs");
    778     if (args.Length() < 2)
    779         return v8::Handle<v8::Value>();
    780     TestObj* imp = V8TestObj::toNative(args.Holder());
    781     STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, strArg, MAYBE_MISSING_PARAMETER(args, 0, MissingIsUndefined));
    782     EXCEPTION_BLOCK(TestObj*, objArg, V8TestObj::HasInstance(MAYBE_MISSING_PARAMETER(args, 1, MissingIsUndefined)) ? V8TestObj::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 1, MissingIsUndefined))) : 0);
    783     return toV8(imp->methodThatRequiresAllArgs(strArg, objArg));
    784773}
    785774
    … …  
    15541543    proto->Set(v8::String::New("objMethodWithArgs"), v8::FunctionTemplate::New(TestObjInternal::objMethodWithArgsCallback, v8::Handle<v8::Value>(), objMethodWithArgsSignature));
    15551544
    1556     // Custom Signature 'methodThatRequiresAllArgs'
    1557     const int methodThatRequiresAllArgsArgc = 2;
    1558     v8::Handle<v8::FunctionTemplate> methodThatRequiresAllArgsArgv[methodThatRequiresAllArgsArgc] = { v8::Handle<v8::FunctionTemplate>(), V8TestObj::GetRawTemplate() };
    1559     v8::Handle<v8::Signature> methodThatRequiresAllArgsSignature = v8::Signature::New(desc, methodThatRequiresAllArgsArgc, methodThatRequiresAllArgsArgv);
    1560     proto->Set(v8::String::New("methodThatRequiresAllArgs"), v8::FunctionTemplate::New(TestObjInternal::methodThatRequiresAllArgsCallback, v8::Handle<v8::Value>(), methodThatRequiresAllArgsSignature));
    1561 
    15621545    // Custom Signature 'methodThatRequiresAllArgsAndThrows'
    15631546    const int methodThatRequiresAllArgsAndThrowsArgc = 2;

  • trunk/Source/WebCore/dom/Clipboard.idl

    r98821 r100163  
    3939        [Custom] void getData(in DOMString type)
    4040            raises(DOMException);
    41         // FIXME: RequiresAllArguments is probably bogus here.
    42         [RequiresAllArguments] boolean setData(in DOMString type, in DOMString data);
     41        boolean setData(in DOMString type, in DOMString data);
    4342        [Custom] void setDragImage(in HTMLImageElement image, in long x, in long y)
    4443            raises(DOMException);

  • trunk/Source/WebCore/page/DOMWindow.idl

    r100159 r100163  
    107107        readonly attribute long pageYOffset;
    108108
    109         [RequiresAllArguments] void scrollBy(in long x, in long y);
    110         [RequiresAllArguments] void scrollTo(in long x, in long y);
    111         [RequiresAllArguments] void scroll(in long x, in long y);
    112         [RequiresAllArguments] void moveBy(in float x, in float y); // FIXME: this should take longs not floats.
    113         [RequiresAllArguments] void moveTo(in float x, in float y); // FIXME: this should take longs not floats.
    114         [RequiresAllArguments] void resizeBy(in float x, in float y); // FIXME: this should take longs not floats.
    115         [RequiresAllArguments] void resizeTo(in float width, in float height); // FIXME: this should take longs not floats.
     109        void scrollBy(in [Optional=CallWithDefaultValue] long x, in [Optional=CallWithDefaultValue] long y);
     110        void scrollTo(in [Optional=CallWithDefaultValue] long x, in [Optional=CallWithDefaultValue] long y);
     111        void scroll(in [Optional=CallWithDefaultValue] long x, in [Optional=CallWithDefaultValue] long y);
     112        void moveBy(in [Optional=CallWithDefaultValue] float x, in [Optional=CallWithDefaultValue] float y); // FIXME: this should take longs not floats.
     113        void moveTo(in [Optional=CallWithDefaultValue] float x, in [Optional=CallWithDefaultValue] float y); // FIXME: this should take longs not floats.
     114        void resizeBy(in [Optional=CallWithDefaultValue] float x, in [Optional=CallWithDefaultValue] float y); // FIXME: this should take longs not floats.
     115        void resizeTo(in [Optional=CallWithDefaultValue] float width, in [Optional=CallWithDefaultValue] float height); // FIXME: this should take longs not floats.
    116116
    117117        readonly attribute [DoNotCheckDomainSecurity] boolean closed;

  • trunk/Source/WebCore/websockets/WebSocket.idl

    r99732 r100163  
    6868        // booleans, null, undefined and objects except ArrayBuffer and Blob). Current code
    6969        // generator does not handle this rule correctly.
    70         // [RequiresAllArguments] boolean send(in ArrayBuffer data) raises(DOMException);
    71         // [RequiresAllArguments] boolean send(in Blob data) raises(DOMException);
    72         // [RequiresAllArguments] boolean send(in DOMString data) raises(DOMException);
     70        // boolean send(in ArrayBuffer data) raises(DOMException);
     71        // boolean send(in Blob data) raises(DOMException);
     72        // boolean send(in DOMString data) raises(DOMException);
    7373        [Custom] boolean send(in DOMString data) raises(DOMException);
    7474
Note: See TracChangeset for help on using the changeset viewer.