Changeset 100222 in webkit

Timestamp:

Nov 14, 2011 5:23:35 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[MutationObservers] Add histogram collection for usage of DOM Mutation Events
​https://bugs.webkit.org/show_bug.cgi?id=72316

Patch by Rafael Weinstein <​rafaelw@chromium.org> on 2011-11-14
Reviewed by Ryosuke Niwa.

This patch adds six calls in ~Document() which simply pipe-out to the embedder
the (already-collected) bits of whether varous DOM Mutation Events were registered
on the document.

No tests needed. No functional changes.

• dom/Document.cpp:

(WebCore::histogramMutationEventUsage):
(WebCore::Document::~Document):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-14  Rafael Weinstein  <rafaelw@chromium.org>
+
+        [MutationObservers] Add histogram collection for usage of DOM Mutation Events
+        https://bugs.webkit.org/show_bug.cgi?id=72316
+
+        Reviewed by Ryosuke Niwa.
+
+        This patch adds six calls in ~Document() which simply pipe-out to the embedder
+        the (already-collected) bits of whether varous DOM Mutation Events were registered
+        on the document.
+
+        No tests needed. No functional changes.
+
+        * dom/Document.cpp:
+        (WebCore::histogramMutationEventUsage):
+        (WebCore::Document::~Document):
+
 2011-11-14  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -158 +158 @@
 #include <wtf/text/StringBuffer.h>
 
+#if PLATFORM(CHROMIUM)
+#include "PlatformSupport.h"
+#endif
+
 #if ENABLE(SHARED_WORKERS)
 #include "SharedWorkerRepository.h"
@@ -494 +498 @@
 }
 
+#if PLATFORM(CHROMIUM)
+static void histogramMutationEventUsage(const unsigned short& listenerTypes)
+{
+    PlatformSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMSubtreeModified", static_cast<bool>(listenerTypes & Document::DOMSUBTREEMODIFIED_LISTENER), 2);
+    PlatformSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMNodeInserted", static_cast<bool>(listenerTypes & Document::DOMNODEINSERTED_LISTENER), 2);
+    PlatformSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMNodeRemoved", static_cast<bool>(listenerTypes & Document::DOMNODEREMOVED_LISTENER), 2);
+    PlatformSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMNodeRemovedFromDocument", static_cast<bool>(listenerTypes & Document::DOMNODEREMOVEDFROMDOCUMENT_LISTENER), 2);
+    PlatformSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMNodeInsertedIntoDocument", static_cast<bool>(listenerTypes & Document::DOMNODEINSERTEDINTODOCUMENT_LISTENER), 2);
+    PlatformSupport::histogramEnumeration("DOMAPI.PerDocumentMutationEventUsage.DOMCharacterDataModified", static_cast<bool>(listenerTypes & Document::DOMCHARACTERDATAMODIFIED_LISTENER), 2);
+}
+#endif
+
 Document::~Document()
 {
@@ -505 +521 @@
 
     m_scriptRunner.clear();
+
+#if PLATFORM(CHROMIUM)
+    histogramMutationEventUsage(m_listenerTypes);
+#endif
 
     removeAllEventListeners();