Changeset 100280 in webkit

Timestamp:

Nov 15, 2011 7:38:09 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Fix SVG hit testing when padding is present
​https://bugs.webkit.org/show_bug.cgi?id=37325

Patch by Philip Rogers <​pdr@google.com> on 2011-11-15
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/hittest/svg-padding.xhtml

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

• svg/hittest/svg-padding-expected.txt: Added.
• svg/hittest/svg-padding.xhtml: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/hittest/svg-padding-expected.txt (added)
• LayoutTests/svg/hittest/svg-padding.xhtml (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGRoot.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-11-15  Philip Rogers  <pdr@google.com>
+
+        Fix SVG hit testing when padding is present
+        https://bugs.webkit.org/show_bug.cgi?id=37325
+
+        Reviewed by Nikolas Zimmermann.
+
+        * svg/hittest/svg-padding-expected.txt: Added.
+        * svg/hittest/svg-padding.xhtml: Added.
+
 2011-11-15  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-15  Philip Rogers  <pdr@google.com>
+
+        Fix SVG hit testing when padding is present
+        https://bugs.webkit.org/show_bug.cgi?id=37325
+
+        Reviewed by Nikolas Zimmermann.
+
+        Test: svg/hittest/svg-padding.xhtml
+
+        * rendering/svg/RenderSVGRoot.cpp:
+        (WebCore::RenderSVGRoot::nodeAtPoint):
+
 2011-11-15  Pavel Feldman  <pfeldman@google.com>
 

trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp

@@ -435 +435 @@
 
     // Note: For now, we're ignoring hits to border and padding for <svg>
-    LayoutPoint pointInContentBox = pointInBorderBox - borderOriginToContentBox();
-    if (!contentBoxRect().contains(pointInContentBox))
+    if (!contentBoxRect().contains(pointInBorderBox))
         return false;