Changeset 100287 in webkit


Ignore:
Timestamp:
Nov 15, 2011 9:25:51 AM (12 years ago)
Author:
ddkilzer@apple.com
Message:

Don't use File::Slurp for run-leaks unit tests
<http://webkit.org/b/72356>

Reviewed by Daniel Bates.

  • Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:

Extracted common package logic into RunLeaks.pm. Fixed call to
RunLeaks::parseLeaksOutput().

  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
  • Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
Location:
trunk/Tools
Files:
1 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r100286 r100287  
     12011-11-15  David Kilzer  <ddkilzer@apple.com>
     2
     3        Don't use File::Slurp for run-leaks unit tests
     4        <http://webkit.org/b/72356>
     5
     6        Reviewed by Daniel Bates.
     7
     8        * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
     9        * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
     10        Extracted common package logic into RunLeaks.pm.  Fixed call to
     11        RunLeaks::parseLeaksOutput().
     12        * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
     13        * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
     14
    1152011-11-15  Peter Kasting  <pkasting@google.com>
    216
  • trunk/Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl

    r100174 r100287  
    2626
    2727use strict;
    28 use diagnostics;
    2928use warnings;
    3029
    31 use File::Slurp qw(read_file);
    32 use File::Spec;
    3330use FindBin;
     31use lib $FindBin::Bin;
     32use RunLeaks;
    3433use Test::More;
    35 
    36 eval "package RunLeaks; sub {" . read_file(File::Spec->catfile($FindBin::Bin, "..", "..", "run-leaks")) . "}";
    3734
    3835my @input = split(/\n/, <<EOF);
     
    159156];
    160157
    161 my $actualOutput = RunLeaks::parseLeaksOutput(\@input);
     158my $actualOutput = RunLeaks::parseLeaksOutput(@input);
    162159
    163160plan(tests => 1);
  • trunk/Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl

    r100174 r100287  
    2727
    2828use strict;
    29 use diagnostics;
    3029use warnings;
    3130
    32 use File::Slurp qw(read_file);
    33 use File::Spec;
    3431use FindBin;
     32use lib $FindBin::Bin;
     33use RunLeaks;
    3534use Test::More;
    36 
    37 eval "package RunLeaks; sub {" . read_file(File::Spec->catfile($FindBin::Bin, "..", "..", "run-leaks")) . "}";
    3835
    3936my @input = split(/\n/, <<EOF);
     
    123120];
    124121
    125 my $actualOutput = RunLeaks::parseLeaksOutput(\@input);
     122my $actualOutput = RunLeaks::parseLeaksOutput(@input);
    126123
    127124plan(tests => 1);
  • trunk/Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl

    r100174 r100287  
    2727
    2828use strict;
    29 use diagnostics;
    3029use warnings;
    3130
    32 use File::Slurp qw(read_file);
    33 use File::Spec;
    3431use FindBin;
     32use lib $FindBin::Bin;
     33use RunLeaks;
    3534use Test::More;
    36 
    37 eval "package RunLeaks; sub {" . read_file(File::Spec->catfile($FindBin::Bin, "..", "..", "run-leaks")) . "}";
    3835
    3936my @input = split(/\n/, <<EOF);
     
    7370];
    7471
    75 my $actualOutput = RunLeaks::parseLeaksOutput(\@input);
     72my $actualOutput = RunLeaks::parseLeaksOutput(@input);
    7673
    7774plan(tests => 1);
Note: See TracChangeset for help on using the changeset viewer.