Changeset 100805 in webkit


Ignore:
Timestamp:
Nov 18, 2011 1:19:14 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Access key should work on all elements.
​https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <​vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Ryosuke Niwa.

Source/WebCore:

All HTML elements can have the accesskey content attribute set.
Specification ​http://dev.w3.org/html5/spec/Overview.html#the-accesskey-attribute
Adding "accessKey" attribute to HTMLElement.idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

  • bindings/objc/PublicDOMInterfaces.h: Moved properties form subclass to base class.
  • html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/BaseButtonInputType.h: Ditto
  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::accessKeyAction): Ditto

  • html/BaseCheckableInputType.h: Ditto
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::accessKeyAction): Ditto

  • html/HTMLAnchorElement.h: Ditto
  • html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLAreaElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLButtonElement.h: Ditto
  • html/HTMLButtonElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
If the element does not have a defined activation behavior, fire a click event at the element.

  • html/HTMLElement.h: Ditto
  • html/HTMLElement.idl: Added accessKey IDL attribute.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLInputElement.h: Ditto
  • html/HTMLInputElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLLabelElement.h: Ditto
  • html/HTMLLabelElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.

  • html/HTMLLegendElement.h: Ditto
  • html/HTMLLegendElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLOptGroupElement.h: Renamed variable sendToAnyElement to sendMouseEvents.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::accessKeyAction): Ditto

  • html/HTMLSelectElement.h: Ditto
  • html/HTMLTextAreaElement.h: Ditto
  • html/HTMLTextAreaElement.idl: Removed redundant IDL attribute entries.
  • html/HiddenInputType.h: Renamed variable sendToAnyElement to sendMouseEvents.
  • html/InputType.h: Ditto
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::accessKeyAction): Ditto

  • html/RangeInputType.h: Ditto

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

  • fast/forms/access-key-expected.txt:
  • fast/forms/access-key-for-all-elements-expected.txt: Added.
  • fast/forms/access-key-for-all-elements.html: Added.
  • fast/forms/access-key.html: Added more test coverage for select and textarea elements.
Location:
trunk
Files:
2 added
37 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r100804 r100805  
     12011-11-18  Vineet Chaudhary  <vineet.chaudhary@motorola.com>
     2
     3        Access key should work on all elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=71854
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Added test case to check whether all elements can also have accessKey attribute.
     9
     10        * fast/forms/access-key-expected.txt:
     11        * fast/forms/access-key-for-all-elements-expected.txt: Added.
     12        * fast/forms/access-key-for-all-elements.html: Added.
     13        * fast/forms/access-key.html: Added more test coverage for select and textarea elements.
     14
    1152011-11-18  Adam Klein  <adamk@chromium.org>
    216

  • trunk/LayoutTests/fast/forms/access-key-expected.txt

    r27599 r100805  
    66
    77
    8    
     8    
    991 button focussed
    10101 button clicked
    … …  
    2424b area 1 clicked
    2525c area 2 clicked
     26d select focussed
     27d select clicked
     28e textarea focussed

  • trunk/LayoutTests/fast/forms/access-key.html

    r34259 r100805  
    2626        pressKey("b");
    2727        pressKey("c");
     28        pressKey("d");
     29        pressKey("e");
    2830    }
    2931}
    … …  
    5052</map>
    5153<img usemap="#mymap" alt="pic" src="#" height="10" width="10">
     54<select accesskey="d" onfocus="log('d select focussed')" onclick="log('d select clicked')"></select>
     55<textarea accesskey="e" onfocus="log('e textarea focussed')" onclick="log('e textarea clicked')"></textarea>
    5256</p>
    5357<hr>

  • trunk/Source/WebCore/ChangeLog

    r100800 r100805  
     12011-11-18  Vineet Chaudhary  <vineet.chaudhary@motorola.com>
     2
     3        Access key should work on all elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=71854
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        All HTML elements can have the accesskey content attribute set.
     9        Specification http://dev.w3.org/html5/spec/Overview.html#the-accesskey-attribute
     10        Adding "accessKey" attribute to HTMLElement.idl file as [Reflect].
     11
     12        Test: fast/forms/access-key-for-all-elements.html
     13
     14        * bindings/objc/PublicDOMInterfaces.h: Moved properties form subclass to base class.
     15        * html/BaseButtonInputType.cpp:
     16        (WebCore::BaseButtonInputType::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
     17        * html/BaseButtonInputType.h: Ditto
     18        * html/BaseCheckableInputType.cpp:
     19        (WebCore::BaseCheckableInputType::accessKeyAction): Ditto
     20        * html/BaseCheckableInputType.h: Ditto
     21        * html/HTMLAnchorElement.cpp:
     22        (WebCore::HTMLAnchorElement::accessKeyAction): Ditto
     23        * html/HTMLAnchorElement.h: Ditto
     24        * html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
     25        * html/HTMLAreaElement.idl: Removed redundant IDL attribute entries.
     26        * html/HTMLButtonElement.cpp:
     27        (WebCore::HTMLButtonElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
     28        * html/HTMLButtonElement.h: Ditto
     29        * html/HTMLButtonElement.idl: Removed redundant IDL attribute entries.
     30        * html/HTMLElement.cpp:
     31        (WebCore::HTMLElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
     32        If the element does not have a defined activation behavior, fire a click event at the element.
     33        * html/HTMLElement.h: Ditto
     34        * html/HTMLElement.idl: Added accessKey IDL attribute.
     35        * html/HTMLInputElement.cpp:
     36        (WebCore::HTMLInputElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
     37        * html/HTMLInputElement.h: Ditto
     38        * html/HTMLInputElement.idl: Removed redundant IDL attribute entries.
     39        * html/HTMLLabelElement.cpp:
     40        (WebCore::HTMLLabelElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
     41        * html/HTMLLabelElement.h: Ditto
     42        * html/HTMLLabelElement.idl: Removed redundant IDL attribute entries.
     43        * html/HTMLLegendElement.cpp:
     44        (WebCore::HTMLLegendElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
     45        * html/HTMLLegendElement.h: Ditto
     46        * html/HTMLLegendElement.idl: Removed redundant IDL attribute entries.
     47        * html/HTMLOptGroupElement.h: Renamed variable sendToAnyElement to sendMouseEvents.
     48        * html/HTMLSelectElement.cpp:
     49        (WebCore::HTMLSelectElement::accessKeyAction): Ditto
     50        * html/HTMLSelectElement.h: Ditto
     51        * html/HTMLTextAreaElement.h: Ditto
     52        * html/HTMLTextAreaElement.idl: Removed redundant IDL attribute entries.
     53        * html/HiddenInputType.h: Renamed variable sendToAnyElement to sendMouseEvents.
     54        * html/InputType.h: Ditto
     55        * html/RangeInputType.cpp:
     56        (WebCore::RangeInputType::accessKeyAction): Ditto
     57        * html/RangeInputType.h: Ditto
     58
    1592011-11-18  Simon Fraser  <simon.fraser@apple.com>
    260

  • trunk/Source/WebCore/bindings/objc/PublicDOMInterfaces.h

    r97771 r100805  
    332332
    333333@interface DOMHTMLAnchorElement : DOMHTMLElement WEBKIT_VERSION_1_3
    334 @property(copy) NSString *accessKey;
    335334@property(copy) NSString *charset;
    336335@property(copy) NSString *coords;
    … …  
    369368
    370369@interface DOMHTMLAreaElement : DOMHTMLElement WEBKIT_VERSION_1_3
    371 @property(copy) NSString *accessKey;
    372370@property(copy) NSString *alt;
    373371@property(copy) NSString *coords;
    … …  
    412410@interface DOMHTMLButtonElement : DOMHTMLElement WEBKIT_VERSION_1_3
    413411@property(readonly, retain) DOMHTMLFormElement *form;
    414 @property(copy) NSString *accessKey;
    415412@property BOOL disabled;
    416413@property(copy) NSString *name;
    … …  
    472469
    473470@interface DOMHTMLElement : DOMElement WEBKIT_VERSION_1_3
     471@property(copy) NSString *accessKey;
    474472@property(copy) NSString *title;
    475473@property(copy) NSString *idName;
    … …  
    604602@property(readonly, retain) DOMHTMLFormElement *form;
    605603@property(copy) NSString *accept;
    606 @property(copy) NSString *accessKey;
    607604@property(copy) NSString *align;
    608605@property(copy) NSString *alt;
    … …  
    643640@interface DOMHTMLLabelElement : DOMHTMLElement WEBKIT_VERSION_1_3
    644641@property(readonly, retain) DOMHTMLFormElement *form;
    645 @property(copy) NSString *accessKey;
    646642@property(copy) NSString *htmlFor;
    647643@end
    … …  
    649645@interface DOMHTMLLegendElement : DOMHTMLElement WEBKIT_VERSION_1_3
    650646@property(readonly, retain) DOMHTMLFormElement *form;
    651 @property(copy) NSString *accessKey;
    652647@property(copy) NSString *align;
    653648@end
    … …  
    885880@property(copy) NSString *defaultValue;
    886881@property(readonly, retain) DOMHTMLFormElement *form;
    887 @property(copy) NSString *accessKey;
    888882@property int cols;
    889883@property BOOL disabled;

  • trunk/Source/WebCore/html/BaseButtonInputType.cpp

    r95901 r100805  
    8787
    8888// FIXME: Could share this with BaseCheckableInputType and RangeInputType if we had a common base class.
    89 void BaseButtonInputType::accessKeyAction(bool sendToAnyElement)
     89void BaseButtonInputType::accessKeyAction(bool sendMouseEvents)
    9090{
    91     InputType::accessKeyAction(sendToAnyElement);
     91    InputType::accessKeyAction(sendMouseEvents);
    9292
    93     // Send mouse button events if the caller specified sendToAnyElement.
     93    // Send mouse button events if the caller specified sendMouseEvents.
    9494    // FIXME: The comment above is no good. It says what we do, but not why.
    95     element()->dispatchSimulatedClick(0, sendToAnyElement);
     95    element()->dispatchSimulatedClick(0, sendMouseEvents);
    9696}
    9797

  • trunk/Source/WebCore/html/BaseButtonInputType.h

    r95901 r100805  
    4747    virtual void handleKeyupEvent(KeyboardEvent*);
    4848    virtual RenderObject* createRenderer(RenderArena*, RenderStyle*) const;
    49     virtual void accessKeyAction(bool sendToAnyElement);
     49    virtual void accessKeyAction(bool sendMouseEvents);
    5050    virtual bool storesValueSeparateFromAttribute();
    5151    virtual void setValue(const String&, bool, bool);

  • trunk/Source/WebCore/html/BaseCheckableInputType.cpp

    r99395 r100805  
    8686
    8787// FIXME: Could share this with BaseButtonInputType and RangeInputType if we had a common base class.
    88 void BaseCheckableInputType::accessKeyAction(bool sendToAnyElement)
     88void BaseCheckableInputType::accessKeyAction(bool sendMouseEvents)
    8989{
    90     InputType::accessKeyAction(sendToAnyElement);
     90    InputType::accessKeyAction(sendMouseEvents);
    9191
    92     // Send mouse button events if the caller specified sendToAnyElement.
     92    // Send mouse button events if the caller specified sendMouseEvents.
    9393    // FIXME: The comment above is no good. It says what we do, but not why.
    94     element()->dispatchSimulatedClick(0, sendToAnyElement);
     94    element()->dispatchSimulatedClick(0, sendMouseEvents);
    9595}
    9696

  • trunk/Source/WebCore/html/BaseCheckableInputType.h

    r99395 r100805  
    4848    virtual void handleKeypressEvent(KeyboardEvent*);
    4949    virtual bool canSetStringValue() const;
    50     virtual void accessKeyAction(bool sendToAnyElement);
     50    virtual void accessKeyAction(bool sendMouseEvents);
    5151    virtual String fallbackValue() const OVERRIDE;
    5252    virtual bool storesValueSeparateFromAttribute();

  • trunk/Source/WebCore/html/HTMLAnchorElement.cpp

    r100353 r100805  
    231231}
    232232
    233 void HTMLAnchorElement::accessKeyAction(bool sendToAnyElement)
    234 {
    235     // send the mouse button events if the caller specified sendToAnyElement
    236     dispatchSimulatedClick(0, sendToAnyElement);
     233void HTMLAnchorElement::accessKeyAction(bool sendMouseEvents)
     234{
     235    // send the mouse button events if the caller specified sendMouseEvents
     236    dispatchSimulatedClick(0, sendMouseEvents);
    237237}
    238238

  • trunk/Source/WebCore/html/HTMLAnchorElement.h

    r100164 r100805  
    105105    virtual void defaultEventHandler(Event*);
    106106    virtual void setActive(bool active = true, bool pause = false);
    107     virtual void accessKeyAction(bool fullAction);
     107    virtual void accessKeyAction(bool sendMouseEvents);
    108108    virtual bool isURLAttribute(Attribute*) const;
    109109    virtual bool canStartSelection() const;

  • trunk/Source/WebCore/html/HTMLAnchorElement.idl

    r100164 r100805  
    2222
    2323    interface HTMLAnchorElement : HTMLElement {
    24         attribute [Reflect] DOMString accessKey;
    2524        attribute [Reflect] DOMString charset;
    2625        attribute [Reflect] DOMString coords;

  • trunk/Source/WebCore/html/HTMLAreaElement.idl

    r100076 r100805  
    2222
    2323    interface HTMLAreaElement : HTMLElement {
    24         attribute [Reflect] DOMString accessKey;
    2524        attribute [Reflect] DOMString alt;
    2625        attribute [Reflect] DOMString coords;

  • trunk/Source/WebCore/html/HTMLButtonElement.cpp

    r99742 r100805  
    163163}
    164164
    165 void HTMLButtonElement::accessKeyAction(bool sendToAnyElement)
     165void HTMLButtonElement::accessKeyAction(bool sendMouseEvents)
    166166{
    167167    focus();
    168     // send the mouse button events iff the caller specified sendToAnyElement
    169     dispatchSimulatedClick(0, sendToAnyElement);
     168    // Send the mouse button events if the caller specified sendMouseEvents
     169    dispatchSimulatedClick(0, sendMouseEvents);
    170170}
    171171

  • trunk/Source/WebCore/html/HTMLButtonElement.h

    r78232 r100805  
    5454    virtual void setActivatedSubmit(bool flag);
    5555
    56     virtual void accessKeyAction(bool sendToAnyElement);
     56    virtual void accessKeyAction(bool sendMouseEvents);
    5757    virtual bool isURLAttribute(Attribute*) const;
    5858

  • trunk/Source/WebCore/html/HTMLButtonElement.idl

    r100076 r100805  
    3131        readonly attribute ValidityState validity;
    3232
    33         attribute [Reflect] DOMString accessKey;
    3433        attribute [Reflect] boolean disabled;
    3534        attribute [Reflect] boolean autofocus;

  • trunk/Source/WebCore/html/HTMLElement.cpp

    r99742 r100805  
    775775}
    776776
    777 // accessKeyAction is used by the accessibility support code
    778 // to send events to elements that our JavaScript caller does
    779 // does not.  The elements JS is interested in have subclasses
    780 // that override this method to direct the click appropriately.
    781 // Here in the base class, then, we only send the click if
    782 // the caller wants it to go to any HTMLElement, and we say
    783 // to send the mouse events in addition to the click.
    784 void HTMLElement::accessKeyAction(bool sendToAnyElement)
    785 {
    786     if (sendToAnyElement)
    787         dispatchSimulatedClick(0, true);
     777void HTMLElement::accessKeyAction(bool sendMouseEvents)
     778{
     779    dispatchSimulatedClick(0, sendMouseEvents);
    788780}
    789781

  • trunk/Source/WebCore/html/HTMLElement.h

    r99742 r100805  
    7575    void click();
    7676
    77     virtual void accessKeyAction(bool sendToAnyElement);
     77    virtual void accessKeyAction(bool sendMouseEvents);
    7878
    7979    bool ieForbidsInsertHTML() const;

  • trunk/Source/WebCore/html/HTMLElement.idl

    r100076 r100805  
    3838                 attribute [Reflect] DOMString webkitdropzone;
    3939                 attribute [Reflect] boolean hidden;
     40                 attribute [Reflect] DOMString accessKey;
    4041
    4142        // Extensions

  • trunk/Source/WebCore/html/HTMLInputElement.cpp

    r99742 r100805  
    700700}
    701701
    702 void HTMLInputElement::accessKeyAction(bool sendToAnyElement)
    703 {
    704     m_inputType->accessKeyAction(sendToAnyElement);
     702void HTMLInputElement::accessKeyAction(bool sendMouseEvents)
     703{
     704    m_inputType->accessKeyAction(sendMouseEvents);
    705705}
    706706

  • trunk/Source/WebCore/html/HTMLInputElement.h

    r99403 r100805  
    273273    virtual bool canStartSelection() const;
    274274
    275     virtual void accessKeyAction(bool sendToAnyElement);
     275    virtual void accessKeyAction(bool sendMouseEvents);
    276276
    277277    virtual bool mapToEntry(const QualifiedName& attrName, MappedAttributeEntry& result) const;

  • trunk/Source/WebCore/html/HTMLInputElement.idl

    r100076 r100805  
    3232        readonly attribute ValidityState validity;
    3333        attribute [Reflect] DOMString accept;
    34         attribute [Reflect] DOMString accessKey;
    3534        attribute [Reflect] DOMString align;
    3635        attribute [Reflect] DOMString alt;

  • trunk/Source/WebCore/html/HTMLLabelElement.cpp

    r94427 r100805  
    147147}
    148148
    149 void HTMLLabelElement::accessKeyAction(bool sendToAnyElement)
     149void HTMLLabelElement::accessKeyAction(bool sendMouseEvents)
    150150{
    151151    if (HTMLElement* element = control())
    152         element->accessKeyAction(sendToAnyElement);
     152        element->accessKeyAction(sendMouseEvents);
    153153    else
    154         HTMLElement::accessKeyAction(sendToAnyElement);
     154        HTMLElement::accessKeyAction(sendMouseEvents);
    155155}
    156156

  • trunk/Source/WebCore/html/HTMLLabelElement.h

    r65982 r100805  
    4141    virtual bool isFocusable() const;
    4242
    43     virtual void accessKeyAction(bool sendToAnyElement);
     43    virtual void accessKeyAction(bool sendMouseEvents);
    4444
    4545    // Overridden to update the hover/active state of the corresponding control.

  • trunk/Source/WebCore/html/HTMLLabelElement.idl

    r100076 r100805  
    2323    interface HTMLLabelElement : HTMLElement {
    2424        readonly attribute HTMLFormElement form;
    25         attribute [Reflect] DOMString accessKey;
    2625        attribute [Reflect=for] DOMString htmlFor;
    2726        readonly attribute HTMLElement control;

  • trunk/Source/WebCore/html/HTMLLegendElement.cpp

    r69868 r100805  
    8888}
    8989
    90 void HTMLLegendElement::accessKeyAction(bool sendToAnyElement)
     90void HTMLLegendElement::accessKeyAction(bool sendMouseEvents)
    9191{
    9292    if (HTMLFormControlElement* control = associatedControl())
    93         control->accessKeyAction(sendToAnyElement);
     93        control->accessKeyAction(sendMouseEvents);
    9494}
    9595   

  • trunk/Source/WebCore/html/HTMLLegendElement.h

    r61959 r100805  
    4141    virtual bool supportsFocus() const;
    4242    virtual const AtomicString& formControlType() const;
    43     virtual void accessKeyAction(bool sendToAnyElement);
     43    virtual void accessKeyAction(bool sendMouseEvents);
    4444    virtual void focus(bool restorePreviousSelection = true);
    4545};

  • trunk/Source/WebCore/html/HTMLLegendElement.idl

    r100076 r100805  
    2323    interface HTMLLegendElement : HTMLElement {
    2424        readonly attribute HTMLFormElement form;
    25         attribute [Reflect] DOMString accessKey;
    2625        attribute [Reflect] DOMString align;
    2726    };

  • trunk/Source/WebCore/html/HTMLOptGroupElement.h

    r97720 r100805  
    5353    virtual void childrenChanged(bool changedByParser = false, Node* beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0);
    5454
    55     virtual void accessKeyAction(bool sendToAnyElement);
     55    virtual void accessKeyAction(bool sendMouseEvents);
    5656   
    5757    virtual RenderStyle* nonRendererRenderStyle() const;

  • trunk/Source/WebCore/html/HTMLSelectElement.cpp

    r100111 r100805  
    348348}
    349349
    350 void HTMLSelectElement::accessKeyAction(bool sendToAnyElement)
     350void HTMLSelectElement::accessKeyAction(bool sendMouseEvents)
    351351{
    352352    focus();
    353     dispatchSimulatedClick(0, sendToAnyElement);
     353    dispatchSimulatedClick(0, sendMouseEvents);
    354354}
    355355

  • trunk/Source/WebCore/html/HTMLSelectElement.h

    r100123 r100805  
    7575    const Vector<HTMLElement*>& listItems() const;
    7676
    77     virtual void accessKeyAction(bool sendToAnyElement);
     77    virtual void accessKeyAction(bool sendMouseEvents);
    7878    void accessKeySetSelectedIndex(int);
    7979

  • trunk/Source/WebCore/html/HTMLTextAreaElement.h

    r94047 r100805  
    102102    virtual void updateFocusAppearance(bool restorePreviousSelection);
    103103
    104     virtual void accessKeyAction(bool sendToAnyElement);
     104    virtual void accessKeyAction(bool sendMouseEvents);
    105105
    106106    virtual bool shouldUseInputMethod();

  • trunk/Source/WebCore/html/HTMLTextAreaElement.idl

    r100076 r100805  
    2626        readonly attribute HTMLFormElement form;
    2727        readonly attribute ValidityState validity;
    28         attribute [Reflect] DOMString accessKey;
    2928        attribute long cols;
    3029        attribute [Reflect] boolean disabled;

  • trunk/Source/WebCore/html/HiddenInputType.h

    r99310 r100805  
    4545    virtual bool supportsValidation() const;
    4646    virtual RenderObject* createRenderer(RenderArena*, RenderStyle*) const;
    47     virtual void accessKeyAction(bool sendToAnyElement);
     47    virtual void accessKeyAction(bool sendMouseEvents);
    4848    virtual bool rendererIsNeeded();
    4949    virtual bool storesValueSeparateFromAttribute();

  • trunk/Source/WebCore/html/InputType.h

    r99395 r100805  
    185185    virtual bool shouldUseInputMethod() const;
    186186    virtual void handleBlurEvent();
    187     virtual void accessKeyAction(bool sendToAnyElement);
     187    virtual void accessKeyAction(bool sendMouseEvents);
    188188    virtual bool canBeSuccessfulSubmitButton();
    189189

  • trunk/Source/WebCore/html/RangeInputType.cpp

    r99395 r100805  
    267267
    268268// FIXME: Could share this with BaseButtonInputType and BaseCheckableInputType if we had a common base class.
    269 void RangeInputType::accessKeyAction(bool sendToAnyElement)
    270 {
    271     InputType::accessKeyAction(sendToAnyElement);
    272 
    273     // Send mouse button events if the caller specified sendToAnyElement.
     269void RangeInputType::accessKeyAction(bool sendMouseEvents)
     270{
     271    InputType::accessKeyAction(sendMouseEvents);
     272
     273    // Send mouse button events if the caller specified sendMouseEvents.
    274274    // FIXME: The comment above is no good. It says what we do, but not why.
    275     element()->dispatchSimulatedClick(0, sendToAnyElement);
     275    element()->dispatchSimulatedClick(0, sendMouseEvents);
    276276}
    277277

  • trunk/Source/WebCore/html/RangeInputType.h

    r99395 r100805  
    6565    virtual double parseToDouble(const String&, double) const;
    6666    virtual String serialize(double) const;
    67     virtual void accessKeyAction(bool sendToAnyElement);
     67    virtual void accessKeyAction(bool sendMouseEvents);
    6868    virtual void minOrMaxAttributeChanged();
    6969    virtual void setValue(const String&, bool valueChanged, bool sendChangeEvent);
Note: See TracChangeset for help on using the changeset viewer.