Changeset 100856 in webkit

Timestamp:

Nov 19, 2011 7:34:58 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r98542): Chromium: CSS text is rendered on page
​https://bugs.webkit.org/show_bug.cgi?id=71703

Patch by David Barr <​davidbarr@chromium.org> on 2011-11-19
Reviewed by Antti Koivisto.

Source/WebCore:

Matched UA declarations uncacheable when using simpleDefaultStyleSheet.

Test: fast/css/style-tag-display-none.html

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

• fast/css/style-tag-display-none-expected.txt: Added.
• fast/css/style-tag-display-none.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/style-tag-display-none-expected.txt (added)
• LayoutTests/fast/css/style-tag-display-none.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSStyleSelector.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-11-19  David Barr  <davidbarr@chromium.org>
+
+        REGRESSION(r98542): Chromium: CSS text is rendered on page
+        https://bugs.webkit.org/show_bug.cgi?id=71703
+
+        Reviewed by Antti Koivisto.
+
+        * fast/css/style-tag-display-none-expected.txt: Added.
+        * fast/css/style-tag-display-none.html: Added.
+
 2011-11-18  Mihnea Ovidenie  <mihnea@adobe.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-19  David Barr  <davidbarr@chromium.org>
+
+        REGRESSION(r98542): Chromium: CSS text is rendered on page
+        https://bugs.webkit.org/show_bug.cgi?id=71703
+
+        Reviewed by Antti Koivisto.
+
+        Matched UA declarations uncacheable when using simpleDefaultStyleSheet.
+
+        Test: fast/css/style-tag-display-none.html
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::matchUARules):
+
 2011-11-19  Jay Civelli  <jcivelli@chromium.org>
 

trunk/Source/WebCore/css/CSSStyleSelector.cpp

@@ -1136 +1136 @@
 
     // First we match rules from the user agent sheet.
+    if (simpleDefaultStyleSheet)
+        result.isCacheable = false;
     RuleSet* userAgentStyleSheet = m_medium->mediaTypeMatchSpecific("print")
         ? defaultPrintStyle : defaultStyle;