Changeset 101274 in webkit

Timestamp:

Nov 28, 2011 12:48:23 PM (12 years ago)

Author:

eric@webkit.org

Message:

new-run-webkit-tests is locale dependent
​https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed and modified by Eric Seidel.

This is a simpler version of John's patch which I'm landing.
This just engages the hacks from the Host constructor on a global
basis.

Patch by John Yani <​vanuan@gmail.com> on 2011-11-28

• Scripts/webkitpy/common/host.py:

(Host.init):
(Host._engage_awesome_locale_hacks):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/host.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-11-28  John Yani  <vanuan@gmail.com>
+
+        new-run-webkit-tests is locale dependent
+        https://bugs.webkit.org/show_bug.cgi?id=68691
+
+        Reviewed and modified by Eric Seidel.
+
+        This is a simpler version of John's patch which I'm landing.
+        This just engages the hacks from the Host constructor on a global
+        basis.
+
+        * Scripts/webkitpy/common/host.py:
+        (Host.__init__):
+        (Host._engage_awesome_locale_hacks):
+
 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
 

trunk/Tools/Scripts/webkitpy/common/host.py

@@ -71 +71 @@
         self.port_factory = PortFactory(self)
 
+        self._engage_awesome_locale_hacks()
+
+    # We call this from the Host constructor, as it's one of the
+    # earliest calls made for all webkitpy-based programs.
+    def _engage_awesome_locale_hacks(self):
+        # To make life easier on our non-english users, we override
+        # the locale environment variables inside webkitpy.
+        # If we don't do this, programs like SVN will output localized
+        # messages and svn.py will fail to parse them.
+        # FIXME: We should do these overrides *only* for the subprocesses we know need them!
+        # This hack only works in unix environments.
+        os.environ['LANGUAGE'] = 'en'
+        os.environ['LANG'] = 'en_US.UTF-8'
+        os.environ['LC_MESSAGES'] = 'en_US.UTF-8'
+        os.environ['LC_ALL'] = ''
+
     # FIXME: This is a horrible, horrible hack for ChromiumWin and should be removed.
     # Maybe this belongs in SVN in some more generic "find the svn binary" codepath?