Changeset 101348 in webkit


Ignore:
Timestamp:
Nov 29, 2011 3:00:58 AM (12 years ago)
Author:
mario@webkit.org
Message:

[Gtk] Regression: Push buttons no longer expose their displayed text/name
https://bugs.webkit.org/show_bug.cgi?id=72804

Reviewed by Chris Fleizach.

Source/WebCore:

Use AccessibilityObject::title() as the last fallback in
webkit_accessible_get_name() right before relying on the
stringValue() method, if no better alternative was found.

Test: platform/gtk/accessibility/button-accessible-name.html

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_get_name): Use title() as the last fallback
method before using stringValue().

LayoutTests:

Add new GTK-specific layout test and expections.

  • platform/gtk/accessibility/button-accessible-name-expected.txt: Added.
  • platform/gtk/accessibility/button-accessible-name.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r101346 r101348  
     12011-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        [Gtk] Regression: Push buttons no longer expose their displayed text/name
     4        https://bugs.webkit.org/show_bug.cgi?id=72804
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Add new GTK-specific layout test and expections.
     9
     10        * platform/gtk/accessibility/button-accessible-name-expected.txt: Added.
     11        * platform/gtk/accessibility/button-accessible-name.html: Added.
     12
    1132011-11-29  Csaba Osztrogonác  <ossy@webkit.org>
    214
  • trunk/Source/WebCore/ChangeLog

    r101347 r101348  
     12011-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        [Gtk] Regression: Push buttons no longer expose their displayed text/name
     4        https://bugs.webkit.org/show_bug.cgi?id=72804
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Use AccessibilityObject::title() as the last fallback in
     9        webkit_accessible_get_name() right before relying on the
     10        stringValue() method, if no better alternative was found.
     11
     12        Test: platform/gtk/accessibility/button-accessible-name.html
     13
     14        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
     15        (webkit_accessible_get_name): Use title() as the last fallback
     16        method before using stringValue().
     17
    1182011-11-29  Hyowon Kim  <hw1008.kim@samsung.com>
    219
  • trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp

    r100597 r101348  
    206206            return returnString(document->title());
    207207    }
     208
     209    // Nothing worked so far, try with the AccessibilityObject's
     210    // title() before going ahead with stringValue().
     211    String axTitle = coreObject->title();
     212    if (!axTitle.isEmpty())
     213        return returnString(axTitle);
    208214
    209215    return returnString(coreObject->stringValue());
Note: See TracChangeset for help on using the changeset viewer.