Changeset 101742 in webkit
- Timestamp:
- Dec 1, 2011 10:23:05 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 15 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r101738 r101742 1 2011-12-01 Kent Tamura <tkent@chromium.org> 2 3 REGRESSION(r90971): Placeholder text of input control is rendered 4 over positioned elements with z-index:0. 5 https://bugs.webkit.org/show_bug.cgi?id=67408 6 7 Reviewed by Darin Adler. 8 9 Need to update some placeholder-related tests because we don't use position:relative. 10 11 * fast/forms/placeholder-with-positioned-element-expected.html: Added. 12 * fast/forms/placeholder-with-positioned-element.html: Added. 13 * platform/chromium/test_expectations.txt: 14 * platform/gtk/test_expectations.txt: 15 * platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: 16 * platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: 17 * platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: 18 * platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: 19 * platform/mac/Skipped: 20 * platform/mac/fast/forms/placeholder-position-expected.txt: 21 * platform/mac/fast/forms/placeholder-pseudo-style-expected.txt: 22 * platform/mac/fast/forms/search-styled-expected.txt: 23 * platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt: 24 * platform/qt/test_expectations.txt: 25 1 26 2011-12-01 Jacob Goldstein <jacobg@adobe.com> 2 27 -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r101732 r101742 2849 2849 BUGCR77494 LINUX WIN : fast/repaint/transform-replaced-shadows.html = IMAGE 2850 2850 2851 // Need rebaseline. 2852 BUGWK67408 : fast/forms/input-placeholder-visibility-1.html = FAIL 2853 BUGWK67408 : fast/forms/input-placeholder-visibility-3.html = FAIL 2854 BUGWK67408 : fast/forms/placeholder-position.html = FAIL 2855 BUGWK67408 : fast/forms/placeholder-pseudo-style.html = FAIL 2856 BUGWK67408 : fast/forms/search-styled.html = FAIL 2857 BUGWK67408 : fast/forms/textarea-placeholder-pseudo-style.html = FAIL 2858 BUGWK67408 : fast/forms/textarea-placeholder-visibility-1.html = FAIL 2859 BUGWK67408 : fast/forms/textarea-placeholder-visibility-2.html = FAIL 2860 2851 2861 // Regression since r82001. 2852 2862 BUGCR77619 SNOWLEOPARD : plugins/plugin-javascript-access.html = TEXT -
trunk/LayoutTests/platform/gtk/test_expectations.txt
r101338 r101742 7 7 BUGWK67007 DEBUG : fast/ruby/generated-after-counter-doesnt-crash.html = CRASH 8 8 BUGWK67007 DEBUG : fast/ruby/generated-before-and-after-counter-doesnt-crash.html = CRASH 9 10 // Need rebaseline. 11 BUGWK67408 : fast/forms/input-placeholder-visibility-1.html = FAIL 12 BUGWK67408 : fast/forms/input-placeholder-visibility-3.html = FAIL 13 BUGWK67408 : fast/forms/placeholder-position.html = FAIL 14 BUGWK67408 : fast/forms/placeholder-pseudo-style.html = FAIL 15 BUGWK67408 : fast/forms/search-styled.html = FAIL 16 BUGWK67408 : fast/forms/textarea-placeholder-pseudo-style.html = FAIL 17 BUGWK67408 : fast/forms/textarea-placeholder-visibility-1.html = FAIL 18 BUGWK67408 : fast/forms/textarea-placeholder-visibility-2.html = FAIL 9 19 10 20 // Flaky tests -
trunk/LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt
r92209 r101742 13 13 layer at (13,47) size 119x13 14 14 RenderBlock {DIV} at (3,3) size 119x13 15 layer at (13,47) size 119x13 16 RenderBlock {DIV} at (3,3) size 119x13 [color=#A9A9A9] 17 RenderText {#text} at (1,0) size 62x13 18 text run at (1,0) width 62: "Placeholder" 15 19 caret: position 0 of child 0 {DIV} of {#shadow-root} of child 1 {INPUT} of child 3 {DIV} of body -
trunk/LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt
r92209 r101742 14 14 RenderBlock {DIV} at (3,3) size 119x13 15 15 RenderBR {BR} at (1,0) size 0x13 16 layer at (13,47) size 119x13 17 RenderBlock {DIV} at (3,3) size 119x13 [color=#A9A9A9] 18 RenderText {#text} at (1,0) size 62x13 19 text run at (1,0) width 62: "Placeholder" 16 20 caret: position 0 of child 0 {BR} of child 0 {DIV} of {#shadow-root} of child 1 {INPUT} of child 3 {DIV} of body -
trunk/LayoutTests/platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt
r92209 r101742 14 14 RenderBlock {DIV} at (3,3) size 155x13 15 15 RenderBR {BR} at (0,0) size 0x13 16 RenderBlock {DIV} at (3,3) size 155x13 [color=#A9A9A9] 17 RenderText {#text} at (0,0) size 62x13 18 text run at (0,0) width 62: "Placeholder" 16 19 caret: position 0 of child 0 {BR} of child 0 {DIV} of {#shadow-root} of child 1 {TEXTAREA} of child 3 {DIV} of body -
trunk/LayoutTests/platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt
r92209 r101742 13 13 RenderTextControl {TEXTAREA} at (2,2) size 161x32 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 14 14 RenderBlock {DIV} at (3,3) size 155x13 15 RenderBlock {DIV} at (3,3) size 155x13 [color=#A9A9A9] 16 RenderText {#text} at (0,0) size 62x13 17 text run at (0,0) width 62: "Placeholder" 15 18 caret: position 0 of child 0 {DIV} of {#shadow-root} of child 1 {TEXTAREA} of child 3 {DIV} of body -
trunk/LayoutTests/platform/mac/Skipped
r101682 r101742 495 495 pointer-lock/ 496 496 497 # Placeholder is not rendered since the patch in the following bug. It seems a DRT-only problem. 498 # https://bugs.webkit.org/show_bug.cgi?id=67408 499 fast/forms/textarea-placeholder-set-attribute.html 500 497 501 # https://bugs.webkit.org/show_bug.cgi?id=72435 498 502 fast/dom/Window/window-postmessage-arrays.html -
trunk/LayoutTests/platform/mac/fast/forms/placeholder-position-expected.txt
r90971 r101742 50 50 layer at (21,13) size 98x13 51 51 RenderBlock {DIV} at (0,0) size 98x13 52 layer at (21,13) size 98x13 53 RenderBlock {DIV} at (11,3) size 98x13 [color=#A9A9A9] 54 RenderText {#text} at (1,0) size 63x13 55 text run at (1,0) width 63: "placeholder" 52 56 layer at (13,36) size 119x13 53 57 RenderBlock {DIV} at (3,3) size 119x13 58 layer at (13,36) size 119x13 59 RenderBlock {DIV} at (3,3) size 119x13 [color=#A9A9A9] 60 RenderText {#text} at (1,0) size 63x13 61 text run at (1,0) width 63: "placeholder" 54 62 layer at (21,59) size 98x13 55 63 RenderBlock {DIV} at (0,0) size 98x13 64 layer at (21,59) size 98x13 65 RenderBlock {DIV} at (11,3) size 98x13 [color=#A9A9A9] 66 RenderText {#text} at (34,0) size 63x13 67 text run at (34,0) width 63: "placeholder" 56 68 layer at (35,82) size 84x13 57 69 RenderBlock {DIV} at (0,0) size 84x13 70 layer at (35,82) size 84x13 71 RenderBlock {DIV} at (25,3) size 84x13 [color=#A9A9A9] 72 RenderText {#text} at (1,0) size 63x13 73 text run at (1,0) width 63: "placeholder" 58 74 layer at (10,102) size 161x32 clip at (11,103) size 159x30 59 75 RenderTextControl {TEXTAREA} at (2,94) size 161x32 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 60 76 RenderBlock {DIV} at (3,3) size 155x13 77 RenderBlock {DIV} at (3,3) size 155x13 [color=#A9A9A9] 78 RenderText {#text} at (0,0) size 63x13 79 text run at (0,0) width 63: "placeholder" 61 80 layer at (13,141) size 119x13 62 81 RenderBlock {DIV} at (3,3) size 119x13 82 layer at (13,141) size 119x13 83 RenderBlock {DIV} at (3,3) size 119x13 [color=#A9A9A9] 84 RenderText {#text} at (1,0) size 63x13 85 text run at (1,0) width 63: "placeholder" 63 86 layer at (10,175) size 161x45 clip at (11,176) size 159x43 64 87 RenderTextControl {TEXTAREA} at (2,167) size 161x45 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 65 88 RenderBlock {DIV} at (3,16) size 155x13 89 RenderBlock {DIV} at (3,16) size 155x13 [color=#A9A9A9] 90 RenderText {#text} at (0,0) size 63x13 91 text run at (0,0) width 63: "placeholder" 66 92 layer at (19,233) size 164x18 67 93 RenderBlock {DIV} at (6,6) size 164x18 94 layer at (19,233) size 164x18 95 RenderBlock {DIV} at (6,6) size 164x18 [color=#A9A9A9] 96 RenderText {#text} at (1,0) size 85x18 97 text run at (1,0) width 85: "placeholder" 68 98 layer at (13,267) size 119x25 69 99 RenderBlock {DIV} at (3,3) size 119x25 … … 72 102 layer at (146,267) size 119x25 73 103 RenderBlock {DIV} at (3,3) size 119x25 104 layer at (146,267) size 119x25 105 RenderBlock {DIV} at (3,3) size 119x25 [color=#A9A9A9] 106 RenderText {#text} at (1,6) size 63x13 107 text run at (1,6) width 63: "placeholder" 74 108 layer at (13,302) size 119x13 75 109 RenderBlock {DIV} at (3,3) size 119x13 … … 78 112 layer at (146,302) size 119x13 79 113 RenderBlock {DIV} at (3,3) size 119x13 80 layer at (279,302) size 119x1381 RenderBlock {DIV} at (3,3) size 119x1382 layer at (21,13) size 98x1383 RenderBlock (relative positioned) {DIV} at (11,3) size 98x13 [color=#A9A9A9]84 RenderText {#text} at (1,0) size 63x1385 text run at (1,0) width 63: "placeholder"86 layer at (13,36) size 119x1387 RenderBlock (relative positioned) {DIV} at (3,3) size 119x13 [color=#A9A9A9]88 RenderText {#text} at (1,0) size 63x1389 text run at (1,0) width 63: "placeholder"90 layer at (21,59) size 98x1391 RenderBlock (relative positioned) {DIV} at (11,3) size 98x13 [color=#A9A9A9]92 RenderText {#text} at (34,0) size 63x1393 text run at (34,0) width 63: "placeholder"94 layer at (35,82) size 84x1395 RenderBlock (relative positioned) {DIV} at (25,3) size 84x13 [color=#A9A9A9]96 RenderText {#text} at (1,0) size 63x1397 text run at (1,0) width 63: "placeholder"98 layer at (13,105) size 155x1399 RenderBlock (relative positioned) {DIV} at (3,3) size 155x13 [color=#A9A9A9]100 RenderText {#text} at (0,0) size 63x13101 text run at (0,0) width 63: "placeholder"102 layer at (13,141) size 119x13103 RenderBlock (relative positioned) {DIV} at (3,3) size 119x13 [color=#A9A9A9]104 RenderText {#text} at (1,0) size 63x13105 text run at (1,0) width 63: "placeholder"106 layer at (13,191) size 155x13107 RenderBlock (relative positioned) {DIV} at (3,16) size 155x13 [color=#A9A9A9]108 RenderText {#text} at (0,0) size 63x13109 text run at (0,0) width 63: "placeholder"110 layer at (19,233) size 164x18111 RenderBlock (relative positioned) {DIV} at (6,6) size 164x18 [color=#A9A9A9]112 RenderText {#text} at (1,0) size 85x18113 text run at (1,0) width 85: "placeholder"114 layer at (146,267) size 119x25115 RenderBlock (relative positioned) {DIV} at (3,3) size 119x25 [color=#A9A9A9]116 RenderText {#text} at (1,6) size 63x13117 text run at (1,6) width 63: "placeholder"118 114 layer at (146,302) size 119x13 119 RenderBlock (relative positioned){DIV} at (3,3) size 119x13 [color=#A9A9A9]115 RenderBlock {DIV} at (3,3) size 119x13 [color=#A9A9A9] 120 116 RenderText {#text} at (28,0) size 63x13 121 117 text run at (28,0) width 63: "placeholder" 122 118 layer at (279,302) size 119x13 123 RenderBlock (relative positioned) {DIV} at (3,3) size 119x13 [color=#A9A9A9] 119 RenderBlock {DIV} at (3,3) size 119x13 120 layer at (279,302) size 119x13 121 RenderBlock {DIV} at (3,3) size 119x13 [color=#A9A9A9] 124 122 RenderText {#text} at (28,0) size 63x13 125 123 text run at (28,0) width 63: "placeholder" … … 129 127 RenderBlock {DIV} at (3,17) size 119x13 130 128 layer at (13,339) size 119x13 131 RenderBlock (relative positioned){DIV} at (3,17) size 119x13 [color=#A9A9A9]129 RenderBlock {DIV} at (3,17) size 119x13 [color=#A9A9A9] 132 130 RenderText {#text} at (1,0) size 63x13 133 131 text run at (1,0) width 63: "placeholder" -
trunk/LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt
r90971 r101742 30 30 layer at (13,31) size 119x13 31 31 RenderBlock {DIV} at (3,3) size 119x13 32 layer at (154,31) size 98x1333 RenderBlock {DIV} at (0,0) size 98x1334 layer at (279,31) size 119x1335 RenderBlock {DIV} at (3,3) size 119x1336 layer at (412,31) size 119x1337 RenderBlock {DIV} at (3,3) size 119x13 [color=#545454]38 layer at (545,31) size 119x1339 RenderBlock {DIV} at (3,3) size 119x1340 layer at (13,54) size 119x1341 RenderBlock {DIV} at (3,3) size 119x1342 32 layer at (13,31) size 119x13 43 RenderBlock (relative positioned){DIV} at (3,3) size 119x13 [color=#640000]33 RenderBlock {DIV} at (3,3) size 119x13 [color=#640000] 44 34 RenderText {#text} at (1,0) size 22x13 45 35 text run at (1,0) width 22: "text" 46 36 layer at (154,31) size 98x13 47 RenderBlock (relative positioned) {DIV} at (11,3) size 98x13 [color=#640000] 37 RenderBlock {DIV} at (0,0) size 98x13 38 layer at (154,31) size 98x13 39 RenderBlock {DIV} at (11,3) size 98x13 [color=#640000] 48 40 RenderText {#text} at (1,0) size 35x13 49 41 text run at (1,0) width 35: "search" 50 42 layer at (279,31) size 119x13 51 RenderBlock (relative positioned) {DIV} at (3,3) size 119x13 [color=#640000] 43 RenderBlock {DIV} at (3,3) size 119x13 44 layer at (279,31) size 119x13 45 RenderBlock {DIV} at (3,3) size 119x13 [color=#640000] 52 46 RenderText {#text} at (1,0) size 51x13 53 47 text run at (1,0) width 51: "password" 54 48 layer at (412,31) size 119x13 55 RenderBlock (relative positioned) {DIV} at (3,3) size 119x13 [color=#640000] 49 RenderBlock {DIV} at (3,3) size 119x13 [color=#545454] 50 layer at (412,31) size 119x13 51 RenderBlock {DIV} at (3,3) size 119x13 [color=#640000] 56 52 RenderText {#text} at (1,0) size 70x13 57 53 text run at (1,0) width 70: "disabled text" 58 54 layer at (545,31) size 119x13 59 RenderBlock (relative positioned) {DIV} at (3,3) size 119x13 [color=#A9A9A9] 55 RenderBlock {DIV} at (3,3) size 119x13 56 layer at (545,31) size 119x13 57 RenderBlock {DIV} at (3,3) size 119x13 [color=#A9A9A9] 60 58 RenderText {#text} at (1,0) size 38x13 61 59 text run at (1,0) width 38: "default" 62 60 layer at (13,54) size 119x13 63 RenderBlock (relative positioned) {DIV} at (3,3) size 119x13 [color=#A9A9A9] 61 RenderBlock {DIV} at (3,3) size 119x13 62 layer at (13,54) size 119x13 63 RenderBlock {DIV} at (3,3) size 119x13 [color=#A9A9A9] 64 64 RenderText {#text} at (1,0) size 86x13 65 65 text run at (1,0) width 86: "default disabled" -
trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt
r90971 r101742 13 13 RenderBlock {DIV} at (0,0) size 84x13 14 14 layer at (35,13) size 84x13 scrollWidth 94 15 RenderBlock (relative positioned){DIV} at (25,3) size 84x13 [color=#A9A9A9]15 RenderBlock {DIV} at (25,3) size 84x13 [color=#A9A9A9] 16 16 RenderText {#text} at (1,0) size 92x13 17 17 text run at (1,0) width 92: "Search for Events" -
trunk/LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt
r90971 r101742 17 17 RenderTextControl {TEXTAREA} at (2,20) size 161x32 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 18 18 RenderBlock {DIV} at (3,3) size 155x13 19 RenderBlock {DIV} at (3,3) size 155x13 [color=#640000] 20 RenderText {#text} at (0,0) size 22x13 21 text run at (0,0) width 22: "text" 19 22 layer at (179,28) size 161x32 clip at (180,29) size 159x30 20 23 RenderTextControl {TEXTAREA} at (171,20) size 161x32 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 21 24 RenderBlock {DIV} at (3,3) size 155x13 [color=#545454] 25 RenderBlock {DIV} at (3,3) size 155x13 [color=#640000] 26 RenderText {#text} at (0,0) size 70x13 27 text run at (0,0) width 70: "disabled text" 22 28 layer at (348,28) size 161x32 clip at (349,29) size 159x30 23 29 RenderTextControl {TEXTAREA} at (340,20) size 161x32 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 24 30 RenderBlock {DIV} at (3,3) size 155x13 31 RenderBlock {DIV} at (3,3) size 155x13 [color=#A9A9A9] 32 RenderText {#text} at (0,0) size 38x13 33 text run at (0,0) width 38: "default" 25 34 layer at (517,28) size 161x32 clip at (518,29) size 159x30 26 35 RenderTextControl {TEXTAREA} at (509,20) size 161x32 [bgcolor=#FFFFFF] [border: (1px solid #000000)] 27 36 RenderBlock {DIV} at (3,3) size 155x13 [color=#545454] 28 layer at (13,31) size 155x13 29 RenderBlock (relative positioned) {DIV} at (3,3) size 155x13 [color=#640000] 30 RenderText {#text} at (0,0) size 22x13 31 text run at (0,0) width 22: "text" 32 layer at (182,31) size 155x13 33 RenderBlock (relative positioned) {DIV} at (3,3) size 155x13 [color=#640000] 34 RenderText {#text} at (0,0) size 70x13 35 text run at (0,0) width 70: "disabled text" 36 layer at (351,31) size 155x13 37 RenderBlock (relative positioned) {DIV} at (3,3) size 155x13 [color=#A9A9A9] 38 RenderText {#text} at (0,0) size 38x13 39 text run at (0,0) width 38: "default" 40 layer at (520,31) size 155x13 41 RenderBlock (relative positioned) {DIV} at (3,3) size 155x13 [color=#A9A9A9] 42 RenderText {#text} at (0,0) size 86x13 43 text run at (0,0) width 86: "default disabled" 37 RenderBlock {DIV} at (3,3) size 155x13 [color=#A9A9A9] 38 RenderText {#text} at (0,0) size 86x13 39 text run at (0,0) width 86: "default disabled" -
trunk/LayoutTests/platform/qt/test_expectations.txt
r99656 r101742 4 4 5 5 BUGWK64526 DEBUG: svg/animations/svgtransform-animation-1.html = CRASH PASS 6 7 // Need rebaseline. 8 BUGWK67408 : fast/forms/input-placeholder-visibility-1.html = FAIL 9 BUGWK67408 : fast/forms/input-placeholder-visibility-3.html = FAIL 10 BUGWK67408 : fast/forms/placeholder-position.html = FAIL 11 BUGWK67408 : fast/forms/placeholder-pseudo-style.html = FAIL 12 BUGWK67408 : fast/forms/search-styled.html = FAIL 13 BUGWK67408 : fast/forms/textarea-placeholder-pseudo-style.html = FAIL 14 BUGWK67408 : fast/forms/textarea-placeholder-visibility-1.html = FAIL 15 BUGWK67408 : fast/forms/textarea-placeholder-visibility-2.html = FAIL 6 16 7 17 // Slow tests -
trunk/Source/WebCore/ChangeLog
r101741 r101742 1 2011-12-01 Kent Tamura <tkent@chromium.org> 2 3 REGRESSION(r90971): Placeholder text of input control is rendered 4 over positioned elements with z-index:0. 5 https://bugs.webkit.org/show_bug.cgi?id=67408 6 7 Reviewed by Darin Adler. 8 9 The bug was caused by "position:relative" in the default style of 10 -webkit-input-placeholder. If there were other positioned elements 11 with z-index:0, a placeholder might be rendered over them. 12 13 "position:relative" is not needed because RenderTextControlSingleLine 14 and RenderTextControlMultipleLine lay out the placeholder renderer by 15 custom layout code. 16 17 Tests: fast/forms/placeholder-with-positioned-element.html 18 19 * css/html.css: 20 (::-webkit-input-placeholder): Remove position:relative. 21 1 22 2011-12-01 Andreas Kling <kling@webkit.org> 2 23 -
trunk/Source/WebCore/css/html.css
r101268 r101742 506 506 display: block !important; 507 507 pointer-events: none !important; 508 position: relative !important;509 508 } 510 509
Note: See TracChangeset
for help on using the changeset viewer.