Changeset 101790 in webkit


Ignore:
Timestamp:
Dec 2, 2011 6:44:42 AM (12 years ago)
Author:
vsevik@chromium.org
Message:

Web Inspector: Split view works weirdly in network panel when resizing, showing/hiding main element.
https://bugs.webkit.org/show_bug.cgi?id=73650

Reviewed by Pavel Feldman.

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView.prototype._updateResizer):
(WebInspector.SplitView.prototype.hideMainElement):
(WebInspector.SplitView.prototype.showMainElement):
(WebInspector.SplitView.prototype.onResize):
(WebInspector.SplitView.prototype._restoreSidebarWidth):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r101789 r101790  
     12011-12-02  Vsevolod Vlasov  <vsevik@chromium.org>
     2
     3        Web Inspector: Split view works weirdly in network panel when resizing, showing/hiding main element.
     4        https://bugs.webkit.org/show_bug.cgi?id=73650
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * inspector/front-end/SplitView.js:
     9        (WebInspector.SplitView.prototype._updateResizer):
     10        (WebInspector.SplitView.prototype.hideMainElement):
     11        (WebInspector.SplitView.prototype.showMainElement):
     12        (WebInspector.SplitView.prototype.onResize):
     13        (WebInspector.SplitView.prototype._restoreSidebarWidth):
     14
    1152011-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
    216
  • trunk/Source/WebCore/inspector/front-end/SplitView.js

    r100991 r101790  
    131131    _updateResizer: function()
    132132    {
    133         if (this._resizable)
     133        if (this.resizable)
    134134            this.sidebarResizerElement.removeStyleClass("hidden");
    135135        else
     
    280280        this.mainElement.addStyleClass("hidden");
    281281        this.sidebarElement.addStyleClass("maximized");
     282       
     283        if (this.hasLeftSidebar)
     284            this.sidebarElement.style.right = "0px";
     285        else
     286            this.sidebarElement.style.left = "0px";
     287       
    282288        this._mainElementHidden = true;
    283289        this._updateResizer();
     
    292298        this.mainElement.removeStyleClass("hidden");
    293299        this.sidebarElement.removeStyleClass("maximized");
     300       
     301        if (this.hasLeftSidebar)
     302            this.sidebarElement.style.right = "";
     303        else
     304            this.sidebarElement.style.left = "";
     305
    294306        this._mainElementHidden = false;
    295307        this._updateResizer();
     
    331343    {
    332344        this._totalWidth = this.element.offsetWidth;
     345
     346        if (this._mainElementHidden)
     347            this._sidebarWidth = this._totalWidth;
    333348    },
    334349
     
    391406    {
    392407        if (this._mainElementHidden) {
    393             this._innerSetSidebarWidth(this._totalWidth);
     408            this.sidebarElement.style.width = "";
     409            this._sidebarWidth = this._totalWidth;
    394410            return;
    395411        }
Note: See TracChangeset for help on using the changeset viewer.