Changeset 101920 in webkit


Ignore:
Timestamp:
Dec 3, 2011 2:26:48 AM (12 years ago)
Author:
Philippe Normand
Message:

[GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=66968

Reviewed by Martin Robinson.

Source/WebCore:

  • GNUmakefile.am: Don't use the Quicktime fullscreen CSS anymore,

it wasn't suited for GTK in the first place anyway.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::extraFullScreenStyleSheet): Simply reuse
GTK CSS.

Source/WebKit/gtk:

If the element being fullscreened is a video use the native
fullscreen controls.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

LayoutTests:

  • platform/gtk/Skipped: Skip

fullscreen/video-controls-override.html now failing because of bug 73583.

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r101918 r101920  
     12011-12-03  Philippe Normand  <pnormand@igalia.com>
     2
     3        [GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
     4        https://bugs.webkit.org/show_bug.cgi?id=66968
     5
     6        Reviewed by Martin Robinson.
     7
     8        * platform/gtk/Skipped: Skip
     9        fullscreen/video-controls-override.html now failing because of bug 73583.
     10
    1112011-12-03  Csaba Osztrogonác  <ossy@webkit.org>
    212
  • trunk/LayoutTests/platform/gtk/Skipped

    r101916 r101920  
    15891589# https://bugs.webkit.org/show_bug.cgi?id=73666
    15901590http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html
     1591
     1592# https://bugs.webkit.org/show_bug.cgi?id=73583
     1593fullscreen/video-controls-override.html
  • trunk/Source/WebCore/ChangeLog

    r101919 r101920  
     12011-12-02  Philippe Normand  <pnormand@igalia.com>
     2
     3        [GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
     4        https://bugs.webkit.org/show_bug.cgi?id=66968
     5
     6        Reviewed by Martin Robinson.
     7
     8        * GNUmakefile.am: Don't use the Quicktime fullscreen CSS anymore,
     9        it wasn't suited for GTK in the first place anyway.
     10        * platform/gtk/RenderThemeGtk.cpp:
     11        (WebCore::RenderThemeGtk::extraFullScreenStyleSheet): Simply reuse
     12        GTK CSS.
     13
    1142011-12-03  Alejandro G. Castro  <alex@igalia.com>
    215
  • trunk/Source/WebCore/GNUmakefile.am

    r101764 r101920  
    664664        $(WebCore)/css/mediaControls.css \
    665665        $(WebCore)/css/mediaControlsGtk.css \
    666         $(WebCore)/css/fullscreen.css \
    667         $(WebCore)/css/fullscreenQuickTime.css
     666        $(WebCore)/css/fullscreen.css
    668667
    669668# new-style JavaScript bindings
  • trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp

    r100408 r101920  
    482482String RenderThemeGtk::extraFullScreenStyleSheet()
    483483{
    484     return String(fullscreenQuickTimeUserAgentStyleSheet, sizeof(fullscreenQuickTimeUserAgentStyleSheet));
     484    return String();
    485485}
    486486#endif
  • trunk/Source/WebKit/gtk/ChangeLog

    r101765 r101920  
     12011-12-02  Philippe Normand  <pnormand@igalia.com>
     2
     3        [GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
     4        https://bugs.webkit.org/show_bug.cgi?id=66968
     5
     6        Reviewed by Martin Robinson.
     7
     8        If the element being fullscreened is a video use the native
     9        fullscreen controls.
     10
     11        * WebCoreSupport/ChromeClientGtk.cpp:
     12        (WebKit::ChromeClient::enterFullScreenForElement):
     13        (WebKit::ChromeClient::exitFullScreenForElement):
     14
    1152011-12-01  Philippe Normand  <pnormand@igalia.com>
    216
  • trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

    r101765 r101920  
    891891    element->document()->webkitWillEnterFullScreenForElement(element);
    892892    m_adjustmentWatcher.disableAllScrollbars();
     893#if ENABLE(VIDEO)
     894    if (element->tagName() == "VIDEO")
     895        enterFullscreenForNode(static_cast<Node*>(element));
     896#endif
    893897    element->document()->webkitDidEnterFullScreenForElement(element);
    894898}
     
    898902    element->document()->webkitWillExitFullScreenForElement(element);
    899903    m_adjustmentWatcher.enableAllScrollbars();
     904#if ENABLE(VIDEO)
     905    if (element->tagName() == "VIDEO")
     906        webViewExitFullscreen(m_webView);
     907#endif
    900908    element->document()->webkitDidExitFullScreenForElement(element);
    901909}
Note: See TracChangeset for help on using the changeset viewer.