Changeset 101995 in webkit


Ignore:
Timestamp:
Dec 5, 2011 6:46:36 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r101983.
http://trac.webkit.org/changeset/101983
https://bugs.webkit.org/show_bug.cgi?id=73827

It broke all tests on GTK and on Qt in debug mode (Requested
by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-05

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):

  • dom/Node.h:

(WebCore::Node::inDocument):

Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r101987 r101995  
     12011-12-05  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r101983.
     4        http://trac.webkit.org/changeset/101983
     5        https://bugs.webkit.org/show_bug.cgi?id=73827
     6
     7        It broke all tests on GTK and on Qt in debug mode (Requested
     8        by Ossy on #webkit).
     9
     10        * dom/Document.h:
     11        (WebCore::Node::Node):
     12        * dom/Node.cpp:
     13        (WebCore::Node::~Node):
     14        * dom/Node.h:
     15        (WebCore::Node::inDocument):
     16
    1172011-12-05  Roland Steiner  <rolandsteiner@chromium.org>
    218
  • trunk/Source/WebCore/dom/Document.h

    r101983 r101995  
    14501450    , m_renderer(0)
    14511451{
    1452     if (document)
    1453         document->guardRef();
     1452    if (m_document)
     1453        m_document->guardRef();
    14541454#if !defined(NDEBUG) || (defined(DUMP_NODE_STATISTICS) && DUMP_NODE_STATISTICS)
    14551455    trackForDebugging();
  • trunk/Source/WebCore/dom/Node.cpp

    r101983 r101995  
    405405        detach();
    406406
    407     Document* doc = document();
    408     if (AXObjectCache::accessibilityEnabled() && doc && doc->axObjectCacheExists())
    409         doc->axObjectCache()->removeNodeForUse(this);
     407    if (AXObjectCache::accessibilityEnabled() && m_document && m_document->axObjectCacheExists())
     408        m_document->axObjectCache()->removeNodeForUse(this);
    410409   
    411410    if (m_previous)
     
    414413        m_next->setPreviousSibling(0);
    415414
    416     if (doc)
    417         doc->guardDeref();
     415    if (m_document)
     416        m_document->guardDeref();
    418417}
    419418
  • trunk/Source/WebCore/dom/Node.h

    r101983 r101995  
    389389    bool inDocument() const
    390390    {
    391         ASSERT(document() || !getFlag(InDocumentFlag));
     391        ASSERT(m_document || !getFlag(InDocumentFlag));
    392392        return getFlag(InDocumentFlag);
    393393    }
Note: See TracChangeset for help on using the changeset viewer.