Changeset 102096 in webkit


Ignore:
Timestamp:
Dec 5, 2011 10:20:00 PM (12 years ago)
Author:
noel.gordon@gmail.com
Message:

[GTK] GIF image test crashes on 32- and 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=73812

Reviewed by Adam Barth.

Call resize() on the image pixel backing store after allocation to see if
that stops the GIF image decoder animation tests crashes on GTK.

No new tests, covered by exiting tests ...

fast/backgrounds/animated-gif-as-background.html
fast/images/dont-crash-with-null-gif-frames.html
fast/images/gif-loop-count.html

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::setSize):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r102095 r102096  
     12011-12-05  Noel Gordon  <noel.gordon@gmail.com>
     2
     3        [GTK] GIF image test crashes on 32- and 64-bit Release
     4        https://bugs.webkit.org/show_bug.cgi?id=73812
     5
     6        Reviewed by Adam Barth.
     7
     8        Call resize() on the image pixel backing store after allocation to see if
     9        that stops the GIF image decoder animation tests crashes on GTK.
     10
     11        No new tests, covered by exiting tests ...
     12          fast/backgrounds/animated-gif-as-background.html
     13          fast/images/dont-crash-with-null-gif-frames.html
     14          fast/images/gif-loop-count.html
     15
     16        * platform/image-decoders/ImageDecoder.cpp:
     17        (WebCore::ImageFrame::setSize):
     18
    1192011-12-05  Erik Arvidsson  <arv@chromium.org>
    220
  • trunk/Source/WebCore/platform/image-decoders/ImageDecoder.cpp

    r101975 r102096  
    194194    if (!m_backingStore.tryReserveCapacity(backingStoreSize))
    195195        return false;
    196     // Vector<> m_backingStore is used as a buffer of bytes only, and is accessed
    197     // via the m_bytes member only. There is no need to resize() m_backingStore.
     196    m_backingStore.resize(backingStoreSize);
    198197    m_bytes = m_backingStore.data();
    199198    m_size = IntSize(newWidth, newHeight);
Note: See TracChangeset for help on using the changeset viewer.