Changeset 102283 in webkit

Timestamp:

Dec 7, 2011 4:32:51 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Exposing boundsInScreenSpace in WebElement.
​https://bugs.webkit.org/show_bug.cgi?id=71579

Exposing boundsInScreenSpace through a new function,
boundsInViewportSpace, to assist in moving the Autofill UI out of
WebKit in Chromium. Renamed the exposed function to provide a better
meaning of what the function does in the Chromium code.
More information can be found at:
​http://crbug.com/51644

Patch by Chris Sharp <​csharp@chromium.org> on 2011-12-07
Reviewed by Darin Fisher.

• public/WebElement.h:
• src/WebElement.cpp:

(WebKit::WebElement::boundsInViewportSpace):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebElement.h (modified) (2 diffs)
• src/WebElement.cpp (modified) (2 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-12-07  Chris Sharp  <csharp@chromium.org>
+        
+        Exposing boundsInScreenSpace in WebElement.
+        https://bugs.webkit.org/show_bug.cgi?id=71579
+
+        Exposing boundsInScreenSpace through a new function,
+        boundsInViewportSpace, to assist in moving the Autofill UI out of
+        WebKit in Chromium. Renamed the exposed function to provide a better
+        meaning of what the function does in the Chromium code.
+        More information can be found at:
+        http://crbug.com/51644
+
+
+        Reviewed by Darin Fisher.
+
+        * public/WebElement.h:
+        * src/WebElement.cpp:
+        (WebKit::WebElement::boundsInViewportSpace):
+
 2011-12-07  Adam Klein  <adamk@chromium.org>
 

trunk/Source/WebKit/chromium/public/WebElement.h

@@ -40 +40 @@
 namespace WebKit {
 class WebNamedNodeMap;
+struct WebRect;
 
     // Provides access to some properties of a DOM element node.
@@ -68 +69 @@
         WEBKIT_EXPORT WebString computeInheritedLanguage() const;
 
+        // Returns the bounds of the element in viewport space. The bounds
+        // have been adjusted to include any transformations. This view is
+        // also called the Root View in WebKit.
+        // This function will update the layout if required.
+        WEBKIT_EXPORT WebRect boundsInViewportSpace();
+
 #if WEBKIT_IMPLEMENTATION
         WebElement(const WTF::PassRefPtr<WebCore::Element>&);

trunk/Source/WebKit/chromium/src/WebElement.cpp

@@ -30 +30 @@
 
 #include "config.h"
+#include "platform/WebRect.h"
 #include "WebElement.h"
 #include "WebDocument.h"
@@ -109 +110 @@
 }
 
+WebRect WebElement::boundsInViewportSpace()
+{
+    return unwrap<Element>()->boundsInRootViewSpace();
+}
+
 WebElement::WebElement(const PassRefPtr<Element>& elem)
     : WebNode(elem)