Changeset 102501 in webkit


Ignore:
Timestamp:
Dec 9, 2011 5:39:11 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[FileSystem API] Entry.remove successCallback is required
​https://bugs.webkit.org/show_bug.cgi?id=69639

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2011-12-09
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/filesystem/simple-required-arguments-remove.html

  • fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter

LayoutTests:

  • fast/filesystem/resources/simple-required-arguments-remove.js: Added.

(errorCallback):
(successCallback):

  • fast/filesystem/simple-required-arguments-remove-expected.txt: Added.
  • fast/filesystem/simple-required-arguments-remove.html: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r102498 r102501  
     12011-12-09  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        [FileSystem API] Entry.remove successCallback is required
     4        https://bugs.webkit.org/show_bug.cgi?id=69639
     5
     6        Reviewed by Adam Barth.
     7
     8        * fast/filesystem/resources/simple-required-arguments-remove.js: Added.
     9        (errorCallback):
     10        (successCallback):
     11        * fast/filesystem/simple-required-arguments-remove-expected.txt: Added.
     12        * fast/filesystem/simple-required-arguments-remove.html: Added.
     13
    1142011-12-09  Tim Horton  <timothy_horton@apple.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r102498 r102501  
     12011-12-09  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        [FileSystem API] Entry.remove successCallback is required
     4        https://bugs.webkit.org/show_bug.cgi?id=69639
     5
     6        Reviewed by Adam Barth.
     7
     8        Test: fast/filesystem/simple-required-arguments-remove.html
     9
     10        * fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter
     11
    1122011-12-09  Tim Horton  <timothy_horton@apple.com>
    213

  • trunk/Source/WebCore/fileapi/Entry.idl

    r91486 r102501  
    4545        void copyTo(in DirectoryEntry parent, in [Optional, ConvertUndefinedOrNullToNullString] DOMString name, in [Optional, Callback] EntryCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
    4646        DOMString toURL();
    47         void remove(in [Optional, Callback] VoidCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
     47        void remove(in [Callback] VoidCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
    4848        void getParent(in [Optional, Callback] EntryCallback successCallback, in [Optional, Callback] ErrorCallback errorCallback);
    4949    };
Note: See TracChangeset for help on using the changeset viewer.