Changeset 102558 in webkit

Timestamp:

Dec 11, 2011 11:01:29 PM (12 years ago)

Author:

haraken@chromium.org

Message:

Use [Supplemental] IDL in WebSocket
​https://bugs.webkit.org/show_bug.cgi?id=74160

Reviewed by Adam Barth.

By using the [Supplemental] IDL, this patch moves declarations of WebSocket
attributes from DOMWindow.idl to websocket/DOMWindowWebSocket.idl,
which helps make WebSocket a self-contained module.

No new tests, no change in behavior.
Confirm that http/tests/websocket/* pass.

• WebCore.gypi: Added DOMWindowWebSocket.idl.
• page/DOMWindow.idl: Added the [Supplemented] IDL to WebSocket-related attributes. This [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL (See bug 73394 for more details).
• websockets/DOMWindowWebSocket.idl: Added. Used the [Supplemental=DOMWindow] IDL. The attributes in this IDL file are treated as if they are described in DOMWindow.idl.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gypi (modified) (1 diff)
• page/DOMWindow.idl (modified) (2 diffs)
• websockets/DOMWindowWebSocket.idl (added)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-11  Kentaro Hara  <haraken@chromium.org>
+
+        Use [Supplemental] IDL in WebSocket
+        https://bugs.webkit.org/show_bug.cgi?id=74160
+
+        Reviewed by Adam Barth.
+
+        By using the [Supplemental] IDL, this patch moves declarations of WebSocket
+        attributes from DOMWindow.idl to websocket/DOMWindowWebSocket.idl,
+        which helps make WebSocket a self-contained module.
+
+        No new tests, no change in behavior.
+        Confirm that http/tests/websocket/* pass.
+
+        * WebCore.gypi: Added DOMWindowWebSocket.idl.
+        * page/DOMWindow.idl: Added the [Supplemented] IDL to WebSocket-related attributes. This [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL (See bug 73394 for more details).
+        * websockets/DOMWindowWebSocket.idl: Added. Used the [Supplemental=DOMWindow] IDL. The attributes in this IDL file are treated as if they are described in DOMWindow.idl.
+
 2011-12-11  Luke Macpherson   <macpherson@chromium.org>
 

trunk/Source/WebCore/WebCore.gypi

@@ -1507 +1507 @@
             'webaudio/WaveShaperNode.idl',
             'websockets/CloseEvent.idl',
+            'websockets/DOMWindowWebSocket.idl',
             'websockets/WebSocket.idl',
             'workers/AbstractWorker.idl',

trunk/Source/WebCore/page/DOMWindow.idl

@@ -551 +551 @@
         attribute [Conditional=DEVICE_ORIENTATION, EnabledAtRuntime] DeviceOrientationEventConstructor DeviceOrientationEvent;
         attribute [Conditional=TOUCH_EVENTS] TouchEventConstructor TouchEvent;
-        attribute [Conditional=WEB_SOCKETS] CloseEventConstructor CloseEvent;
+        attribute [Supplemented, Conditional=WEB_SOCKETS] CloseEventConstructor CloseEvent;
         attribute StorageEventConstructor StorageEvent;
         attribute [Supplemented, Conditional=WEB_AUDIO] AudioProcessingEventConstructor AudioProcessingEvent;
@@ -607 +607 @@
 
 #if defined(ENABLE_WEB_SOCKETS) && ENABLE_WEB_SOCKETS
-        attribute [JSCCustomGetter,EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator
+        attribute [Supplemented, JSCCustomGetter, EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator
 #endif